Re: [Numpy-discussion] Attribute hiding APIs for PyArrayObject

2018-10-31 Thread Ralf Gommers
On Wed, Oct 31, 2018 at 4:01 PM Charles R Harris wrote: > > > On Wed, Oct 31, 2018 at 3:59 PM Allan Haldane > wrote: > >> On 10/30/18 5:04 AM, Matti Picus wrote: >> > TL;DR - should we revert the attribute-hiding constructs in >> > ndarraytypes.h and unify PyArrayObject_fields with PyArrayObject

Re: [Numpy-discussion] Attribute hiding APIs for PyArrayObject

2018-10-31 Thread Charles R Harris
On Wed, Oct 31, 2018 at 3:59 PM Allan Haldane wrote: > On 10/30/18 5:04 AM, Matti Picus wrote: > > TL;DR - should we revert the attribute-hiding constructs in > > ndarraytypes.h and unify PyArrayObject_fields with PyArrayObject? > > > > > > Background > > > > > > NumPy 1.8 deprecated direct acces

Re: [Numpy-discussion] Attribute hiding APIs for PyArrayObject

2018-10-31 Thread Allan Haldane
On 10/30/18 5:04 AM, Matti Picus wrote: > TL;DR - should we revert the attribute-hiding constructs in > ndarraytypes.h and unify PyArrayObject_fields with PyArrayObject? > > > Background > > > NumPy 1.8 deprecated direct access to PyArrayObject fields. It made > PyArrayObject "opaque", and hid

Re: [Numpy-discussion] Attribute hiding APIs for PyArrayObject

2018-10-31 Thread Petr Viktorin
On 10/31/18 03:33, Nathaniel Smith wrote: It's probably helpful to know that Py_LIMITED_API is a kinda-experimental thing that was added in CPython 3.2 (see PEP 384) and remains almost 100% unused. It has never been a popular or influential thing (for better or worse). Py_LIMITED_API is not ver

Re: [Numpy-discussion] Attribute hiding APIs for PyArrayObject

2018-10-30 Thread Nathaniel Smith
It's probably helpful to know that Py_LIMITED_API is a kinda-experimental thing that was added in CPython 3.2 (see PEP 384) and remains almost 100% unused. It has never been a popular or influential thing (for better or worse). -n On Tue, Oct 30, 2018 at 6:41 PM, Eric Wieser wrote: > In NumPy 1.

Re: [Numpy-discussion] Attribute hiding APIs for PyArrayObject

2018-10-30 Thread Eric Wieser
In NumPy 1.14 we changed UPDATEIFCOPY to WRITEBACKIFCOPY, and in 1.16 we would like to deprecate PyArray_SetNumericOps and PyArray_GetNumericOps. The strange warning when NPY_NO_DEPRICATED_API is annoying I’m not sure I make the connection here between hidden fields and API deprecation. You seem t