Re: [Numpy-discussion] Allowing broadcasting of code dimensions in generalized ufuncs

2018-06-10 Thread Marten van Kerkwijk
OK, I spent my Sunday morning writing a NEP. I hope this can lead to some closure... See https://github.com/numpy/numpy/pull/11297 -- Marten ___ NumPy-Discussion mailing list NumPy-Discussion@python.org https://mail.python.org/mailman/listinfo/numpy-discu

Re: [Numpy-discussion] Allowing broadcasting of code dimensions in generalized ufuncs

2018-06-10 Thread Eric Wieser
Rendered here: https://github.com/mhvk/numpy/blob/nep-gufunc-signature-enhancement/doc/neps/nep-0020-gufunc-signature-enhancement.rst Eric On Sun, 10 Jun 2018 at 09:37 Marten van Kerkwijk wrote: > OK, I spent my Sunday morning writing a NEP. I hope this can lead to some > closure... > See http

Re: [Numpy-discussion] Allowing broadcasting of code dimensions in generalized ufuncs

2018-06-10 Thread Eric Wieser
Thanks for the writeup Marten, Nathaniel: Output shape feels very similar to output dtype to me, so maybe the general way to handle this would be to make the first callback take the input shapes+dtypes and return the desired output shapes+dtypes? This hits on an interesting alternative to frozen

Re: [Numpy-discussion] NEP: Random Number Generator Policy

2018-06-10 Thread Ralf Gommers
On Mon, Jun 4, 2018 at 3:18 PM, Robert Kern wrote: > On Sun, Jun 3, 2018 at 8:22 PM Ralf Gommers > wrote: > >> It may be worth having a look at test suites for scipy, statsmodels, >> scikit-learn, etc. and estimate how much work this NEP causes those >> projects. If the devs of those packages ar

Re: [Numpy-discussion] NEP: Random Number Generator Policy

2018-06-10 Thread Ralf Gommers
On Sun, Jun 3, 2018 at 9:23 PM, Warren Weckesser wrote: > > > On Sun, Jun 3, 2018 at 11:20 PM, Ralf Gommers > wrote: > >> >> >> On Sun, Jun 3, 2018 at 6:54 PM, wrote: >> >>> >>> >>> On Sun, Jun 3, 2018 at 9:08 PM, Robert Kern >>> wrote: >>> On Sun, Jun 3, 2018 at 5:46 PM wrote:

Re: [Numpy-discussion] Allowing broadcasting of code dimensions in generalized ufuncs

2018-06-10 Thread Stephan Hoyer
In Sun, Jun 10, 2018 at 4:31 PM Eric Wieser wrote: > Thanks for the writeup Marten, > Indeed, thank you Marten! > This hits on an interesting alternative to frozen dimensions - np.cross > could just become a regular ufunc with signature np.dtype((float64, 3)), > np.dtype((float64, 3)) → np.dtype

Re: [Numpy-discussion] NEP: Random Number Generator Policy

2018-06-10 Thread Robert Kern
On Sun, Jun 10, 2018 at 5:47 PM Ralf Gommers wrote: > > On Sun, Jun 3, 2018 at 9:23 PM, Warren Weckesser < warren.weckes...@gmail.com> wrote: >> I suspect many of the tests will be easy to update, so fixing 300 or so tests does not seem like a monumental task. > > It's all not monumental, but it

Re: [Numpy-discussion] NEP: Random Number Generator Policy

2018-06-10 Thread Robert Kern
On Sun, Jun 10, 2018 at 5:27 PM Ralf Gommers wrote: > > On Mon, Jun 4, 2018 at 3:18 PM, Robert Kern wrote: >> >> On Sun, Jun 3, 2018 at 8:22 PM Ralf Gommers wrote: >>> >>> It may be worth having a look at test suites for scipy, statsmodels, scikit-learn, etc. and estimate how much work this NEP

Re: [Numpy-discussion] NEP: Random Number Generator Policy

2018-06-10 Thread josef . pktd
On Sun, Jun 10, 2018 at 9:08 PM, Robert Kern wrote: > On Sun, Jun 10, 2018 at 5:27 PM Ralf Gommers > wrote: > > > > On Mon, Jun 4, 2018 at 3:18 PM, Robert Kern > wrote: > >> > >> On Sun, Jun 3, 2018 at 8:22 PM Ralf Gommers > wrote: > >>> > >>> It may be worth having a look at test suites for s

Re: [Numpy-discussion] NEP: Random Number Generator Policy

2018-06-10 Thread Ralf Gommers
On Sun, Jun 10, 2018 at 6:08 PM, Robert Kern wrote: > On Sun, Jun 10, 2018 at 5:27 PM Ralf Gommers > wrote: > > > > On Mon, Jun 4, 2018 at 3:18 PM, Robert Kern > wrote: > >> > >> On Sun, Jun 3, 2018 at 8:22 PM Ralf Gommers > wrote: > >>> > >>> It may be worth having a look at test suites for s

Re: [Numpy-discussion] NEP: Random Number Generator Policy

2018-06-10 Thread Ralf Gommers
On Sun, Jun 10, 2018 at 5:57 PM, Robert Kern wrote: > On Sun, Jun 10, 2018 at 5:47 PM Ralf Gommers > wrote: > > > > On Sun, Jun 3, 2018 at 9:23 PM, Warren Weckesser < > warren.weckes...@gmail.com> wrote: > > >> I suspect many of the tests will be easy to update, so fixing 300 or so > tests does

Re: [Numpy-discussion] NEP: Random Number Generator Policy

2018-06-10 Thread Stephan Hoyer
On Sun, Jun 10, 2018 at 8:10 PM Ralf Gommers wrote: > On Sun, Jun 10, 2018 at 5:57 PM, Robert Kern > wrote: > >> > Conclusion: the current proposal will cause work for the vast majority >> of libraries that depends on numpy. The total amount of that work will >> certainly not be counted in perso

Re: [Numpy-discussion] NEP: Random Number Generator Policy

2018-06-10 Thread Robert Kern
On Sun, Jun 10, 2018 at 7:46 PM wrote: > > On Sun, Jun 10, 2018 at 9:08 PM, Robert Kern wrote: >> >> On Sun, Jun 10, 2018 at 5:27 PM Ralf Gommers wrote: >> > >> > On Mon, Jun 4, 2018 at 3:18 PM, Robert Kern wrote: >> >> >> >> On Sun, Jun 3, 2018 at 8:22 PM Ralf Gommers wrote: >> >>> >> >>> It

Re: [Numpy-discussion] NEP: Random Number Generator Policy

2018-06-10 Thread Robert Kern
On Sun, Jun 10, 2018 at 8:04 PM Ralf Gommers wrote: > > On Sun, Jun 10, 2018 at 6:08 PM, Robert Kern wrote: >> >> On Sun, Jun 10, 2018 at 5:27 PM Ralf Gommers wrote: >> > >> > On Mon, Jun 4, 2018 at 3:18 PM, Robert Kern wrote: >> >> >> >> On Sun, Jun 3, 2018 at 8:22 PM Ralf Gommers wrote: >> >

Re: [Numpy-discussion] NEP: Random Number Generator Policy

2018-06-10 Thread Robert Kern
On Sun, Jun 10, 2018 at 8:11 PM Ralf Gommers wrote: > > On Sun, Jun 10, 2018 at 5:57 PM, Robert Kern wrote: >> >> On Sun, Jun 10, 2018 at 5:47 PM Ralf Gommers wrote: >> > >> > On Sun, Jun 3, 2018 at 9:23 PM, Warren Weckesser < warren.weckes...@gmail.com> wrote: >> >> >> I suspect many of the tes

Re: [Numpy-discussion] NEP: Random Number Generator Policy

2018-06-10 Thread Ralf Gommers
On Sun, Jun 10, 2018 at 10:36 PM, Robert Kern wrote: > On Sun, Jun 10, 2018 at 8:04 PM Ralf Gommers > wrote: > > > > On Sun, Jun 10, 2018 at 6:08 PM, Robert Kern > wrote: > >> > >> On Sun, Jun 10, 2018 at 5:27 PM Ralf Gommers > wrote: > >> > > >> > On Mon, Jun 4, 2018 at 3:18 PM, Robert Kern

Re: [Numpy-discussion] NEP: Random Number Generator Policy

2018-06-10 Thread Ralf Gommers
On Sun, Jun 10, 2018 at 11:15 PM, Robert Kern wrote: > On Sun, Jun 10, 2018 at 8:11 PM Ralf Gommers > wrote: > > > > On Sun, Jun 10, 2018 at 5:57 PM, Robert Kern > wrote: > >> > >> On Sun, Jun 10, 2018 at 5:47 PM Ralf Gommers > wrote: > >> > > >> > On Sun, Jun 3, 2018 at 9:23 PM, Warren Weckes