[Numpy-discussion] Possible Deprecation of np.ediff1d

2018-08-27 Thread Tyler Reddy
Chuck suggested ( https://github.com/numpy/numpy/pull/11805#issuecomment-416069436 ) that we may want to consider deprecating np.ediff1d, which is perhaps not much more useful than np.diff, apart from having some arguably strange prepend / append behavior added in. Related discussion on SO: https:

Re: [Numpy-discussion] Possible Deprecation of np.ediff1d

2018-08-27 Thread Robert Kern
On Mon, Aug 27, 2018 at 10:30 AM Tyler Reddy wrote: > Chuck suggested ( > https://github.com/numpy/numpy/pull/11805#issuecomment-416069436 ) that > we may want to consider deprecating np.ediff1d, which is perhaps not much > more useful than np.diff, apart from having some arguably strange prepend

Re: [Numpy-discussion] Possible Deprecation of np.ediff1d

2018-08-27 Thread Robert Cimrman
Hi, it was originally used in other functions of arraysetops (culprit yours truly) which used to use the padding functionality. Nowadays the only use I can see git-grepping the numpy sources is in the tests, so +1 for deprecating. Cheers, r. On 08/27/2018 07:28 PM, Tyler Reddy wrote: Chuck

Re: [Numpy-discussion] Possible Deprecation of np.ediff1d

2018-08-27 Thread Charles R Harris
On Mon, Aug 27, 2018 at 11:37 AM Robert Kern wrote: > On Mon, Aug 27, 2018 at 10:30 AM Tyler Reddy > wrote: > >> Chuck suggested ( >> https://github.com/numpy/numpy/pull/11805#issuecomment-416069436 ) that >> we may want to consider deprecating np.ediff1d, which is perhaps not much >> more usefu

Re: [Numpy-discussion] Possible Deprecation of np.ediff1d

2018-08-27 Thread Eric Wieser
There is already a patch to add such a feature to np.diff at https://github.com/numpy/numpy/pull/8206 ​ On Mon, 27 Aug 2018 at 10:47 Charles R Harris wrote: > On Mon, Aug 27, 2018 at 11:37 AM Robert Kern > wrote: > >> On Mon, Aug 27, 2018 at 10:30 AM Tyler Reddy >> wrote: >> >>> Chuck suggeste

Re: [Numpy-discussion] Possible Deprecation of np.ediff1d

2018-08-27 Thread josef . pktd
On Mon, Aug 27, 2018 at 1:46 PM, Charles R Harris wrote: > > > On Mon, Aug 27, 2018 at 11:37 AM Robert Kern > wrote: > >> On Mon, Aug 27, 2018 at 10:30 AM Tyler Reddy >> wrote: >> >>> Chuck suggested ( https://github.com/numpy/ >>> numpy/pull/11805#issuecomment-416069436 ) that we may want to c

Re: [Numpy-discussion] Possible Deprecation of np.ediff1d

2018-08-27 Thread Stephan Hoyer
On Mon, Aug 27, 2018 at 10:30 AM Tyler Reddy wrote: > Chuck suggested ( > https://github.com/numpy/numpy/pull/11805#issuecomment-416069436 ) that > we may want to consider deprecating np.ediff1d, which is perhaps not much > more useful than np.diff, apart from having some arguably strange prepend