[Numpy-discussion] Adding a "suffle=True" kwarg to numpy.random.Generator.choice

2019-07-09 Thread Matti Picus
In PR https://github.com/numpy/numpy/pull/13812, Thrasibule rewrote the algorithm used with a faster alternative branch for some cases. The faster algorithm does not necessarily shuffle the results, so for instance gen.choice(2000, 2000, replace=False) may simply return arange(2000). In the old

Re: [Numpy-discussion] Adding a "suffle=True" kwarg to numpy.random.Generator.choice

2019-07-09 Thread Stephan Hoyer
This sounds like a welcome backwards compatible option for more performance. I imagine there are plenty of applications (e.g., sets) where shuffled order doesn't matter. +1 from me. On Tue, Jul 9, 2019 at 5:32 PM Matti Picus wrote: > In PR https://github.com/numpy/numpy/pull/13812, Thrasibule