[Numpy-discussion] Addition of new distributions: Polya-gamma

2020-12-27 Thread Zolisa Bleki
Hi All, I would like to know if Numpy accepts addition of new distributions since the implementation of the Generator interface. If so, what is the criteria for a particular distribution to be accepted? The reason why i'm asking is because I would like to propose adding the Polya-gamma distribu

Re: [Numpy-discussion] Addition of new distributions: Polya-gamma

2020-12-27 Thread Tom Swirly
I'm just a lurker, but I spent a minute or two to look at that commit, which looks to be high quality. While I personally have not used this distribution, people I know use it all the time (for ML). A quibble: #define NPY_PI 3.141592653589793238462643383279502884 /* pi */ and the following def

Re: [Numpy-discussion] Addition of new distributions: Polya-gamma

2020-12-27 Thread Stephan Hoyer
Thanks for putting together this clean implementation! My concern is that Polya-Gamma is not popular enough to warrant inclusion in NumPy, which tries very hard to limit scope these days. For example, Polya-Gamma isn’t implemented in scioy.stats and doesn’t have a Wikipedia page, both of which are