[Numpy-discussion] Re: Automatic formatters for only changed lines

2022-05-06 Thread Matti Picus
On 6/5/22 09:09, Stefan van der Walt wrote: Hi Matti, On Thu, May 5, 2022, at 22:08, Matti Picus wrote: This somehow runs when I do "git commit"? Do I need to add anything to my git environment to pick up the hook? How do I turn it off if I find it prevents progress or breaks? Do we need to ad

[Numpy-discussion] Re: Automatic formatters for only changed lines

2022-05-06 Thread Sebastian Berg
On Thu, 2022-05-05 at 15:32 -0700, Stefan van der Walt wrote: > On Thu, May 5, 2022, at 12:00, Trevor Gross wrote: > > I don't necessarily know that this should be enforced on CI off the > > bat (though in the future it could be), but at least having the > > tool available and easily usable would h

[Numpy-discussion] Re: Automatic formatters for only changed lines

2022-05-06 Thread Pamphile ROY
Hi, By running `pre-commit install` you are registering the hook directly into the .git folder of the project. So no matter if you have an env activated or not it works. Behind the scene, pre-commit uses it's own virtual env to run the hooks. This is why typically it's just used for static anal

[Numpy-discussion] Re: Automatic formatters for only changed lines

2022-05-06 Thread Charles R Harris
On Fri, May 6, 2022 at 2:10 AM Sebastian Berg wrote: > On Thu, 2022-05-05 at 15:32 -0700, Stefan van der Walt wrote: > > On Thu, May 5, 2022, at 12:00, Trevor Gross wrote: > > > I don't necessarily know that this should be enforced on CI off the > > > bat (though in the future it could be), but a