[Numpy-discussion] Re: Formally accept NEP 51: Changing the Representation of NumPy Scalars

2022-11-29 Thread Stefan van der Walt
On Fri, Nov 25, 2022, at 08:33, Sebastian Berg wrote: > I would like to formally propose accepting NEP 51. Without any concern > voiced, we will consider it accepted within 7 days. +1 We should update the NEP to match any changes made later, like `np.str_` and `np.bool_`, so that we have a good

[Numpy-discussion] Re: Formally accept NEP 51: Changing the Representation of NumPy Scalars

2022-11-29 Thread Aaron Meurer
On Fri, Nov 25, 2022 at 9:36 AM Sebastian Berg wrote: > > Hi all, > > I would like to formally propose accepting NEP 51. Without any concern > voiced, we will consider it accepted within 7 days. > > As a reminder, this is to change the representation of NumPy scalars to > be consistent and includ

[Numpy-discussion] Expanding support in testing for external collections.Sequence objects

2022-11-29 Thread info
See issue https://github.com/numpy/numpy/issues/22569. The debate is whether np.testing.asset_equal should support collections.Sequence objects. As you can see, a bug has been reported and an easy fix has been suggested. What is the general view on adding support in testing for Sequence object

[Numpy-discussion] Re: Expanding support in testing for external collections.Sequence objects

2022-11-29 Thread Stefan van der Walt
On Tue, Nov 29, 2022, at 07:21, i...@markopacak.com wrote: > The debate is whether np.testing.asset_equal should support > collections.Sequence objects. assert list(sequence1) == list(sequence2) should do the trick, and also handles int vs float and nan comparisons. > What is the general view