[Numpy-discussion] Re: Categorical dtypes

2023-05-30 Thread Sebastian Berg
On Mon, 2023-05-29 at 10:55 +1000, Juan Nunez-Iglesias wrote: > Hi folks, > > Apologies if this is documented somewhere, but I haven't been able to > find it. I've read through NEP-42 [1] and skimmed NEP-41 [2], but I'm > not sure: > > (a) at what point of implementation we are, and > (b) if it's

[Numpy-discussion] Re: Welcome Nathan Goldbaum as a Maintainer

2023-05-30 Thread Nathan
Thanks so much everyone! On Mon, May 29, 2023 at 9:00 AM Ross Barnowski wrote: > Welcome Nathan! > > On Mon, May 29, 2023 at 7:47 AM Charles R Harris < > charlesr.har...@gmail.com> wrote: > >> >> >> On Mon, May 29, 2023 at 1:15 AM Sebastian Berg < >> sebast...@sipsolutions.net> wrote: >> >>> Hi

[Numpy-discussion] Re: Categorical dtypes

2023-05-30 Thread Juan Nunez-Iglesias
Thanks for the response, Sebastian! I'll keep an eye out on that repo. Should there be (is there already) a link to it from the docs? On Tue, 30 May 2023, at 6:21 PM, Sebastian Berg wrote: > On Mon, 2023-05-29 at 10:55 +1000, Juan Nunez-Iglesias wrote: >> Hi folks, >> >> Apologies if this is doc

[Numpy-discussion] Precision changes to sin/cos in the next release?

2023-05-30 Thread Sebastian Berg
Hi all, there was recently a PR to NumPy to improve the performance of sin/cos on most platforms (on my laptop it seems to be about 5x on simple inputs). This changes the error bounds on platforms that were not previously accelerated (most users): https://github.com/numpy/numpy/pull/23399 Th

[Numpy-discussion] Re: Precision changes to sin/cos in the next release?

2023-05-30 Thread Juan Nunez-Iglesias
For me it is indeed too surprising, and I would be in favour of reverting. On Wed, 31 May 2023, at 3:55 PM, Sebastian Berg wrote: > Hi all, > > there was recently a PR to NumPy to improve the performance of sin/cos > on most platforms (on my laptop it seems to be about 5x on simple > inputs). > Th

[Numpy-discussion] Re: Precision changes to sin/cos in the next release?

2023-05-30 Thread Juan Nunez-Iglesias
On Wed, 31 May 2023, at 4:11 PM, Juan Nunez-Iglesias wrote: > For me it is indeed too surprising, and I would be in favour of reverting. (👆 Incidentally I wrote that before seeing https://github.com/scikit-image/scikit-image/pull/6970 😂) > On Wed, 31 May 2023, at 3:55 PM, Sebastian Berg wrote: >

[Numpy-discussion] Re: Precision changes to sin/cos in the next release?

2023-05-30 Thread Stefan van der Walt
Hi Sebastian, Could you clarify whether there are now varying code paths, depending on the CPU features available? As mentioned on the skimage issue, if results differ but errors are reduced across the board, I'd be happy to fix the test suite. But if this simply jiggers results, I'm less su

[Numpy-discussion] Re: Precision changes to sin/cos in the next release?

2023-05-30 Thread Jerome Kieffer
Hi Sebastian, I had a quick look at the PR and it looks like you re-implemented the sin-cos function using SIMD. I wonder how it compares with SLEEF (header only library, CPU-architecture agnostic SIMD implementation of transcendental functions with precision validation). SLEEF is close to the In

[Numpy-discussion] Re: Precision changes to sin/cos in the next release?

2023-05-30 Thread Sebastian Berg
On Tue, 2023-05-30 at 23:31 -0700, Stefan van der Walt wrote: > Hi Sebastian, > > Could you clarify whether there are now varying code paths, depending > on the CPU features available? There is less variation then before because the new code path will be taken on practically all CPUs and I wou