Re: [Numpy-discussion] RFR: #1008 Loss of precision in (complex) arcsinh arctanh

2009-03-02 Thread Darren Dale
On Sat, Feb 28, 2009 at 10:34 AM, David Cournapeau courn...@gmail.comwrote: On Sat, Feb 28, 2009 at 11:08 PM, Pauli Virtanen p...@iki.fi wrote: http://scipy.org/scipy/numpy/ticket/1008 http://codereview.appspot.com/22054 I added a few comments - the only significant one concerns types

Re: [Numpy-discussion] RFR: #1008 Loss of precision in (complex) arcsinh arctanh

2009-03-02 Thread Pauli Virtanen
Mon, 02 Mar 2009 15:45:30 -0500, Darren Dale wrote: [clip] I saw some related test failures after updating and reinstalling my checkout. Deleting build and site-packages/numpy, and then reinstalling was all that was required for the tests to pass. The distutils build system apparently doesn't

[Numpy-discussion] RFR: #1008 Loss of precision in (complex) arcsinh arctanh

2009-02-28 Thread Pauli Virtanen
http://scipy.org/scipy/numpy/ticket/1008 http://codereview.appspot.com/22054 -- Pauli Virtanen ___ Numpy-discussion mailing list Numpy-discussion@scipy.org http://projects.scipy.org/mailman/listinfo/numpy-discussion

Re: [Numpy-discussion] RFR: #1008 Loss of precision in (complex) arcsinh arctanh

2009-02-28 Thread Stéfan van der Walt
Hey Pauli 2009/2/28 Pauli Virtanen p...@iki.fi: http://scipy.org/scipy/numpy/ticket/1008 http://codereview.appspot.com/22054 Fantastic patch! Please apply. Cheers Stéfan ___ Numpy-discussion mailing list Numpy-discussion@scipy.org

Re: [Numpy-discussion] RFR: #1008 Loss of precision in (complex) arcsinh arctanh

2009-02-28 Thread David Cournapeau
On Sat, Feb 28, 2009 at 11:08 PM, Pauli Virtanen p...@iki.fi wrote: http://scipy.org/scipy/numpy/ticket/1008 http://codereview.appspot.com/22054 I added a few comments - the only significant one concerns types for unit tests: I think it would be nice to test for float and long double as well.