[Numpy-discussion] np 1.7b2 PyArray_BYTES(obj)=ptr fail

2012-10-02 Thread Frédéric Bastien
Hi, I don't know if that was raised or not, but in np1.7b2 doing this fail with this error message: PyArray_BYTES(obj)=ptr file:lne_number:offset: error: lvalue required as left operatnd of assignment. I tried with PyArray_DATA(obj)=ptr and this also fail. Do you want to remove this feature no

Re: [Numpy-discussion] np 1.7b2 PyArray_BYTES(obj)=ptr fail

2012-10-02 Thread Charles R Harris
On Tue, Oct 2, 2012 at 8:34 AM, Frédéric Bastien wrote: > Hi, > > I don't know if that was raised or not, but in np1.7b2 doing this fail > with this error message: > > PyArray_BYTES(obj)=ptr > > file:lne_number:offset: error: lvalue required as left operatnd of > assignment. > > I tried with PyAr

Re: [Numpy-discussion] np 1.7b2 PyArray_BYTES(obj)=ptr fail

2012-10-02 Thread Frédéric Bastien
We implement our own subtensor(x[...], where ... can be index or slice) c code due to the way Theano work. I can probably change the logic, but if you plan to revert this interface changes, I prefer to wait for this change we someone else is doing other changes that would conflict. Also, I did a T

Re: [Numpy-discussion] np 1.7b2 PyArray_BYTES(obj)=ptr fail

2012-10-02 Thread Charles R Harris
On Tue, Oct 2, 2012 at 9:45 AM, Frédéric Bastien wrote: > We implement our own subtensor(x[...], where ... can be index or > slice) c code due to the way Theano work. > > I can probably change the logic, but if you plan to revert this > interface changes, I prefer to wait for this change we someo

Re: [Numpy-discussion] np 1.7b2 PyArray_BYTES(obj)=ptr fail

2012-10-02 Thread Frédéric Bastien
On Tue, Oct 2, 2012 at 1:18 PM, Charles R Harris wrote: > > > On Tue, Oct 2, 2012 at 9:45 AM, Frédéric Bastien wrote: >> >> We implement our own subtensor(x[...], where ... can be index or >> slice) c code due to the way Theano work. >> >> I can probably change the logic, but if you plan to rever

Re: [Numpy-discussion] np 1.7b2 PyArray_BYTES(obj)=ptr fail

2012-10-02 Thread Charles R Harris
On Tue, Oct 2, 2012 at 11:30 AM, Frédéric Bastien wrote: > On Tue, Oct 2, 2012 at 1:18 PM, Charles R Harris > wrote: > > > > > > On Tue, Oct 2, 2012 at 9:45 AM, Frédéric Bastien > wrote: > >> > >> We implement our own subtensor(x[...], where ... can be index or > >> slice) c code due to the way

Re: [Numpy-discussion] np 1.7b2 PyArray_BYTES(obj)=ptr fail

2012-10-02 Thread Charles R Harris
On Tue, Oct 2, 2012 at 11:43 AM, Charles R Harris wrote: > > > On Tue, Oct 2, 2012 at 11:30 AM, Frédéric Bastien wrote: > >> On Tue, Oct 2, 2012 at 1:18 PM, Charles R Harris >> wrote: >> > >> > >> > On Tue, Oct 2, 2012 at 9:45 AM, Frédéric Bastien >> wrote: >> >> >> >> We implement our own sub

Re: [Numpy-discussion] np 1.7b2 PyArray_BYTES(obj)=ptr fail

2012-10-02 Thread Charles R Harris
On Tue, Oct 2, 2012 at 11:47 AM, Charles R Harris wrote: > > > On Tue, Oct 2, 2012 at 11:43 AM, Charles R Harris < > charlesr.har...@gmail.com> wrote: > >> >> >> On Tue, Oct 2, 2012 at 11:30 AM, Frédéric Bastien wrote: >> >>> On Tue, Oct 2, 2012 at 1:18 PM, Charles R Harris >>> wrote: >>> > >>>

Re: [Numpy-discussion] np 1.7b2 PyArray_BYTES(obj)=ptr fail

2012-10-02 Thread Frédéric Bastien
With numpy 1.6.2, it is working. So this is an interface change. Are you sure you want this? This break existing code. I do not understand what you mean by slot? I'm not sure is the PyArray_SWAP is a good long term idea. I would not make it if it is only for temporarily. To set the base ptr, the

Re: [Numpy-discussion] np 1.7b2 PyArray_BYTES(obj)=ptr fail

2012-10-02 Thread Charles R Harris
On Tue, Oct 2, 2012 at 1:44 PM, Frédéric Bastien wrote: > With numpy 1.6.2, it is working. So this is an interface change. Are > you sure you want this? This break existing code. > > I do not understand what you mean by slot? > Pythonese for structure member ;) > > I'm not sure is the PyArray_

Re: [Numpy-discussion] np 1.7b2 PyArray_BYTES(obj)=ptr fail

2012-11-06 Thread Frédéric Bastien
Hi, I made a PR with my fix: https://github.com/numpy/numpy/pull/2709 Frédéric On Tue, Oct 2, 2012 at 6:18 PM, Charles R Harris wrote: > > > On Tue, Oct 2, 2012 at 1:44 PM, Frédéric Bastien wrote: > >> With numpy 1.6.2, it is working. So this is an interface change. Are >> you sure you want