Re: [Numpy-discussion] patch for structured array comparison bug

2010-10-19 Thread Mark Wiebe
On Tue, Oct 19, 2010 at 12:35 PM, Charles R Harris < charlesr.har...@gmail.com> wrote: > >> > We're still working things out after the move, so you get to be sort of a > guinea pig ;) I think a pull request is the way to go. > Sounds good. :) > > > You can request a pull of the branch. Just

Re: [Numpy-discussion] patch for structured array comparison bug

2010-10-19 Thread Charles R Harris
On Tue, Oct 19, 2010 at 1:00 PM, Mark Wiebe wrote: > On Tue, Oct 19, 2010 at 2:24 AM, Pauli Virtanen wrote: > >> Tue, 19 Oct 2010 01:09:54 -0600, Charles R Harris wrote: >> [clip] >> > Just a quick look. I wasn't able to add comments to the code, maybe a >> > pull request would allow that or may

Re: [Numpy-discussion] patch for structured array comparison bug

2010-10-19 Thread Mark Wiebe
On Tue, Oct 19, 2010 at 2:24 AM, Pauli Virtanen wrote: > Tue, 19 Oct 2010 01:09:54 -0600, Charles R Harris wrote: > [clip] > > Just a quick look. I wasn't able to add comments to the code, maybe a > > pull request would allow that or maybe you need to enable something. > > I think you can only ad

Re: [Numpy-discussion] patch for structured array comparison bug

2010-10-19 Thread Pauli Virtanen
Tue, 19 Oct 2010 01:09:54 -0600, Charles R Harris wrote: [clip] > Just a quick look. I wasn't able to add comments to the code, maybe a > pull request would allow that or maybe you need to enable something. I think you can only add comments on commits, not in Github's compare view. > Also, it is

Re: [Numpy-discussion] patch for structured array comparison bug

2010-10-19 Thread Charles R Harris
On Mon, Oct 18, 2010 at 7:13 PM, Mark Wiebe wrote: > I found a bug in structured array comparison when fields have > multi-dimensional types. I created a ticket here: > > http://projects.scipy.org/numpy/ticket/1640 > > and a patch here: > > http://github.com/m-paradox/numpy/compare/master...fix_

[Numpy-discussion] patch for structured array comparison bug

2010-10-18 Thread Mark Wiebe
I found a bug in structured array comparison when fields have multi-dimensional types. I created a ticket here: http://projects.scipy.org/numpy/ticket/1640 and a patch here: http://github.com/m-paradox/numpy/compare/master...fix_structured_compare Could someone review it for me? Thanks, Mark