Hello gents, correct me if I'm wrong, but I consider including autoconf-generated config.h into publicly visible project headers (i.e. in a dev. package) quite bad habit---just like net-snmp package does on Fedora and Solaris. (Btw, does anyone know why it's like that only on those 2 systems? At least it appears so...)
I've noticed that there's actually a patch of this in the snmp-ups driver (but it popped out on me, again, since I didn't know about this particular problem). However, I consider the patch logic inverted (or maybe even perverted) since it actually undefines our NUT symbols and replaces them with those from net-snmp, which is IMO incorrect and may be even dangerous (if somebody wants to actually use them in the code...). So, I was thinking about revert this patch---i.e. include the net-snmp-config.h (and other headers) within a wrapper header, which would subsequently undefine the colliding symbols (see http://buildbot.networkupstools.org/public/nut/builders/Solaris-sparc/builds/244/steps/compile/logs/warnings%20%2875%29 for instance). snmp-ups.c (or any other code that needs the header) would have to include it early... So it's not a perfect solution at all, but it's at least a bit more universal. So what do you think; is it worth it? Thanks, Regards, vasek -- Václav Krpec Network UPS Tools project Eaton Opensource Team ----------------------------- Eaton Elektrotechnika s.r.o. ~ S�dlo spolecnosti, jak je zaps�no v rejstr�ku: Kom�rovsk� 2406, Praha 9 - Horn� Pocernice, 193 00, Cesk� Republika ~ Jm�no, m�sto, kde byla spolecnost zaregistrov�na: Praha ~ Identifikacn� c�slo (ICO): 498 11 894 ----------------------------- _______________________________________________ Nut-upsdev mailing list Nut-upsdev@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/nut-upsdev
