Re: [Nutch-dev] make BasicUrlNormalizer.java thread safe

2004-12-20 Thread John X
On Mon, Dec 20, 2004 at 03:40:44PM -0800, Doug Cutting wrote: > John X wrote: > >BasicUrlNormalizer.java should be made thread safe as > > > >< public String normalize(String urlString) > >--- > > > >> public synchronized String normalize(String urlString) > > > > > >If no objection, I will c

Re: [Nutch-dev] make BasicUrlNormalizer.java thread safe

2004-12-20 Thread Doug Cutting
John X wrote: BasicUrlNormalizer.java should be made thread safe as < public String normalize(String urlString) --- public synchronized String normalize(String urlString) If no objection, I will commit it late. Good catch. In general, we should be careful not to synchronize too much. I t

Re: [Nutch-dev] make BasicUrlNormalizer.java thread safe

2004-12-20 Thread ogjunk-nutch
I don't think this is necessary - normalize(String) doesn't use any global vars well, it does, but are those regexp-related built-in classes not thread safe? Otis --- John X <[EMAIL PROTECTED]> wrote: > BasicUrlNormalizer.java should be made thread safe as > > < public String normalize(

[Nutch-dev] make BasicUrlNormalizer.java thread safe

2004-12-20 Thread John X
BasicUrlNormalizer.java should be made thread safe as < public String normalize(String urlString) --- > public synchronized String normalize(String urlString) If no objection, I will commit it late. John __ http://www.neasys.com - A Good Place to B