svn commit: r1310044 - /jackrabbit/oak/trunk/oak-mk/src/main/java/org/apache/jackrabbit/mk/model/CommitBuilder.java

2012-04-05 Thread stefan
Author: stefan Date: Thu Apr 5 20:11:58 2012 New Revision: 1310044 URL: http://svn.apache.org/viewvc?rev=1310044&view=rev Log: OAK-47: NPE with nested add© operation Modified: jackrabbit/oak/trunk/oak-mk/src/main/java/org/apache/jackrabbit/mk/model/CommitBuilder.java Modified: jackrabbit/

svn commit: r1309899 - /jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/kernel/KernelNodeStateEditorTest.java

2012-04-05 Thread mduerig
Author: mduerig Date: Thu Apr 5 15:22:50 2012 New Revision: 1309899 URL: http://svn.apache.org/viewvc?rev=1309899&view=rev Log: OAK-9: Internal tree builder refactor tests: use API instead of internal methods for transient modifications Modified: jackrabbit/oak/trunk/oak-core/src/test/java/

svn commit: r1309895 - in /jackrabbit/oak/trunk/oak-core/src: main/java/org/apache/jackrabbit/oak/kernel/ test/java/org/apache/jackrabbit/oak/kernel/

2012-04-05 Thread mduerig
Author: mduerig Date: Thu Apr 5 15:15:57 2012 New Revision: 1309895 URL: http://svn.apache.org/viewvc?rev=1309895&view=rev Log: OAK-9: Internal tree builder Remove offset and size parameters from getChildNodes and replace with page wise loading from backend Modified: jackrabbit/oak/trunk/o

svn commit: r1309876 - /jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/kernel/KernelNodeStateEditorFuzzTest.java

2012-04-05 Thread mduerig
Author: mduerig Date: Thu Apr 5 14:19:42 2012 New Revision: 1309876 URL: http://svn.apache.org/viewvc?rev=1309876&view=rev Log: OAK-9: Internal tree builder Enable copy test. OAK-47 which was blocking this seems fixed Modified: jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabb

Re: svn commit: r1309458 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/kernel/KernelNodeState.java

2012-04-05 Thread Thomas Mueller
Hi, >Then the storage mechanism doesn't implement the MicroKernel contract >as currently specified. > >If we want to allow such implementations (one related example was just >discussed in relation to garbage collection), they need to be >reflected in the MicroKernel contract. The later we do that,

svn commit: r1309861 - /jackrabbit/oak/trunk/oak-mk/src/main/java/org/apache/jackrabbit/mk/model/NodeDiffHandler.java

2012-04-05 Thread stefan
Author: stefan Date: Thu Apr 5 13:48:23 2012 New Revision: 1309861 URL: http://svn.apache.org/viewvc?rev=1309861&view=rev Log: remove empty file (refactoring left-over) Removed: jackrabbit/oak/trunk/oak-mk/src/main/java/org/apache/jackrabbit/mk/model/NodeDiffHandler.java

svn commit: r1309844 - in /jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/query: QueryManagerImpl.java QueryResultImpl.java

2012-04-05 Thread thomasm
Author: thomasm Date: Thu Apr 5 13:27:43 2012 New Revision: 1309844 URL: http://svn.apache.org/viewvc?rev=1309844&view=rev Log: OAK-28 Query implementation (API changes) Modified: jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/query/QueryManagerImpl.java jackr

svn commit: r1309843 - in /jackrabbit/oak/trunk/oak-core/src: main/java/org/apache/jackrabbit/oak/query/ test/java/org/apache/jackrabbit/oak/query/ test/resources/org/apache/jackrabbit/oak/query/

2012-04-05 Thread thomasm
Author: thomasm Date: Thu Apr 5 13:27:08 2012 New Revision: 1309843 URL: http://svn.apache.org/viewvc?rev=1309843&view=rev Log: OAK-28 Query implementation (XPath to SQL-2 conversion) Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/Query.java jackr

svn commit: r1309842 - in /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/api: QueryEngine.java Result.java

2012-04-05 Thread thomasm
Author: thomasm Date: Thu Apr 5 13:26:39 2012 New Revision: 1309842 URL: http://svn.apache.org/viewvc?rev=1309842&view=rev Log: OAK-34 Define query API (changes as discussed) Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/api/QueryEngine.java jackrabbit

svn commit: r1309840 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/PropertyValueImpl.java

2012-04-05 Thread thomasm
Author: thomasm Date: Thu Apr 5 13:25:09 2012 New Revision: 1309840 URL: http://svn.apache.org/viewvc?rev=1309840&view=rev Log: OAK-28 Query implementation (temporarily support relative properties in SQL-2 to simplify XPath to SQL-2 conversion) Modified: jackrabbit/oak/trunk/oak-core/src/m

svn commit: r1309835 - in /jackrabbit/oak/trunk/oak-core/src: main/java/org/apache/jackrabbit/mk/index/ main/java/org/apache/jackrabbit/mk/simple/ test/java/org/apache/jackrabbit/mk/ test/java/org/apa

2012-04-05 Thread thomasm
Author: thomasm Date: Thu Apr 5 13:06:42 2012 New Revision: 1309835 URL: http://svn.apache.org/viewvc?rev=1309835&view=rev Log: OAK-47 Wrong results and NPE with copy operation (support the copy operation in the Indexer and the SimpleKernel) Modified: jackrabbit/oak/trunk/oak-core/src/main

svn commit: r1309825 - /jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/RepositoryAdaptor.java

2012-04-05 Thread angela
Author: angela Date: Thu Apr 5 12:50:57 2012 New Revision: 1309825 URL: http://svn.apache.org/viewvc?rev=1309825&view=rev Log: OAK-49 - Session.getRepository() should return the object through which the Session was acquired Removed: jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jac

Re: svn commit: r1309740 - /jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/kernel/KernelNodeStateEditorFuzzTest.java

2012-04-05 Thread Michael Dürig
On 5.4.12 12:22, Michael Dürig wrote: On 5.4.12 11:56, Jukka Zitting wrote: Hi, On Thu, Apr 5, 2012 at 12:30 PM, wrote: More thorough tests for KernelNodeStateEditor Can we put this (and other long-running tests) into a separate integration test component? The fuzz test doubled oak-core b

svn commit: r1309802 - in /jackrabbit/oak/trunk: oak-core/pom.xml oak-mk/pom.xml

2012-04-05 Thread mduerig
Author: mduerig Date: Thu Apr 5 12:02:34 2012 New Revision: 1309802 URL: http://svn.apache.org/viewvc?rev=1309802&view=rev Log: OAK-52: Create smoke-test build profile Modified: jackrabbit/oak/trunk/oak-core/pom.xml jackrabbit/oak/trunk/oak-mk/pom.xml Modified: jackrabbit/oak/trunk/oak-

svn commit: r1309769 - in /jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr: RepositoryImpl.java SessionImpl.java

2012-04-05 Thread angela
Author: angela Date: Thu Apr 5 11:25:50 2012 New Revision: 1309769 URL: http://svn.apache.org/viewvc?rev=1309769&view=rev Log: OAK-49 - Session.getRepository() should return the object through which the Session was acquired Modified: jackrabbit/oak/trunk/oak-jcr/src/main/java/org/apache/ja

Re: svn commit: r1309740 - /jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/kernel/KernelNodeStateEditorFuzzTest.java

2012-04-05 Thread Michael Dürig
On 5.4.12 11:56, Jukka Zitting wrote: Hi, On Thu, Apr 5, 2012 at 12:30 PM, wrote: More thorough tests for KernelNodeStateEditor Can we put this (and other long-running tests) into a separate integration test component? The fuzz test doubled oak-core build time for me. Yes that's was my t

Re: svn commit: r1309740 - /jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/kernel/KernelNodeStateEditorFuzzTest.java

2012-04-05 Thread Jukka Zitting
Hi, On Thu, Apr 5, 2012 at 12:30 PM, wrote: > More thorough tests for KernelNodeStateEditor Can we put this (and other long-running tests) into a separate integration test component? The fuzz test doubled oak-core build time for me. BR, Jukka Zitting

svn commit: r1309746 - in /jackrabbit/oak/trunk/oak-core/src: main/java/org/apache/jackrabbit/mk/ main/java/org/apache/jackrabbit/mk/wrapper/ test/java/org/apache/jackrabbit/mk/wrapper/

2012-04-05 Thread jukka
Author: jukka Date: Thu Apr 5 10:50:31 2012 New Revision: 1309746 URL: http://svn.apache.org/viewvc?rev=1309746&view=rev Log: OAK-32: Drop MicroKernel.dispose() Better handling of SimpleKernel and VirtualRepositoryWrapper in MKF Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apa

svn commit: r1309745 - /jackrabbit/oak/trunk/oak-mk/src/test/java/org/apache/jackrabbit/mk/util/CommitGateTest.java

2012-04-05 Thread jukka
Author: jukka Date: Thu Apr 5 10:50:11 2012 New Revision: 1309745 URL: http://svn.apache.org/viewvc?rev=1309745&view=rev Log: Disable assertion that depends on timing (doesn't work on a slow computer) Modified: jackrabbit/oak/trunk/oak-mk/src/test/java/org/apache/jackrabbit/mk/util/CommitGa

svn commit: r1309744 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/mk/server/Server.java

2012-04-05 Thread jukka
Author: jukka Date: Thu Apr 5 10:49:56 2012 New Revision: 1309744 URL: http://svn.apache.org/viewvc?rev=1309744&view=rev Log: Avoid problems with 0.0.0.0 as the socket address Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/mk/server/Server.java Modified: jackr

svn commit: r1309742 - in /jackrabbit/oak/trunk/oak-core: pom.xml src/test/resources/logback-test.xml

2012-04-05 Thread mduerig
Author: mduerig Date: Thu Apr 5 10:44:29 2012 New Revision: 1309742 URL: http://svn.apache.org/viewvc?rev=1309742&view=rev Log: OAK-9: Internal tree builder Added logging configuration for unit tests Added: jackrabbit/oak/trunk/oak-core/src/test/resources/logback-test.xml - copied unch

svn commit: r1309740 - /jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/kernel/KernelNodeStateEditorFuzzTest.java

2012-04-05 Thread mduerig
Author: mduerig Date: Thu Apr 5 10:30:02 2012 New Revision: 1309740 URL: http://svn.apache.org/viewvc?rev=1309740&view=rev Log: OAK-9: Internal tree builder More thorough tests for KernelNodeStateEditor Added: jackrabbit/oak/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/kernel/Kern

Re: svn commit: r1309458 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/kernel/KernelNodeState.java

2012-04-05 Thread Jukka Zitting
HI, On Thu, Apr 5, 2012 at 11:52 AM, Thomas Mueller wrote: > But what if the revision is no longer available, or if the storage > mechanism doesn't support repeatable, consistent reading of all revisions > (eventually consistent model or read committed transaction isolation and > not MVCC). Then

Re: svn commit: r1309458 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/kernel/KernelNodeState.java

2012-04-05 Thread Thomas Mueller
Hi, >Revisions are immutable, so this should never happen. In theory, yes. But what if the revision is no longer available, or if the storage mechanism doesn't support repeatable, consistent reading of all revisions (eventually consistent model or read committed transaction isolation and not MVC

svn commit: r1309721 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/mk/MicroKernelFactory.java

2012-04-05 Thread jukka
Author: jukka Date: Thu Apr 5 09:33:29 2012 New Revision: 1309721 URL: http://svn.apache.org/viewvc?rev=1309721&view=rev Log: OAK-32: Drop MicroKernel.dispose() Merge duplicate code in MKF.getInstance() Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/mk/MicroKer

svn commit: r1309719 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/mk/MicroKernelFactory.java

2012-04-05 Thread jukka
Author: jukka Date: Thu Apr 5 09:29:34 2012 New Revision: 1309719 URL: http://svn.apache.org/viewvc?rev=1309719&view=rev Log: OAK-32: Drop MicroKernel.dispose() Simplify MKF by pre-parsing parts of the repository URL Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabb

svn commit: r1309713 - /jackrabbit/oak/trunk/oak-mk/src/main/java/org/apache/jackrabbit/mk/util/ExceptionFactory.java

2012-04-05 Thread jukka
Author: jukka Date: Thu Apr 5 09:19:49 2012 New Revision: 1309713 URL: http://svn.apache.org/viewvc?rev=1309713&view=rev Log: Remove dead code Modified: jackrabbit/oak/trunk/oak-mk/src/main/java/org/apache/jackrabbit/mk/util/ExceptionFactory.java Modified: jackrabbit/oak/trunk/oak-mk/src/

svn commit: r1309712 - in /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/mk: MicroKernelFactory.java client/Client.java index/IndexWrapper.java wrapper/LogWrapper.java

2012-04-05 Thread jukka
Author: jukka Date: Thu Apr 5 09:18:45 2012 New Revision: 1309712 URL: http://svn.apache.org/viewvc?rev=1309712&view=rev Log: OAK-32: Drop MicroKernel.dispose() Inline more factory methods in to MicroKernelFactory Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/

svn commit: r1309709 - in /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/mk: MicroKernelFactory.java simple/SimpleKernelImpl.java

2012-04-05 Thread jukka
Author: jukka Date: Thu Apr 5 09:09:47 2012 New Revision: 1309709 URL: http://svn.apache.org/viewvc?rev=1309709&view=rev Log: OAK-32: Drop MicroKernel.dispose() Refactor SimpleKernelImpl.get() into MicroKernelFactory to reduce the footprint of factory code Modified: jackrabbit/oak/trunk/o

svn commit: r1309705 - in /jackrabbit/oak/trunk/oak-core/src: main/java/org/apache/jackrabbit/oak/kernel/ test/java/org/apache/jackrabbit/oak/kernel/

2012-04-05 Thread mduerig
Author: mduerig Date: Thu Apr 5 09:06:15 2012 New Revision: 1309705 URL: http://svn.apache.org/viewvc?rev=1309705&view=rev Log: OAK-9: Internal tree builder property and node count tests fix: wrong property count if setting an existing property Modified: jackrabbit/oak/trunk/oak-core/src/ma

Re: svn commit: r1309458 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/kernel/KernelNodeState.java

2012-04-05 Thread Jukka Zitting
Hi, On Thu, Apr 5, 2012 at 10:48 AM, Thomas Mueller wrote: > I think the pattern "if nodeExists then getNodes" should be avoided also > because the node might have been deleted just after calling nodeExists, > depending on the underlying storage. Revisions are immutable, so this should never hap

Re: svn commit: r1309458 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/kernel/KernelNodeState.java

2012-04-05 Thread Thomas Mueller
Hi, >>That's what I was wondering, is a nodeExists() call followed by >> getNodes() better than a getNodes() call by itself? Especially if we >> assume potential network overhead for both calls... > >That pattern pops up all over again. We should probably not use >exceptions for signalling missing

Re: svn commit: r1309458 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/kernel/KernelNodeState.java

2012-04-05 Thread Jukka Zitting
Hi, On Thu, Apr 5, 2012 at 9:43 AM, Stefan Guggisberg wrote: > you're right, but in this particular case i replaced a dummy getNodes() call > in a try/catch block with a single nodeExists() call returning a boolean. > i'd argue that the code is cleaner and probably not slower ;) Right, I was con

Re: svn commit: r1309458 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/kernel/KernelNodeState.java

2012-04-05 Thread Michael Dürig
On 5.4.12 8:00, Jukka Zitting wrote: Hi, On Wed, Apr 4, 2012 at 5:36 PM, wrote: optimized getChildNode [...] if (child == null&& childNodeCount> MAX_CHILD_NODE_NAMES) { String childPath = getChildPath(name); -try { -kernel.getNodes(childPath

Re: svn commit: r1309458 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/kernel/KernelNodeState.java

2012-04-05 Thread Stefan Guggisberg
On Thu, Apr 5, 2012 at 9:00 AM, Jukka Zitting wrote: > Hi, > > On Wed, Apr 4, 2012 at 5:36 PM,   wrote: >> optimized getChildNode >> [...] >>         if (child == null && childNodeCount > MAX_CHILD_NODE_NAMES) { >>             String childPath = getChildPath(name); >> -            try { >> -      

Re: svn commit: r1309458 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/kernel/KernelNodeState.java

2012-04-05 Thread Jukka Zitting
Hi, On Wed, Apr 4, 2012 at 5:36 PM, wrote: > optimized getChildNode > [...] >         if (child == null && childNodeCount > MAX_CHILD_NODE_NAMES) { >             String childPath = getChildPath(name); > -            try { > -                kernel.getNodes(childPath, revision, 0, 0, 0, null); >