Re: svn commit: r1492561 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/ChangeProcessor.java

2013-06-13 Thread Jukka Zitting
Hi, On Thu, Jun 13, 2013 at 11:23 AM, mdue...@apache.org wrote: +private final String initStacktrace; A better approach might be to keep an Exception instance for this purpose. Logging tools are typically better prepared to handle and format a stack trace from an exception instance instead

Re: svn commit: r1492561 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/ChangeProcessor.java

2013-06-13 Thread Michael Dürig
On 13.6.13 9:35, Jukka Zitting wrote: A better approach might be to keep an Exception instance for this purpose. Logging tools are typically better prepared to handle and format a stack trace from an exception instance instead of a long multi-line string as the log message. I considered that

Re: svn commit: r1492561 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/ChangeProcessor.java

2013-06-13 Thread Jukka Zitting
Hi, On Thu, Jun 13, 2013 at 11:42 AM, Michael Dürig mdue...@apache.org wrote: I considered that but wanted to have the stack trace in the log message regardless of the logger message format configuration. OK. Note thought that this approach takes away the ability of logging frameworks to

Re: svn commit: r1492561 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/observation/ChangeProcessor.java

2013-06-13 Thread Michael Dürig
On 13.6.13 11:19, Jukka Zitting wrote: Hi, On Thu, Jun 13, 2013 at 1:13 PM, Michael Dürig mdue...@apache.org wrote: Right. I guess we need to weight not having the stack trace at all since the default logging configuration doesn't includes it against being able to include additional

buildbot failure in ASF Buildbot on oak-trunk

2013-06-13 Thread buildbot
The Buildbot has detected a new failure on builder oak-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/oak-trunk/builds/2665 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: osiris_ubuntu Build Reason: scheduler Build Source Stamp:

Re: buildbot failure in ASF Buildbot on oak-trunk

2013-06-13 Thread Michael Dürig
Forgot to add test case to the known.issues list in oak-jcr/pom.xml. Should be fixed at r1492748. Why are we mixing Junit3 and Junit4 style test cases anyway? Michael On 13.6.13 16:57, build...@apache.org wrote: The Buildbot has detected a new failure on builder oak-trunk while building