Re: Using DBCursor in MongoDocumentStore

2014-03-18 Thread Julian Reschke
On 2014-03-18 18:52, Chetan Mehrotra wrote: Hi, I was looking into the support for Version GC (OAK-1341). For that I had a look at BlobReferenceIterator#loadBatchQuery which currently does a pagination over all Documents which have binaries. The DBCursor returned by Mongo [1] implements the Iter

Using DBCursor in MongoDocumentStore

2014-03-18 Thread Chetan Mehrotra
Hi, I was looking into the support for Version GC (OAK-1341). For that I had a look at BlobReferenceIterator#loadBatchQuery which currently does a pagination over all Documents which have binaries. The DBCursor returned by Mongo [1] implements the Iterator contract and would lazily fetch the next

Re: svn commit: r1578943 - in /jackrabbit/oak/trunk/oak-core/src: main/java/org/apache/jackrabbit/oak/ main/java/org/apache/jackrabbit/oak/plugins/backup/ main/java/org/apache/jackrabbit/oak/plugins/b

2014-03-18 Thread Jukka Zitting
Hi, On Tue, Mar 18, 2014 at 11:16 AM, Chetan Mehrotra wrote: > I have updated the ~/.subversion/config file with those setting but I > use git-svn for my local development. Do I need to tweak any git > specific setting for EOL handling? No, git-svn will use the subversion settings. BR, Jukka Z

Re: svn commit: r1578943 - in /jackrabbit/oak/trunk/oak-core/src: main/java/org/apache/jackrabbit/oak/ main/java/org/apache/jackrabbit/oak/plugins/backup/ main/java/org/apache/jackrabbit/oak/plugins/b

2014-03-18 Thread Michael Dürig
On 18.3.14 4:08 , Jukka Zitting wrote: People who added these files, please check your eol-style settings: http://www.apache.org/dev/svn-eol-style.txt Sorry about that. These setting apparently got lost when I switched to my new computer. Should work now... given git-svn also takes these se

Re: svn commit: r1578943 - in /jackrabbit/oak/trunk/oak-core/src: main/java/org/apache/jackrabbit/oak/ main/java/org/apache/jackrabbit/oak/plugins/backup/ main/java/org/apache/jackrabbit/oak/plugins/b

2014-03-18 Thread Chetan Mehrotra
I have updated the ~/.subversion/config file with those setting but I use git-svn for my local development. Do I need to tweak any git specific setting for EOL handling? Currently my autocrlf = input in ~/.gitconfig Chetan Mehrotra On Tue, Mar 18, 2014 at 8:38 PM, Jukka Zitting wrote: > Hi, > >

Re: svn commit: r1578943 - in /jackrabbit/oak/trunk/oak-core/src: main/java/org/apache/jackrabbit/oak/ main/java/org/apache/jackrabbit/oak/plugins/backup/ main/java/org/apache/jackrabbit/oak/plugins/b

2014-03-18 Thread Jukka Zitting
Hi, On Tue, Mar 18, 2014 at 11:01 AM, wrote: > > jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/RepositoryManager.java >(props changed) > > jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/backup/FileStoreBackupRestore.java >(

Re: failing oak build

2014-03-18 Thread Chetan Mehrotra
Looking into it. Chetan Mehrotra On Tue, Mar 18, 2014 at 2:10 PM, Alex Parvulescu wrote: > Hi, > > The Oak build is failing > > Tests in error: > testEmptyIdentifier(org.apache.jackrabbit.oak.plugins.document.blob.ds.MongoDataStoreBlobStoreTest): > String index out of range: 2 > > The 0.19 relea

Re: svn commit: r1578423 - in /jackrabbit/oak/trunk/oak-core: ./ src/main/java/org/apache/jackrabbit/oak/plugins/document/rdb/

2014-03-18 Thread Julian Reschke
On 2014-03-18 09:39, Chetan Mehrotra wrote: It would be better if we make DataSource as part of Builder itself and remove all such logic from RDB. Or better for testing purpose or even But isn't Builder supposed to be persistence-agnostic? ... Best regards, Julian

failing oak build

2014-03-18 Thread Alex Parvulescu
Hi, The Oak build is failing Tests in error: testEmptyIdentifier(org.apache.jackrabbit.oak.plugins.document.blob.ds.MongoDataStoreBlobStoreTest): String index out of range: 2 The 0.19 release is really close, it is really important to get the build stable again. best, alex

Re: svn commit: r1578423 - in /jackrabbit/oak/trunk/oak-core: ./ src/main/java/org/apache/jackrabbit/oak/plugins/document/rdb/

2014-03-18 Thread Chetan Mehrotra
It would be better if we make DataSource as part of Builder itself and remove all such logic from RDB. Or better for testing purpose or even in normal case the RDBDocumentStore be instantiated outside and passed in Builder. Then main code would not have to worry about creating DataStource and hand