RepositorySidegrade and commit hooks

2016-08-18 Thread Chetan Mehrotra
Hi, Does RepositorySidegrade runs all the commit hooks required for getting a consistent JCR level state like permission editor, property editor etc I can such hooks configured for RepositoryUpgrade but not seeing any such hook configured for RepositorySidegrade Probably we should also

Re: Help with unit tests for JMX stats for S3DataStore

2016-08-18 Thread Chetan Mehrotra
Hi Matt, It would be easier if you can open an issue and provide your patch there so that one can have better understanding of what needs to be tested. In general we have you can use with MemoryDocumentStore (default used by DocumentMK builder) and then possibly use Sling OSGi mocks to pick the

Help with unit tests for JMX stats for S3DataStore

2016-08-18 Thread Matt Ryan
Hi, I’m working on a patch for Oak that would add some JMX stats for S3DataStore. I’m adding code to register a new Mbean in DocumentNodeStoreService (also SegmentNodeStoreService, but let’s just worry about the first one for now). I wanted to create some unit tests to verify that my new JMX

Re: backport OAK-4153 to 1.0/1.2/1.4

2016-08-18 Thread Vikas Saurabh
> are we OK to > backport this to all branches (1.0/1.2/1.4)? +1 for all branches mainly because side-effects arising out of OAK-4153 would be very hard to investigate/reason-about. On the same lines, keeping track of such difference in behavior across branch is hard. > Cheers, > Stefan > -- >