Re: [m12] Effort to Improve Modularisation of Oak

2017-04-13 Thread Matt Ryan
Great work so far to everyone involved in this effort. I'm under the impression that this refactoring will constitute a change in the public API contract of Oak. In reading the links it seems to hint at this but whether or not this will actually result in a public API change isn't explicitly call

BUILD FAILURE: Jackrabbit Oak - Build # 158 - Failure

2017-04-13 Thread Apache Jenkins Server
The Apache Jenkins build system has built Jackrabbit Oak (build #158) Status: Failure Check console output at https://builds.apache.org/job/Jackrabbit%20Oak/158/ to view the results. Changes: [angela] OAK-6078 : oak.util.ApproximateCounter must have private constructor [mreutegg] OAK-3342: mov

Re: [m12] Effort to Improve Modularisation of Oak

2017-04-13 Thread Angela Schreiber
Hi Michael and Oak-Devs Just a quick update: I added more details to OAK-6073 included a summary of the effects on oak-core and oak-commons as well as listing changes to non-test dependencies of most modules. I would like to encourage you to look at the fork and the summary and provide feedback i

Re: [m12] Effort to Improve Modularisation of Oak

2017-04-13 Thread Michael Dürig
I try to describe the changes proposed by the PoC in https://issues.apache.org/jira/browse/OAK-6073?focusedCommentId=15965623&pa ge=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment -15965623. Additionally added some step-by-step instruction on how we proceeded. Thanks,

Re: Module to host oak-run console scripts

2017-04-13 Thread Chetan Mehrotra
On Thu, Apr 13, 2017 at 3:29 PM, Robert Munteanu wrote: > Or we can even have a 'contrib' > area in the top-level oak directory and place the scripts there, i.e. > /contrib/scripts or /contrib/oak-run-scripts That looks like a viable option. I can keep them in a module my github account but then

Re: Module to host oak-run console scripts

2017-04-13 Thread Michael Dürig
Hi, On 13.04.17 11:33, Chetan Mehrotra wrote: Major benefit of scripts are they are faster to implement and can be used in older branches without impacting runtime. I agree on this part. But most of this benefit comes from not providing the same level of maintenance, testing, compatibility e

Re: Module to host oak-run console scripts

2017-04-13 Thread Robert Munteanu
On Thu, 2017-04-13 at 15:03 +0530, Chetan Mehrotra wrote: > On Thu, Apr 13, 2017 at 2:51 PM, Marcel Reutegger > wrote: > > one concern I have is maintainability. Scripts tend to go out of > > date and my > > question would be how we can detect this when it happens. > > Yes that would be the case.

Re: Module to host oak-run console scripts

2017-04-13 Thread Chetan Mehrotra
On Thu, Apr 13, 2017 at 2:51 PM, Marcel Reutegger wrote: > one concern I have is maintainability. Scripts tend to go out of date and my > question would be how we can detect this when it happens. Yes that would be the case. The scripts come with lesser testing and can go stale > I'm wondering wh

Re: Module to host oak-run console scripts

2017-04-13 Thread Marcel Reutegger
Hi, one concern I have is maintainability. Scripts tend to go out of date and my question would be how we can detect this when it happens. As for the example with the index consistency check you mentioned, I'm wondering why this is implemented as a script instead of plain Java. I'd say if we

Re: Module to host oak-run console scripts

2017-04-13 Thread Chetan Mehrotra
See OAK-6075 for an example for such a script Chetan Mehrotra On Thu, Apr 13, 2017 at 10:35 AM, Chetan Mehrotra wrote: > Hi Team, > > We have few oak-run console groovy scripts used often to > analyze/troubleshoot customer setups. Currently these are scattered > across various github gist. > > I