Re: [PR] OAK-10843 : exclude a flaky test combination [jackrabbit-oak]

2024-07-04 Thread via GitHub
stefan-egli merged PR #1568: URL: https://github.com/apache/jackrabbit-oak/pull/1568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...

Re: [PR] OAK-10933 : skip timestamp calculation if fullgc is not enabled [jackrabbit-oak]

2024-07-04 Thread via GitHub
stefan-egli commented on PR #1570: URL: https://github.com/apache/jackrabbit-oak/pull/1570#issuecomment-2208485300 tests look "good" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-07-04 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user stefan-egli (triggered by stefan-egli). Head commit for run: 646ec9a634cc3ce304b21748a7087f5c3983b5c4 / stefan-egli OAK-10843 : exclude a flaky test combination Report URL: https://github.com/apach

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-07-04 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user stefan-egli (triggered by stefan-egli). Head commit for run: 4a4b30fef27e3ca7d46fb8d1de019d44afe2161e / stefan-egli OAK-10843 : exclude a flaky test combination (#1568) * OAK-10843 : exclude a flak

Re: [PR] OAK-10921 : fixed race condition where fullGC database variables gets… [jackrabbit-oak]

2024-07-04 Thread via GitHub
rishabhdaim commented on code in PR #1562: URL: https://github.com/apache/jackrabbit-oak/pull/1562#discussion_r1665468708 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollectorIT.java: ## @@ -191,7 +190,7 @@ public GCCounts(FullGCM

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-07-04 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user rishabhdaim (triggered by rishabhdaim). Head commit for run: 7c88a1617220f63637336a4a198f249f498d9a5d / Rishabh Kumar OAK-10921 : added unit case for resetFullGC & resetGC both Report URL: https://

Re: [PR] OAK-10933 : skip timestamp calculation if fullgc is not enabled [jackrabbit-oak]

2024-07-04 Thread via GitHub
rishabhdaim commented on PR #1570: URL: https://github.com/apache/jackrabbit-oak/pull/1570#issuecomment-2208614324 IMO, this is an incomplete fix. We need to add `fullGCEnabled` check before `isFullGCDryRun` at https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/

Re: [PR] OAK-10933 : skip timestamp calculation if fullgc is not enabled [jackrabbit-oak]

2024-07-04 Thread via GitHub
rishabhdaim commented on code in PR #1570: URL: https://github.com/apache/jackrabbit-oak/pull/1570#discussion_r1665485930 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGCRecommendations.java: ## @@ -170,7 +170,7 @@ public class VersionGCRe

Re: [PR] OAK-10933 : skip timestamp calculation if fullgc is not enabled [jackrabbit-oak]

2024-07-04 Thread via GitHub
stefan-egli commented on code in PR #1570: URL: https://github.com/apache/jackrabbit-oak/pull/1570#discussion_r1665537149 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGCRecommendations.java: ## @@ -170,7 +170,7 @@ public class VersionGCRe

Re: [PR] OAK-10933 : skip timestamp calculation if fullgc is not enabled [jackrabbit-oak]

2024-07-04 Thread via GitHub
stefan-egli commented on PR #1570: URL: https://github.com/apache/jackrabbit-oak/pull/1570#issuecomment-2208700186 agree this is incomplete - it is merely a first fix for the most noisy logger. we likely will have to exclude more - but that shouldn't prevent this one from going through. -

Re: [PR] OAK-10933 : skip timestamp calculation if fullgc is not enabled [jackrabbit-oak]

2024-07-04 Thread via GitHub
stefan-egli merged PR #1570: URL: https://github.com/apache/jackrabbit-oak/pull/1570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-07-04 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user rishabhdaim (triggered by rishabhdaim). Head commit for run: 34554df5b98242f30f1228ce2089bef87b0a0816 / Rishabh Kumar OAK-10921 : undo the scope change for FullGcMode Report URL: https://github.com

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-07-04 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user stefan-egli (triggered by stefan-egli). Head commit for run: 0777573384e8d6504ab06eda073d0805a4e8a53a / stefan-egli OAK-10933 : also avoid for dryRUn : skip timestamp calculation if fullgc is not e

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-07-04 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user rishabhdaim (triggered by rishabhdaim). Head commit for run: 7c6642b20807d2ff4e7a021959bca1c98d86b79b / Rishabh Kumar OAK-10921 : undo the scope change for FullGcMode Report URL: https://github.com

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-07-04 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user rishabhdaim (triggered by rishabhdaim). Head commit for run: fbac01bcbd5aba18d2f478983009b8b629fbe916 / Rishabh Kumar OAK-10921 : removed un-necessary import Report URL: https://github.com/apache/j

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-07-04 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user rishabhdaim (triggered by rishabhdaim). Head commit for run: 7c88a1617220f63637336a4a198f249f498d9a5d / Rishabh Kumar OAK-10921 : added unit case for resetFullGC & resetGC both Report URL: https://

Re: [PR] OAK-10921 : fixed race condition where fullGC database variables gets… [jackrabbit-oak]

2024-07-04 Thread via GitHub
stefan-egli commented on code in PR #1562: URL: https://github.com/apache/jackrabbit-oak/pull/1562#discussion_r1665651871 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollectorIT.java: ## @@ -1478,6 +1477,77 @@ private Iterator can

[PR] OAK-10921 : combine two test variants using a common method [jackrabbit-oak]

2024-07-04 Thread via GitHub
stefan-egli opened a new pull request, #1572: URL: https://github.com/apache/jackrabbit-oak/pull/1572 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-07-04 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user stefan-egli (triggered by stefan-egli). Head commit for run: 807ce7dc9ab4bd7e3c5e56f14c741efa5db6d057 / stefan-egli OAK-10921 : combine two test variants using a common method Report URL: https://g

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-07-04 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user stefan-egli (triggered by stefan-egli). Head commit for run: a1d02337c5afb83f8eb0b3693d0ca5cc89bf6d78 / stefan-egli OAK-10933 : skip timestamp calculation if fullgc is not enabled (#1570) Report UR

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-07-04 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user rishabhdaim (triggered by rishabhdaim). Head commit for run: 0c80fd9311430702dd629154000c284afa4e5a07 / Rishabh Kumar OAK-10921 : extracted out common code Report URL: https://github.com/apache/jac

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

2024-07-04 Thread GitBox
The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed. Run started by GitHub user rishabhdaim (triggered by rishabhdaim). Head commit for run: 9f6680ce20051564efe8338fb3be4272626b90d3 / Rishabh Kumar OAK-10921 : extracted out common code Report URL: https://github.com/apache/jac