[jira] [Commented] (OAK-48) MicroKernel.getNodes() should return null for not existing nodes instead of throwing an exception

2012-04-13 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253827#comment-13253827 ] Jukka Zitting commented on OAK-48: -- Adjusted the wrapper layer and fixed the failing integrat

[jira] [Commented] (OAK-65) Naming of NodeState and related classes

2012-04-13 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253735#comment-13253735 ] Jukka Zitting commented on OAK-65: -- I'm not too tied to the naming, and as mentioned, the {{.

[jira] [Commented] (OAK-65) Naming of NodeState and related classes

2012-04-13 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253514#comment-13253514 ] Jukka Zitting commented on OAK-65: -- We discussed naming as a part of the [earlier thread|htt

[jira] [Commented] (OAK-56) File system abstraction

2012-04-10 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250717#comment-13250717 ] Jukka Zitting commented on OAK-56: -- I guess this should be better approached from the top ins

[jira] [Commented] (OAK-56) File system abstraction

2012-04-10 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250680#comment-13250680 ] Jukka Zitting commented on OAK-56: -- Agreed with Stefan. Components above the MK should ideall

[jira] [Commented] (OAK-48) MicroKernel.getNodes() should return null for not existing nodes instead of throwing an exception

2012-04-05 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247204#comment-13247204 ] Jukka Zitting commented on OAK-48: -- +1 for null return value. As seen in KernelNodeState, es

[jira] [Commented] (OAK-34) Define query API

2012-04-03 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245263#comment-13245263 ] Jukka Zitting commented on OAK-34: -- Great stuff, thanks for pushing ahead on this! Comments:

[jira] [Commented] (OAK-6) Setup integration tests and TCK tests

2012-03-29 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241333#comment-13241333 ] Jukka Zitting commented on OAK-6: - I added a basic JCR TCK setup to oak-it/jcr in revision 1306

[jira] [Commented] (OAK-4) Runnable jar packaging

2012-03-23 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236811#comment-13236811 ] Jukka Zitting commented on OAK-4: - As of revision 1304475 there's now a basic Jetty-based runna

[jira] [Commented] (OAK-36) Implement a query parser

2012-03-21 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-36?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234833#comment-13234833 ] Jukka Zitting commented on OAK-36: -- Instead of just a query parser for the set of supported l

[jira] [Commented] (OAK-33) Values in oak-core

2012-03-21 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234805#comment-13234805 ] Jukka Zitting commented on OAK-33: -- In revision 1303477 I dropped the {{getDecimal()}} method

[jira] [Commented] (OAK-28) Query implementation

2012-03-21 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234551#comment-13234551 ] Jukka Zitting commented on OAK-28: -- bq. ... limit and offset ... Either add those as explici

[jira] [Commented] (OAK-33) Values in oak-core

2012-03-21 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234365#comment-13234365 ] Jukka Zitting commented on OAK-33: -- I committed a draft of such a Scalar interface in revisio

[jira] [Commented] (OAK-33) Values in oak-core

2012-03-21 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234351#comment-13234351 ] Jukka Zitting commented on OAK-33: -- bq. multi-valued properties As the name says, I think we

[jira] [Commented] (OAK-33) Values in oak-core

2012-03-21 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234292#comment-13234292 ] Jukka Zitting commented on OAK-33: -- bq. performance implications A type-specific implementat

[jira] [Commented] (OAK-33) Values in oak-core

2012-03-21 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234273#comment-13234273 ] Jukka Zitting commented on OAK-33: -- +1 for (C) Some comments: * We should use some other na

[jira] [Commented] (OAK-30) Strongly typed wrapper for the MicroKernel

2012-03-20 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233541#comment-13233541 ] Jukka Zitting commented on OAK-30: -- bq. ... starting with regular Java Maps ... See the earl

[jira] [Commented] (OAK-30) Strongly typed wrapper for the MicroKernel

2012-03-20 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233537#comment-13233537 ] Jukka Zitting commented on OAK-30: -- I committed an initial draft of this to o.a.j.oak.kernel

[jira] [Commented] (OAK-18) Define Oak API

2012-03-16 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231225#comment-13231225 ] Jukka Zitting commented on OAK-18: -- I added the o.a.j.oak.api package for this in revision 13

[jira] [Commented] (OAK-5) JCR bindings for Oak

2012-03-14 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229112#comment-13229112 ] Jukka Zitting commented on OAK-5: - Looks like we have rough consensus to put this into a separa

[jira] [Commented] (OAK-8) Make return types of NodeState#getProperties() and NodeState#getChildNodeEntries() covariant

2012-03-11 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13227073#comment-13227073 ] Jukka Zitting commented on OAK-8: - +1 didn't think of that > Make return types

[jira] [Commented] (OAK-3) Internal tree model

2012-03-08 Thread Jukka Zitting (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225153#comment-13225153 ] Jukka Zitting commented on OAK-3: - Committed the patch in revision 1298366, and removed some no