Re: [PR] OAK-10748: Improve statistics to collect which type of garbage is sent/deleted [jackrabbit-oak]

2024-07-02 Thread via GitHub
stefan-egli commented on code in PR #1543: URL: https://github.com/apache/jackrabbit-oak/pull/1543#discussion_r1654745087 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/FullGCStatsCollector.java: ## @@ -31,6 +32,34 @@ public interface

Re: [PR] OAK-10748: Improve statistics to collect which type of garbage is sent/deleted [jackrabbit-oak]

2024-06-24 Thread via GitHub
Joscorbe commented on PR #1543: URL: https://github.com/apache/jackrabbit-oak/pull/1543#issuecomment-2186350396 I will squash this PR into a single commit once approved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] OAK-10748: Improve statistics to collect which type of garbage is sent/deleted [jackrabbit-oak]

2024-06-24 Thread via GitHub
Joscorbe commented on code in PR #1543: URL: https://github.com/apache/jackrabbit-oak/pull/1543#discussion_r1650867475 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java: ## @@ -240,7 +240,21 @@ static FullGCMode

Re: [PR] OAK-10748: Improve statistics to collect which type of garbage is sent/deleted [jackrabbit-oak]

2024-06-24 Thread via GitHub
Joscorbe commented on PR #1543: URL: https://github.com/apache/jackrabbit-oak/pull/1543#issuecomment-2186329449 > actually, there are compilation errors: > > ``` > [INFO] - > Error: COMPILATION ERROR : > [INFO]

Re: [PR] OAK-10748: Improve statistics to collect which type of garbage is sent/deleted [jackrabbit-oak]

2024-06-24 Thread via GitHub
Joscorbe commented on code in PR #1543: URL: https://github.com/apache/jackrabbit-oak/pull/1543#discussion_r1650854809 ## oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java: ## @@ -535,8 +544,8 @@ private void collectDocument(RevisionsOptions options,

Re: [PR] OAK-10748: Improve statistics to collect which type of garbage is sent/deleted [jackrabbit-oak]

2024-06-24 Thread via GitHub
stefan-egli commented on PR #1543: URL: https://github.com/apache/jackrabbit-oak/pull/1543#issuecomment-2186287106 actually, there are compilation errors: ``` [INFO] - Error: COMPILATION ERROR : [INFO]

Re: [PR] OAK-10748: Improve statistics to collect which type of garbage is sent/deleted [jackrabbit-oak]

2024-06-24 Thread via GitHub
stefan-egli commented on code in PR #1543: URL: https://github.com/apache/jackrabbit-oak/pull/1543#discussion_r1650820289 ## oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java: ## @@ -535,8 +544,8 @@ private void collectDocument(RevisionsOptions options,