Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-24 Thread via GitHub
t-rana commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650371659 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/fixture/DataStoreUtils.java: ## @@ -146,26 +150,52 @@ public static void deleteBucket(String bucket,

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
t-rana commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650374514 ## oak-run-commons/src/test/java/org/apache/jackrabbit/oak/fixture/DataStoreUtilsTest.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
t-rana commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650374514 ## oak-run-commons/src/test/java/org/apache/jackrabbit/oak/fixture/DataStoreUtilsTest.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
t-rana commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650372569 ## oak-run-commons/src/test/java/org/apache/jackrabbit/oak/fixture/DataStoreUtilsTest.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
t-rana commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650372442 ## oak-run-commons/src/test/java/org/apache/jackrabbit/oak/fixture/DataStoreUtilsTest.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
t-rana commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650372015 ## oak-run-commons/src/test/java/org/apache/jackrabbit/oak/fixture/DataStoreUtilsTest.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
t-rana commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650371659 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/fixture/DataStoreUtils.java: ## @@ -146,26 +150,52 @@ public static void deleteBucket(String bucket,

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
t-rana commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650371492 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/fixture/DataStoreUtils.java: ## @@ -146,26 +150,52 @@ public static void deleteBucket(String bucket,

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
nit0906 commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650350025 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/fixture/DataStoreUtils.java: ## @@ -146,26 +150,52 @@ public static void deleteBucket(String bucket,

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
nit0906 commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650348764 ## oak-run-commons/src/test/java/org/apache/jackrabbit/oak/fixture/DataStoreUtilsTest.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
nit0906 commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650348034 ## oak-run-commons/src/test/java/org/apache/jackrabbit/oak/fixture/DataStoreUtilsTest.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
nit0906 commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650346400 ## oak-run-commons/src/test/java/org/apache/jackrabbit/oak/fixture/DataStoreUtilsTest.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
nit0906 commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650340220 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/fixture/DataStoreUtils.java: ## @@ -146,26 +150,52 @@ public static void deleteBucket(String bucket,

Re: [PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-23 Thread via GitHub
nit0906 commented on code in PR #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542#discussion_r1650340383 ## oak-run-commons/src/main/java/org/apache/jackrabbit/oak/fixture/DataStoreUtils.java: ## @@ -146,26 +150,52 @@ public static void deleteBucket(String bucket,

[PR] add service principal support while deleting container in oak-run-commons [jackrabbit-oak]

2024-06-18 Thread via GitHub
t-rana opened a new pull request, #1542: URL: https://github.com/apache/jackrabbit-oak/pull/1542 …mons -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,