[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269905#comment-13269905
]
Jukka Zitting commented on OAK-89:
--
-1 to {{extends RuntimeException}}
In cases where we nee
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269918#comment-13269918
]
Julian Reschke commented on OAK-89:
---
When I proposed this I was under the assumption that th
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269994#comment-13269994
]
Michael Dürig commented on OAK-89:
--
What do you do when you need to implement {{Iterable}} an
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270024#comment-13270024
]
Michael Dürig commented on OAK-89:
--
bq. Do we have a particular case where the first two alte
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270308#comment-13270308
]
Jukka Zitting commented on OAK-89:
--
bq. I would make OakException which extends from RuntimeE
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270312#comment-13270312
]
Thomas Mueller commented on OAK-89:
---
Yes, it makes sense to wait until we have real cases.
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270346#comment-13270346
]
Michael Dürig commented on OAK-89:
--
Thinking a bit more about this, I'm fine with using check
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270401#comment-13270401
]
Michael Dürig commented on OAK-89:
--
The attached patch exemplifies what I meant with my last
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270454#comment-13270454
]
Jukka Zitting commented on OAK-89:
--
In the patch I see two places where the {{NoSuchNameExcep
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270550#comment-13270550
]
Michael Dürig commented on OAK-89:
--
Why {{AbstractNameMapper.getJcrName()}} should throw a
{
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270581#comment-13270581
]
Jukka Zitting commented on OAK-89:
--
bq. Why {{AbstractNameMapper.getJcrName()}} should throw
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271223#comment-13271223
]
Michael Dürig commented on OAK-89:
--
bq. Here's how I'd define the error-handling for the Name
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271266#comment-13271266
]
Michael Dürig commented on OAK-89:
--
bq. The trouble with this approach is that the NameMapper
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271272#comment-13271272
]
Michael Dürig commented on OAK-89:
--
Btw. when using {{null}} return values: what about revivi
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271321#comment-13271321
]
Julian Reschke commented on OAK-89:
---
bq. Sounds like a good idea to me.
I'll try the latest
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271390#comment-13271390
]
Michael Dürig commented on OAK-89:
--
bq. Constructing an exception can be time-consuming,...
[
https://issues.apache.org/jira/browse/OAK-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271408#comment-13271408
]
Jukka Zitting commented on OAK-89:
--
OK. I went ahead and dcommitted all these changes in revi
17 matches
Mail list logo
