Re: AbstractNodeState strange loop

2013-02-19 Thread Jukka Zitting
Hi, On Tue, Feb 19, 2013 at 3:17 PM, Alex Parvulescu wrote: > I came across this funny looking bit in the AbstractNodeState class [0]: Yeah, that's actually intentional... My goal for ANS was to make it as easy as possible to write new draft NodeState implementations without worrying about havin

Re: AbstractNodeState strange loop

2013-02-19 Thread Alex Parvulescu
I see. > Dropping one of the default implementations will force all subclasses to implement that method, even if they'd have an easier time implementing just the other one. Dropping the one that I suggested (#getChildNodeEntries) has a really low footprint as all subclasses have already implement

Re: AbstractNodeState strange loop

2013-02-19 Thread Jukka Zitting
Hi, On Tue, Feb 19, 2013 at 5:18 PM, Alex Parvulescu wrote: > Dropping the one that I suggested (#getChildNodeEntries) has a really low > footprint as all subclasses have already implemented it. > Future NodeState implementations that extend from ANS need to be aware of > this tiny gem in the cod

Re: AbstractNodeState strange loop

2013-02-19 Thread Alex Parvulescu
hi, > I don't believe we'll be seeing too many new NodeState implementations anymore. I could have said the same thing a few weeks ago, but then the segmentmk was born :) I'll followup with an issue to drop the getChildNodeEntries method - that seems easiest. thanks, alex On Tue, Feb 19, 2013