Add the #setHook method to the NodeStore?

2013-02-14 Thread Alex Parvulescu
hi guys, I'm wondering if we could promote the #setHook method to the NodeStore api? CommitHooks are an important part of Oak and all the existing implementations have one anyway. thanks, alex

Re: Add the #setHook method to the NodeStore?

2013-02-14 Thread Jukka Zitting
Hi, On Thu, Feb 14, 2013 at 1:13 PM, Alex Parvulescu wrote: > I'm wondering if we could promote the #setHook method to the NodeStore api? The intention so far has been to keep NodeStore functionally equivalent to the MicroKernel, i.e. just a higher-level wrapper that hides details like caching,

Re: Add the #setHook method to the NodeStore?

2013-02-14 Thread Angela Schreiber
hi I'm wondering if we could promote the #setHook method to the NodeStore api? The intention so far has been to keep NodeStore functionally equivalent to the MicroKernel, i.e. just a higher-level wrapper that hides details like caching, JSOP processing and revision/path tracking. Adding commit

Re: Add the #setHook method to the NodeStore?

2013-02-14 Thread Angela Schreiber
see https://issues.apache.org/jira/browse/OAK-627 On 2/14/13 6:38 PM, Angela Schreiber wrote: hi I'm wondering if we could promote the #setHook method to the NodeStore api? The intention so far has been to keep NodeStore functionally equivalent to the MicroKernel, i.e. just a higher-level wr

Re: Add the #setHook method to the NodeStore?

2013-02-15 Thread Jukka Zitting
Hi, On Thu, Feb 14, 2013 at 7:38 PM, Angela Schreiber wrote: > that would also simplify things for having separate commit hook > instances depending on the 'nature' of the root... for example > creating hooks that know about the modified workspace (see OAK-625, > which currently seems to get a bi

Re: Add the #setHook method to the NodeStore?

2013-02-15 Thread Angela Schreiber
hi jukka now that you have committed an initial patch for OAK-627 (thanks) i will check if there wasn't a smarter solution for OAK-625... update will follow in the issue. gruss angela On 2/15/13 1:48 PM, Jukka Zitting wrote: Hi, On Thu, Feb 14, 2013 at 7:38 PM, Angela Schreiber wrote: that