Time for jackrabbit-jcr-auth?

2013-02-19 Thread Jukka Zitting
Hi, When looking at the login() code for OAK-634 I realized that there's a a lot of duplication between jackrabbit-core and oak-core in this area. Would it make sense to split out the authentication code to something like jackrabbit-jcr-auth that could be used by both jackrabbit-core and

Re: Time for jackrabbit-jcr-auth?

2013-02-19 Thread Felix Meschberger
Hi Can you separate API from implementation in the same step ? Currently API and implementation is nicely mixed, which makes it close to impossible to properly use in an OSGi context. Regards Felix Am 19.02.2013 um 10:52 schrieb Jukka Zitting: Hi, When looking at the login() code for

Re: Time for jackrabbit-jcr-auth?

2013-02-19 Thread Jukka Zitting
Hi, On Tue, Feb 19, 2013 at 12:02 PM, Felix Meschberger fmesc...@adobe.com wrote: Can you separate API from implementation in the same step ? The way I see it, the APIs used by such a component should ultimately be just JAAS and JCR. BR, Jukka Zitting

Re: Time for jackrabbit-jcr-auth?

2013-02-19 Thread Angela Schreiber
hi jukka honestly, i fail to see the duplication apart from the fact the there is a certain structure and flow of control given by the java LoginModule base class. the authentication in jackrabbit core was heavily depending on jackrabbit core internals while the rewrite in oak doesn't make use