Opened OAK-4640 to track this
Chetan Mehrotra
On Wed, Aug 3, 2016 at 9:36 PM, Michael Dürig wrote:
>
>
> On 3.8.16 5:58 , Chetan Mehrotra wrote:
>>
>> On Wed, Aug 3, 2016 at 8:57 PM, Michael Dürig wrote:
>>>
>>> I would suggest to add an new, internal mechanism to CommitInfo for your
>>> purpos
On 3.8.16 5:58 , Chetan Mehrotra wrote:
On Wed, Aug 3, 2016 at 8:57 PM, Michael Dürig wrote:
I would suggest to add an new, internal mechanism to CommitInfo for your
purpose.
So introduce a new CommitAttributes instance which would be returned
by CommitInfo ... ?
Probably the best of all
On Wed, Aug 3, 2016 at 8:57 PM, Michael Dürig wrote:
> I would suggest to add an new, internal mechanism to CommitInfo for your
> purpose.
So introduce a new CommitAttributes instance which would be returned
by CommitInfo ... ?
Chetan Mehrotra
So maybe we need some additional means to survey this context then. If
you look at https://issues.apache.org/jira/browse/OAK-1438 where the
commit info map was introduced and at the usages of the same, it is
evident that this map belongs to the client (i.e. caller). Modifying it
midway throug
That would depend on the CommitHook impl which client code would not
be aware of. And commit hook would also know only as commit traversal
is done. So it needs to be some mutable state
Chetan Mehrotra
On Wed, Aug 3, 2016 at 8:27 PM, Michael Dürig wrote:
>
> Couldn't we keep the map immutable and
Couldn't we keep the map immutable and instead add some
"WhateverCollector" instances as values? E.g. add a
AffectedNodeTypeCollector right from the beginning?
Michael
On 3.8.16 4:06 , Chetan Mehrotra wrote:
So would it be ok to make the map within CommitInfo mutable ?
Chetan Mehrotra
On
So would it be ok to make the map within CommitInfo mutable ?
Chetan Mehrotra
On Wed, Aug 3, 2016 at 7:29 PM, Michael Dürig wrote:
>
>>
>> #A -Probably we can introduce a new type CommitAttributes which can be
>> attached to CommitInfo and which can be modified by the CommitHooks.
>> The CommitA
#A -Probably we can introduce a new type CommitAttributes which can be
attached to CommitInfo and which can be modified by the CommitHooks.
The CommitAttributes can then later be accessed by Observer
This is already present via the CommitInfo.info map. It is even used in
a similar way. See C
Hi Team,
Currently as part of commit the caller can provide a CommitInfo
instance which captures some metadata related to commit being
performed. Note that CommitInfo instance passed to NodeStore is
immutable.
For some usecases we need a way to add some more metadata to on going
commit from withi
