[jira] [Commented] (OAK-740) Malformed solr delete query

2013-04-03 Thread Tommaso Teofili (JIRA)
[ https://issues.apache.org/jira/browse/OAK-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621850#comment-13621850 ] Tommaso Teofili commented on OAK-740: - the wrong part is the not escaped slash, it should

[jira] [Comment Edited] (OAK-740) Malformed solr delete query

2013-04-03 Thread Tommaso Teofili (JIRA)
[ https://issues.apache.org/jira/browse/OAK-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621850#comment-13621850 ] Tommaso Teofili edited comment on OAK-740 at 4/4/13 6:25 AM: - the

[jira] [Resolved] (OAK-744) Invalid base node states in TreeImpl after commit/refresh/rebase

2013-04-03 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Dürig resolved OAK-744. --- Resolution: Fixed Fix Version/s: 0.7 Fixed at revision 1464088 > Invalid base no

[jira] [Commented] (OAK-744) Invalid base node states in TreeImpl after commit/refresh/rebase

2013-04-03 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621021#comment-13621021 ] Michael Dürig commented on OAK-744: --- Revision 1464088 removes the {{baseState}} field entir

[jira] [Created] (OAK-744) Invalid base node states in TreeImpl after commit/refresh/rebase

2013-04-03 Thread JIRA
Michael Dürig created OAK-744: - Summary: Invalid base node states in TreeImpl after commit/refresh/rebase Key: OAK-744 URL: https://issues.apache.org/jira/browse/OAK-744 Project: Jackrabbit Oak

[jira] [Updated] (OAK-709) Consider moving permission evaluation to the node state level

2013-04-03 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/OAK-709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting updated OAK-709: -- Attachment: SecureNodeState.java See the attached {{SecureNodeState}} class for a quick draft of how I'd s

[jira] [Commented] (OAK-734) Refactor indexing code to use Editors

2013-04-03 Thread Alex Parvulescu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620998#comment-13620998 ] Alex Parvulescu commented on OAK-734: - I got it. It's the _CountingNodeVisitor_ which acc

[jira] [Commented] (OAK-736) Enhancement to the PermissionProviderImpl constructor

2013-04-03 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620991#comment-13620991 ] angela commented on OAK-736: what's the benefit of having two constructors here? apart from tests

[jira] [Updated] (OAK-734) Refactor indexing code to use Editors

2013-04-03 Thread Alex Parvulescu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Parvulescu updated OAK-734: Attachment: OAK-734-p2.patch Attaching part 2, removing the insert/delete sets. Look at 'Property2Ind

[jira] [Commented] (OAK-734) Refactor indexing code to use Editors

2013-04-03 Thread Alex Parvulescu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620983#comment-13620983 ] Alex Parvulescu commented on OAK-734: - I took one test that seemed longer and the first c

[jira] [Commented] (OAK-734) Refactor indexing code to use Editors

2013-04-03 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/OAK-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620975#comment-13620975 ] Jukka Zitting commented on OAK-734: --- bq. apparently there's a price for the direct updates

[jira] [Commented] (OAK-709) Consider moving permission evaluation to the node state level

2013-04-03 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620970#comment-13620970 ] angela commented on OAK-709: as stated on the list i like the idea of having the access check on

[jira] [Commented] (OAK-734) Refactor indexing code to use Editors

2013-04-03 Thread Alex Parvulescu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620968#comment-13620968 ] Alex Parvulescu commented on OAK-734: - pushed initial version of the patch with rev 14640

[jira] [Commented] (OAK-743) Increase default RootImpl.PURGE_LIMIT

2013-04-03 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620960#comment-13620960 ] Marcel Reutegger commented on OAK-743: -- We already have the feature flag :)

[jira] [Commented] (OAK-675) Observation generates NPE in an existing EventListener

2013-04-03 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620956#comment-13620956 ] Michael Dürig commented on OAK-675: --- With the current design there is no reliable way to as

[jira] [Commented] (OAK-742) Oak#createContentSession() should be moved to some Test class

2013-04-03 Thread Antonio Sanso (JIRA)
[ https://issues.apache.org/jira/browse/OAK-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620952#comment-13620952 ] Antonio Sanso commented on OAK-742: --- For what I can see this method is only used from the t

[jira] [Commented] (OAK-743) Increase default RootImpl.PURGE_LIMIT

2013-04-03 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620949#comment-13620949 ] Michael Dürig commented on OAK-743: --- +1 for increasing that value. However, let's introduce

[jira] [Created] (OAK-743) Increase default RootImpl.PURGE_LIMIT

2013-04-03 Thread Marcel Reutegger (JIRA)
Marcel Reutegger created OAK-743: Summary: Increase default RootImpl.PURGE_LIMIT Key: OAK-743 URL: https://issues.apache.org/jira/browse/OAK-743 Project: Jackrabbit Oak Issue Type: Improvemen

[jira] [Commented] (OAK-742) Oak#createContentSession() should be moved to some Test class

2013-04-03 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/OAK-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620943#comment-13620943 ] Jukka Zitting commented on OAK-742: --- > to avoid any misusage What kind of misuse were you

[jira] [Resolved] (OAK-640) Add WorkspaceInitializer

2013-04-03 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-640. Resolution: Fixed resolving issue. > Add WorkspaceInitializer > > >

[jira] [Created] (OAK-742) Oak#createContentSession() should be moved to some Test class

2013-04-03 Thread Antonio Sanso (JIRA)
Antonio Sanso created OAK-742: - Summary: Oak#createContentSession() should be moved to some Test class Key: OAK-742 URL: https://issues.apache.org/jira/browse/OAK-742 Project: Jackrabbit Oak Iss

[jira] [Created] (OAK-741) Better toString() methods

2013-04-03 Thread Jukka Zitting (JIRA)
Jukka Zitting created OAK-741: - Summary: Better toString() methods Key: OAK-741 URL: https://issues.apache.org/jira/browse/OAK-741 Project: Jackrabbit Oak Issue Type: Improvement Compon

[jira] [Resolved] (OAK-703) Drop SessionImport#checkPermission

2013-04-03 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-703. Resolution: Fixed Committed revision 1464026. > Drop SessionImport#checkPermission >

[jira] [Commented] (OAK-706) Make workspace name available with the permission provider

2013-04-03 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620929#comment-13620929 ] angela commented on OAK-706: recently added a workaround by adding a utility method to ImmutableR

[jira] [Commented] (OAK-734) Refactor indexing code to use Editors

2013-04-03 Thread Alex Parvulescu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620924#comment-13620924 ] Alex Parvulescu commented on OAK-734: - no worries, I've created OAK-740 to track the erro

[jira] [Created] (OAK-740) Malformed solr delete query

2013-04-03 Thread Alex Parvulescu (JIRA)
Alex Parvulescu created OAK-740: --- Summary: Malformed solr delete query Key: OAK-740 URL: https://issues.apache.org/jira/browse/OAK-740 Project: Jackrabbit Oak Issue Type: Bug Componen

[jira] [Resolved] (OAK-426) OAK-API: Deal with names and relativePaths consisting/containing "." and ".."

2013-04-03 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Dürig resolved OAK-426. --- Resolution: Won't Fix Fix Version/s: 0.7 This is superseded by OAK-732 now. > OA

[jira] [Resolved] (OAK-732) Change TreeLocation.getChild() to only accept direct child nodes (not relative paths)

2013-04-03 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Dürig resolved OAK-732. --- Resolution: Fixed Fix Version/s: 0.7 Assignee: Michael Dürig Fixed at revision 1463984

[jira] [Commented] (OAK-734) Refactor indexing code to use Editors

2013-04-03 Thread Tommaso Teofili (JIRA)
[ https://issues.apache.org/jira/browse/OAK-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620902#comment-13620902 ] Tommaso Teofili commented on OAK-734: - thanks Alex for digging into it, I think you're ri

[jira] [Commented] (OAK-734) Refactor indexing code to use Editors

2013-04-03 Thread Alex Parvulescu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620893#comment-13620893 ] Alex Parvulescu commented on OAK-734: - I dug deeper into the solr error. It appears that

[jira] [Commented] (OAK-739) Asymmetric equals() implementation in AccessControlManagerImpl's nested classes PrincipalACL / NodeACL

2013-04-03 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620891#comment-13620891 ] Michael Dürig commented on OAK-739: --- Same problem with {{RestrictionDefinitionImpl}} and {{

[jira] [Resolved] (OAK-509) Item names starting with '{X}' cause RepositoryException

2013-04-03 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Dürig resolved OAK-509. --- Resolution: Fixed Fix Version/s: 0.7 Fixed at revision 1463964. I added additional test coverage

[jira] [Updated] (OAK-739) Asymmetric equals() implementation in AccessControlManagerImpl's nested classes PrincipalACL / NodeACL

2013-04-03 Thread Lukas Eder (JIRA)
[ https://issues.apache.org/jira/browse/OAK-739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lukas Eder updated OAK-739: --- Description: I was digging in the Oak code and I've stumbled upon an assymetric equals() implementation between

[jira] [Created] (OAK-739) Asymmetric equals() implementation in AccessControlManagerImpl's nested classes PrincipalACL / NodeACL

2013-04-03 Thread Lukas Eder (JIRA)
Lukas Eder created OAK-739: -- Summary: Asymmetric equals() implementation in AccessControlManagerImpl's nested classes PrincipalACL / NodeACL Key: OAK-739 URL: https://issues.apache.org/jira/browse/OAK-739 Pr

[jira] [Resolved] (OAK-737) Remove default security provider in Oak.java

2013-04-03 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela resolved OAK-737. Resolution: Fixed fixed in Revision: 1463955 > Remove default security provider in Oak.java > ---

[jira] [Commented] (OAK-737) Remove default security provider in Oak.java

2013-04-03 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620881#comment-13620881 ] angela commented on OAK-737: i don't want to change the default but want to get rid of the defaul

[jira] [Commented] (OAK-737) Remove default security provider in Oak.java

2013-04-03 Thread Antonio Sanso (JIRA)
[ https://issues.apache.org/jira/browse/OAK-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620875#comment-13620875 ] Antonio Sanso commented on OAK-737: --- blindly changing the oak security provider to privat

[jira] [Commented] (OAK-509) Item names starting with '{X}' cause RepositoryException

2013-04-03 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620866#comment-13620866 ] Michael Dürig commented on OAK-509: --- Yes, {{LocalNameMapper.getJcrName}} should not do {{c

[jira] [Resolved] (OAK-738) Assertion error when adding node with expanded name

2013-04-03 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Dürig resolved OAK-738. --- Resolution: Fixed Fix Version/s: 0.7 Fixed at revision 1463931 > Assertion error

[jira] [Assigned] (OAK-738) Assertion error when adding node with expanded name

2013-04-03 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Dürig reassigned OAK-738: - Assignee: Michael Dürig > Assertion error when adding node with expanded name >

[jira] [Created] (OAK-738) Assertion error when adding node with expanded name

2013-04-03 Thread JIRA
Michael Dürig created OAK-738: - Summary: Assertion error when adding node with expanded name Key: OAK-738 URL: https://issues.apache.org/jira/browse/OAK-738 Project: Jackrabbit Oak Issue Type: Bu

[jira] [Commented] (OAK-737) Remove default security provider in Oak.java

2013-04-03 Thread Antonio Sanso (JIRA)
[ https://issues.apache.org/jira/browse/OAK-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620800#comment-13620800 ] Antonio Sanso commented on OAK-737: --- +1 > Remove default security provider

[jira] [Assigned] (OAK-737) Remove default security provider in Oak.java

2013-04-03 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela reassigned OAK-737: -- Assignee: angela > Remove default security provider in Oak.java >

[jira] [Created] (OAK-737) Remove default security provider in Oak.java

2013-04-03 Thread angela (JIRA)
angela created OAK-737: -- Summary: Remove default security provider in Oak.java Key: OAK-737 URL: https://issues.apache.org/jira/browse/OAK-737 Project: Jackrabbit Oak Issue Type: Improvement C

[jira] [Assigned] (OAK-736) Enhancement to the PermissionProviderImpl constructor

2013-04-03 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] angela reassigned OAK-736: -- Assignee: angela > Enhancement to the PermissionProviderImpl constructor > ---

[jira] [Commented] (OAK-734) Refactor indexing code to use Editors

2013-04-03 Thread Tommaso Teofili (JIRA)
[ https://issues.apache.org/jira/browse/OAK-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620786#comment-13620786 ] Tommaso Teofili commented on OAK-734: - this is what I get: {code} ---

[jira] [Commented] (OAK-734) Refactor indexing code to use Editors

2013-04-03 Thread Alex Parvulescu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620781#comment-13620781 ] Alex Parvulescu commented on OAK-734: - bq. the changes break the sql2 test hmm, this is

[jira] [Commented] (OAK-734) Refactor indexing code to use Editors

2013-04-03 Thread Tommaso Teofili (JIRA)
[ https://issues.apache.org/jira/browse/OAK-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620777#comment-13620777 ] Tommaso Teofili commented on OAK-734: - it generally looks good to me, but regarding the S

[jira] [Updated] (OAK-736) Enhancement to the PermissionProviderImpl constructor

2013-04-03 Thread Antonio Sanso (JIRA)
[ https://issues.apache.org/jira/browse/OAK-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso updated OAK-736: -- Attachment: OAK-736-patch.txt attaching simple patch > Enhancement to the PermissionProvi

[jira] [Commented] (OAK-736) Enhancement to the PermissionProviderImpl constructor

2013-04-03 Thread Antonio Sanso (JIRA)
[ https://issues.apache.org/jira/browse/OAK-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620770#comment-13620770 ] Antonio Sanso commented on OAK-736: --- Attaching simple patch #P oak-core Index: src/main/

[jira] [Issue Comment Deleted] (OAK-736) Enhancement to the PermissionProviderImpl constructor

2013-04-03 Thread Antonio Sanso (JIRA)
[ https://issues.apache.org/jira/browse/OAK-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso updated OAK-736: -- Comment: was deleted (was: Attaching simple patch #P oak-core Index: src/main/java/org/apache/jackrabbi

[jira] [Created] (OAK-736) Enhancement to the PermissionProviderImpl constructor

2013-04-03 Thread Antonio Sanso (JIRA)
Antonio Sanso created OAK-736: - Summary: Enhancement to the PermissionProviderImpl constructor Key: OAK-736 URL: https://issues.apache.org/jira/browse/OAK-736 Project: Jackrabbit Oak Issue Type:

[jira] [Commented] (OAK-734) Refactor indexing code to use Editors

2013-04-03 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/OAK-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620755#comment-13620755 ] Jukka Zitting commented on OAK-734: --- +1 Looks good to me. There's a number of further impr

[jira] [Reopened] (OAK-675) Observation generates NPE in an existing EventListener

2013-04-03 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/OAK-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting reopened OAK-675: --- Assignee: (was: Alex Parvulescu) > Observation generates NPE in an existing EventListener > --

[jira] [Updated] (OAK-675) Observation generates NPE in an existing EventListener

2013-04-03 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/OAK-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting updated OAK-675: -- Issue Type: Improvement (was: Bug) Summary: Observation generates NPE in an existing EventListener

[jira] [Commented] (OAK-675) Observation generates NPE in sling EventListener

2013-04-03 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620743#comment-13620743 ] Michael Dürig commented on OAK-675: --- bq. shouldn't this go into OAK-144, or a dedicated sub

[jira] [Commented] (OAK-675) Observation generates NPE in sling EventListener

2013-04-03 Thread Alex Parvulescu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620741#comment-13620741 ] Alex Parvulescu commented on OAK-675: - shouldn't this go into OAK-144, or a dedicated sub

[jira] [Commented] (OAK-675) Observation generates NPE in sling EventListener

2013-04-03 Thread Marcel Reutegger (JIRA)
[ https://issues.apache.org/jira/browse/OAK-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620737#comment-13620737 ] Marcel Reutegger commented on OAK-675: -- Returning null actually is a problem for other c

[jira] [Commented] (OAK-675) Observation generates NPE in sling EventListener

2013-04-03 Thread Jukka Zitting (JIRA)
[ https://issues.apache.org/jira/browse/OAK-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620728#comment-13620728 ] Jukka Zitting commented on OAK-675: --- If this turns out to be a problem for also other clien

[jira] [Resolved] (OAK-675) Observation generates NPE in sling EventListener

2013-04-03 Thread Alex Parvulescu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Parvulescu resolved OAK-675. - Resolution: Not A Problem Assignee: Alex Parvulescu marking as 'not a problem'. this was addre