[
https://issues.apache.org/jira/browse/OAK-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14229989#comment-14229989
]
Julian Reschke edited comment on OAK-2044 at 12/1/14 4:30 PM:
--------------------------------------------------------------
Hmm. I just tried with this:
{code}
---
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocument.java
(revision 1642693)
+++
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocument.java
(working copy)
@@ -364,11 +364,11 @@
*/
@Nonnull
public Map<Revision, String> getValueMap(@Nonnull String key) {
- if (IGNORE_ON_SPLIT.contains(key)) {
- return Collections.emptyMap();
- } else {
+// if (IGNORE_ON_SPLIT.contains(key)) {
+// return Collections.emptyMap();
+// } else {
return ValueMap.create(this, key);
- }
+// }
}
{code}
change, and all tests (incl integration) passed. This seems to be a change
since I opened the ticket.
[~mreutegg] Maybe the white list isn't needed anymore anyway?
was (Author: reschke):
Hmm. I just tried with this:
{code}
---
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocument.java
(revision 1642693)
+++
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocument.java
(working copy)
@@ -364,11 +364,11 @@
*/
@Nonnull
public Map<Revision, String> getValueMap(@Nonnull String key) {
- if (IGNORE_ON_SPLIT.contains(key)) {
- return Collections.emptyMap();
- } else {
+// if (IGNORE_ON_SPLIT.contains(key)) {
+// return Collections.emptyMap();
+// } else {
return ValueMap.create(this, key);
- }
+// }
}
{code}
change, and all tests (incl integration) passed. This seems to be a change
since I opened the ticket.
[~mreutegg]] Maybe the white list isn't needed anymore anyway?
> DocumentSplit should allow properties added by persistence
> ----------------------------------------------------------
>
> Key: OAK-2044
> URL: https://issues.apache.org/jira/browse/OAK-2044
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: mongomk
> Affects Versions: 1.0.8, 1.1.2
> Reporter: Julian Reschke
>
> NodeDocument's split functionality currently has a hardwired white list of
> properties that are ignored on split(). This makes it impossible for
> DocumentStore implementation to add its own properties without modifying
> NodeDocument.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
