[ 
https://issues.apache.org/jira/browse/OAK-8013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778426#comment-16778426
 ] 

Matt Ryan edited comment on OAK-8013 at 2/26/19 6:20 PM:
---------------------------------------------------------

I learned today that the original [Azure SDK for 
Java|https://github.com/Azure/azure-sdk-for-java] is deprecated, and has been 
replaced by a new [Azure Storage SDK for 
Java|https://github.com/Azure/azure-storage-java].  Based on reading the 
README's at both Git repos I expect the following:
* They aren't going to implement a fix for the library we depend on as it is 
considered legacy and deprecated now
* In order to use the new library we would need to rewrite 
{{oak-blob-cloud-azure}} to use the new API; I don't think it is backwards 
compatible based on what is said 
[here|https://github.com/Azure/azure-storage-java/#migrating-to-v10].

It is still unclear to me whether this issue is still an issue with the new 
SDK.  I have a simple project I can use to test it out so I'll try that and 
report back.


was (Author: mattvryan):
I learned today that the original [Azure SDK for 
Java|https://github.com/Azure/azure-sdk-for-java] is deprecated, and has been 
replaced by a new [Azure Storage SDK for 
Java|https://github.com/Azure/azure-storage-java].  Based on reading the 
README's at both Git repos I expect the following:
* They aren't going to implement a fix for the library we depend on as it is 
considered legacy and deprecated now
* In order to use the new library we will need to rewrite 
{{oak-blob-cloud-azure}} to use the new API; I don't think it is backwards 
compatible based on what is said 
[here|https://github.com/Azure/azure-storage-java/#migrating-to-v10].

It is still unclear to me whether this issue is still an issue with the new 
SDK.  I have a simple project I can use to test it out so I'll try that and 
report back.

> [Direct Binary Access] DataRecordDownloadOptions creates invalid 
> Content-Disposition headers
> --------------------------------------------------------------------------------------------
>
>                 Key: OAK-8013
>                 URL: https://issues.apache.org/jira/browse/OAK-8013
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: blob-plugins
>            Reporter: Alexander Klimetschek
>            Assignee: Matt Ryan
>            Priority: Major
>
> DataRecordDownloadOptions always adds the extended parameter filename* to the 
> header, [without any 
> escaping|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-blob-plugins/src/main/java/org/apache/jackrabbit/oak/plugins/blob/datastore/directaccess/DataRecordDownloadOptions.java#L130].
> Such extended parameters must not include spaces (and only a small predefined 
> list of basic ascii chars), otherwise they have to be percent encoded. The 
> RFC is https://tools.ietf.org/html/rfc5987 and note the definition of 
> value-chars in the grammar.
> Because of this, if a filename includes a space or another character that 
> must be percent encoded, this currently creates an invalid header that fails 
> to be parsed by other clients.
> See also https://github.com/jshttp/content-disposition/issues/24
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to