[ 
https://issues.apache.org/jira/browse/OAK-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14647556#comment-14647556
 ] 

Alex Parvulescu commented on OAK-3164:
--------------------------------------

+1
for those with doubts about how this bug manifests itself, the key is the async 
indexer also releases a checkpoint once it is done with it, that's why the 
overall size is constant, resulting in overwriting existing checkpoints :) good 
one [~chetanm]!

> MemoryNodeStore issues duplicate checkpoint
> -------------------------------------------
>
>                 Key: OAK-3164
>                 URL: https://issues.apache.org/jira/browse/OAK-3164
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: e
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>            Priority: Minor
>             Fix For: 1.3.4
>
>         Attachments: OAK-3164.patch
>
>
> {{MemoryNodeStore}} can possibly issue duplicate checkpoint. In below logic 
> if {{checkpoints}} has one entry then on subsequent call to issue checkpoint 
> the name would be set to {{checkpoint1}} only. This causes AsyncIndexUpdate 
> test to fail in some cases
> {code}
>     @Override
>     public String checkpoint(long lifetime, @Nonnull Map<String, String> 
> properties) {
>         checkArgument(lifetime > 0);
>         checkNotNull(properties);
>         String checkpoint = "checkpoint" + checkpoints.size();
>         checkpoints.put(checkpoint, new Checkpoint(getRoot(), properties));
>         return checkpoint;
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to