[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573679#comment-13573679
]
angela commented on OAK-343:
testFindAuthorizableByRelativePath is caused by a bug in the code :-
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573624#comment-13573624
]
angela commented on OAK-343:
the testCyclicGroups is fine and just needed the save calls to be pl
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573588#comment-13573588
]
angela commented on OAK-343:
i resolved most remaining TODOs related to OAK-343 and fixed the
te
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562823#comment-13562823
]
Manfred Baedke commented on OAK-343:
Finally, GroupTest.testCyclicGroups() relies on
{cod
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562813#comment-13562813
]
Manfred Baedke commented on OAK-343:
FindAuthorizablesTest.testFindAuthorizableByRelative
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562802#comment-13562802
]
Alex Parvulescu commented on OAK-343:
-
yes, I fixed it again :)
The diff mechanism is not
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562792#comment-13562792
]
Manfred Baedke commented on OAK-343:
So far, I tested on my own fork with the initial pat
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562778#comment-13562778
]
Manfred Baedke commented on OAK-343:
And GroupTest.testCyclicGroups() and
FindAuthorizab
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562773#comment-13562773
]
Alex Parvulescu commented on OAK-343:
-
Thanks for the help Manfred.
I think we need now
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562761#comment-13562761
]
Manfred Baedke commented on OAK-343:
Only two remaining failures:
UserManagerTest.testGr
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562756#comment-13562756
]
Alex Parvulescu commented on OAK-343:
-
bq. Found it. The childNodeChanged() implementatio
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562757#comment-13562757
]
Alex Parvulescu commented on OAK-343:
-
first good news: UserManagerTest.testGetNewAuthori
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562735#comment-13562735
]
Manfred Baedke commented on OAK-343:
Found it. The childNodeChanged() implementation stop
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562708#comment-13562708
]
Manfred Baedke commented on OAK-343:
Yes, just made the same observation. Sorry for the c
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562702#comment-13562702
]
Alex Parvulescu commented on OAK-343:
-
I took a closer look at UserManagerTest.testGetNew
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562692#comment-13562692
]
Alex Parvulescu commented on OAK-343:
-
bq. UserManagerTest.testGetNewAuthorizable()
righ
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562684#comment-13562684
]
Alex Parvulescu commented on OAK-343:
-
Interesting, I was looking at a different test :)
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562675#comment-13562675
]
Manfred Baedke commented on OAK-343:
I debugged the failing test case UserManagerTest.tes
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562646#comment-13562646
]
Alex Parvulescu commented on OAK-343:
-
> I will take over from here. There are a few chan
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562579#comment-13562579
]
Thomas Mueller commented on OAK-343:
Removed block for OAK-50
> Session.
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562578#comment-13562578
]
Thomas Mueller commented on OAK-343:
OK, great, thanks a lot! I will take over from here.
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562564#comment-13562564
]
Alex Parvulescu commented on OAK-343:
-
I pushed the patch with rev 1438403.
There was a
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561616#comment-13561616
]
Manfred Baedke commented on OAK-343:
Very good.
> Session.getNodeByUUID
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561539#comment-13561539
]
Thomas Mueller commented on OAK-343:
I will work on this. I will try to integrate (maybe
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547729#comment-13547729
]
Thomas Mueller commented on OAK-343:
The patch looks good to me. It's not the final solut
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546990#comment-13546990
]
Manfred Baedke commented on OAK-343:
Updated patch to use Double.POSITIVE_INFINITY and Do
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1352#comment-1352
]
Jukka Zitting commented on OAK-343:
---
bq. Since the QueryIndex solution works and doesn't ch
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529923#comment-13529923
]
Manfred Baedke commented on OAK-343:
@Angela: Note that I had to change a testcase in Use
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529922#comment-13529922
]
Manfred Baedke commented on OAK-343:
I uploaded a new version of the QueryIndex solution
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529796#comment-13529796
]
Michael Dürig commented on OAK-343:
---
bq. Could we do this in a generic manner by extending
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529790#comment-13529790
]
Jukka Zitting commented on OAK-343:
---
Yeah, having this exposed in Root is a bit troublesome
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529779#comment-13529779
]
Michael Dürig commented on OAK-343:
---
bq. but then we have to change the Root interface
On
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529775#comment-13529775
]
Manfred Baedke commented on OAK-343:
Btw: I admittedly overstretched the contract of the
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529769#comment-13529769
]
Manfred Baedke commented on OAK-343:
We can do that, but then we have to change the Root
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529767#comment-13529767
]
Thomas Mueller commented on OAK-343:
> What I had in mind originally was for IdentifierMa
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529763#comment-13529763
]
Jukka Zitting commented on OAK-343:
---
I'm not too excited about using the QueryIndex mechani
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529744#comment-13529744
]
Thomas Mueller commented on OAK-343:
For me it's not actually about that getCost() gets c
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529136#comment-13529136
]
Manfred Baedke commented on OAK-343:
Added recursion, works better now.
@Michael: Thank y
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529108#comment-13529108
]
Michael Dürig commented on OAK-343:
---
Thanks for the patch. A few comments
* Please use Gua
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529105#comment-13529105
]
Thomas Mueller commented on OAK-343:
This is a very interesting approach. It should work
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529084#comment-13529084
]
Manfred Baedke commented on OAK-343:
As expected, immediately after uploading the patch I
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528835#comment-13528835
]
Michael Dürig commented on OAK-343:
---
bq. wrap the RootImpl.indexProvider [...]
I'd prefer
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528089#comment-13528089
]
Manfred Baedke commented on OAK-343:
I looked into it and found that it should be possibl
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527999#comment-13527999
]
Manfred Baedke commented on OAK-343:
As suggested by Thomas and Angela, this can be solve
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504643#comment-13504643
]
Julian Reschke commented on OAK-343:
Spec lawyering question: does the JCR spec allow an
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463852#comment-13463852
]
Jukka Zitting commented on OAK-343:
---
Marcel brought up the good idea that there's no need f
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463749#comment-13463749
]
angela commented on OAK-343:
regarding the user mgt: i realized that when looking at failing test
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463745#comment-13463745
]
angela commented on OAK-343:
well, since the uuid is created immediately and the node is referenc
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463697#comment-13463697
]
Jukka Zitting commented on OAK-343:
---
Do we need the UUIDs to be present and usable before a
[
https://issues.apache.org/jira/browse/OAK-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463663#comment-13463663
]
angela commented on OAK-343:
the same applies to IdentifierManager#getTree and main issue behind
50 matches
Mail list logo
