[
https://issues.apache.org/jira/browse/OAK-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120995#comment-15120995
]
Marcel Reutegger commented on OAK-3559:
---
The patch looks good. I made some minor modifications:
*
[
https://issues.apache.org/jira/browse/OAK-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15118971#comment-15118971
]
Marcel Reutegger commented on OAK-3559:
---
The patch also contains a fix unrelated to this issue. With
[
https://issues.apache.org/jira/browse/OAK-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15117109#comment-15117109
]
Tomek Rękawek commented on OAK-3559:
The concurrent unit tests have been moved to OAK-3924 (as they were
[
https://issues.apache.org/jira/browse/OAK-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106860#comment-15106860
]
Tomek Rękawek commented on OAK-3559:
[~mreutegg], do you have any other suggestions?
> Bulk document
[
https://issues.apache.org/jira/browse/OAK-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15080915#comment-15080915
]
Marcel Reutegger commented on OAK-3559:
---
I think the current patch is prone to deadlocks. Currently
[
https://issues.apache.org/jira/browse/OAK-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081202#comment-15081202
]
Tomek Rękawek commented on OAK-3559:
I updated the patch with following changes:
1. Lock keys are
[
https://issues.apache.org/jira/browse/OAK-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996200#comment-14996200
]
Marcel Reutegger commented on OAK-3559:
---
bq. The original test didn't work on the delayed network, so
[
https://issues.apache.org/jira/browse/OAK-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14996258#comment-14996258
]
Tomek Rękawek commented on OAK-3559:
{quote}
>The original test didn't work on the delayed network, so I
[
https://issues.apache.org/jira/browse/OAK-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993474#comment-14993474
]
Tomek Rękawek commented on OAK-3559:
I set the journal to true and got following results:
{noformat}
[
https://issues.apache.org/jira/browse/OAK-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993222#comment-14993222
]
Chetan Mehrotra commented on OAK-3559:
--
[~tomek.rekawek] Can also get numbers by increasing the write
[
https://issues.apache.org/jira/browse/OAK-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14991689#comment-14991689
]
Tomek Rękawek commented on OAK-3559:
I moved the fallback to the DS.
Also, did some benchmark tests -
[
https://issues.apache.org/jira/browse/OAK-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989511#comment-14989511
]
Marcel Reutegger commented on OAK-3559:
---
Thanks for the pull request.
bq. If some other process
[
https://issues.apache.org/jira/browse/OAK-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989528#comment-14989528
]
Tomek Rękawek commented on OAK-3559:
I will extract the CommitQueue and ConflictException changes into
[
https://issues.apache.org/jira/browse/OAK-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14989631#comment-14989631
]
Marcel Reutegger commented on OAK-3559:
---
In my view it would make the DS contract simpler and also
[
https://issues.apache.org/jira/browse/OAK-3559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986971#comment-14986971
]
Tomek Rękawek commented on OAK-3559:
The pull request has been created here:
15 matches
Mail list logo
