[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-12-01 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033355#comment-15033355 ] Michael Dürig commented on OAK-3654: Aha ok, thanks for the clarification. > Integrate

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-12-01 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033343#comment-15033343 ] Chetan Mehrotra commented on OAK-3654: -- Some confusion. The default TimeSeries support

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-12-01 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033292#comment-15033292 ] Michael Dürig commented on OAK-3654: I'm not too happy about losing the session read tim

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-30 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15033174#comment-15033174 ] Chetan Mehrotra commented on OAK-3654: -- Disabled metrics for session read count with 17

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-29 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031333#comment-15031333 ] Chetan Mehrotra commented on OAK-3654: -- [~ianeboston] Given that there is still some ov

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-24 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026303#comment-15026303 ] Chetan Mehrotra commented on OAK-3654: -- Done all the planned changes. Fast clock is now

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-24 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026297#comment-15026297 ] Chetan Mehrotra commented on OAK-3654: -- bq. As mentioned earlier, using the context.sto

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-24 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15025052#comment-15025052 ] Ian Boston commented on OAK-3654: - LvGTM. You might want to share the pointer with the Metr

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-24 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024451#comment-15024451 ] Chetan Mehrotra commented on OAK-3654: -- Modified the logic to allow disabling the Timer

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-24 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024424#comment-15024424 ] Michael Dürig commented on OAK-3654: bq. Metrics provides "bad stats" because its being

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-24 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024410#comment-15024410 ] Chetan Mehrotra commented on OAK-3654: -- {quote} Internally Metics will probably use nan

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-24 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024367#comment-15024367 ] Ian Boston commented on OAK-3654: - Metrics provides "bad stats" because its being given "ba

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-24 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024289#comment-15024289 ] Michael Dürig commented on OAK-3654: Or maybe not... I remember people actually using th

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-24 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024240#comment-15024240 ] Michael Dürig commented on OAK-3654: bq. but based on the above it's probable the block

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-24 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024219#comment-15024219 ] Ian Boston commented on OAK-3654: - The metrics stats show 2 things. {code} min=0.0, max=0.0

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-24 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024140#comment-15024140 ] Chetan Mehrotra commented on OAK-3654: -- Updated the ReadPropertyTest benchmark to provi

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-24 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024020#comment-15024020 ] Michael Dürig commented on OAK-3654: I'm a bit worried here regarding the additional ove

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-23 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023912#comment-15023912 ] Ian Boston commented on OAK-3654: - My tests showed that timing measurements of operations th

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-23 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023803#comment-15023803 ] Chetan Mehrotra commented on OAK-3654: -- bq. Would have to refactor that to avoid the ex

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-23 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15023775#comment-15023775 ] Chetan Mehrotra commented on OAK-3654: -- bq. hence when ACCURATE.getTime() is called it

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-23 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022031#comment-15022031 ] Ian Boston commented on OAK-3654: - Clock.Fast has a maximum resolution of 1ms and when getTi

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-23 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021991#comment-15021991 ] Chetan Mehrotra commented on OAK-3654: -- bq. nanoTimer and performance. I have measured

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-23 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021985#comment-15021985 ] Chetan Mehrotra commented on OAK-3654: -- Applied the modified patch along with testcases

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-22 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021081#comment-15021081 ] Chetan Mehrotra commented on OAK-3654: -- {quote} The Timer.update(...) isn't very clean

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-20 Thread Ian Boston (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15015528#comment-15015528 ] Ian Boston commented on OAK-3654: - Patch LGTM, some comments. The Timer.update(...) isn't v

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-19 Thread Thomas Mueller (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013455#comment-15013455 ] Thomas Mueller commented on OAK-3654: - It looks good to me. As far as I understand, it i

[jira] [Commented] (OAK-3654) Integrate with Metrics for various stats collection

2015-11-19 Thread Chetan Mehrotra (JIRA)
[ https://issues.apache.org/jira/browse/OAK-3654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013403#comment-15013403 ] Chetan Mehrotra commented on OAK-3654: -- Attached is [initial implementation|^OAK-3654-v