[jira] [Commented] (OAK-5253) Optimize AbstractBlob#equal to not do content equals when possible

[ https://issues.apache.org/jira/browse/OAK-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15741548#comment-15741548 ] Michael Dürig commented on OAK-5253: My bad, just corrected my comment. > Optimize Abs

[jira] [Commented] (OAK-5253) Optimize AbstractBlob#equal to not do content equals when possible

[ https://issues.apache.org/jira/browse/OAK-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15741389#comment-15741389 ] Julian Sedding commented on OAK-5253: - bq. [...] we should think about how to surface th

[jira] [Commented] (OAK-5253) Optimize AbstractBlob#equal to not do content equals when possible

[ https://issues.apache.org/jira/browse/OAK-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15741381#comment-15741381 ] Amit Jain commented on OAK-5253: [~mduerig], [~jsedding] iirc then your recommendation is th

[jira] [Commented] (OAK-5253) Optimize AbstractBlob#equal to not do content equals when possible

[ https://issues.apache.org/jira/browse/OAK-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15741374#comment-15741374 ] Julian Sedding commented on OAK-5253: - [~mduerig] I understood it to be the other way ar

[jira] [Commented] (OAK-5253) Optimize AbstractBlob#equal to not do content equals when possible

[ https://issues.apache.org/jira/browse/OAK-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15741363#comment-15741363 ] Michael Dürig commented on OAK-5253: I share [~jsedding]'s concern. I think it is fine t

[jira] [Commented] (OAK-5253) Optimize AbstractBlob#equal to not do content equals when possible

[ https://issues.apache.org/jira/browse/OAK-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15741338#comment-15741338 ] Julian Sedding commented on OAK-5253: - [~amitjain] In {{BlobStoreBlob#equals}} there is

[jira] [Commented] (OAK-5253) Optimize AbstractBlob#equal to not do content equals when possible

[ https://issues.apache.org/jira/browse/OAK-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15741207#comment-15741207 ] Amit Jain commented on OAK-5253: We could change the {{SegmentBlob#equals()}} implementation

[jira] [Commented] (OAK-5253) Optimize AbstractBlob#equal to not do content equals when possible

[ https://issues.apache.org/jira/browse/OAK-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15735027#comment-15735027 ] Julian Sedding commented on OAK-5253: - Thanks [~amitjain]. I am wondering if we could co

[jira] [Commented] (OAK-5253) Optimize AbstractBlob#equal to not do content equals when possible

[ https://issues.apache.org/jira/browse/OAK-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15734957#comment-15734957 ] Amit Jain commented on OAK-5253: Reverted commits: * trunk - http://svn.apache.org/viewvc?re

[jira] [Commented] (OAK-5253) Optimize AbstractBlob#equal to not do content equals when possible

[ https://issues.apache.org/jira/browse/OAK-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15734916#comment-15734916 ] Amit Jain commented on OAK-5253: Ok will back out the changes and try to make change in the

[jira] [Commented] (OAK-5253) Optimize AbstractBlob#equal to not do content equals when possible

[ https://issues.apache.org/jira/browse/OAK-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15734550#comment-15734550 ] Amit Jain commented on OAK-5253: Thanks Matt! Was already wip. But for 1.4 needed some backp

[jira] [Commented] (OAK-5253) Optimize AbstractBlob#equal to not do content equals when possible

[ https://issues.apache.org/jira/browse/OAK-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15733366#comment-15733366 ] Matt Ryan commented on OAK-5253: I just checked the patch with 1.4 and it applies cleanly.