[ https://issues.apache.org/jira/browse/OAK-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861262#comment-15861262 ]
Francesco Mari commented on OAK-5620: ------------------------------------- The patch looks good to me. I have only a minor remark. In {{ConsistencyChecker#checkConsistency}} the {{initialPath}} variable is used only once. Its only usage should probably be changed to the literal string instead, and the variable be removed. > Simplify consistency check > -------------------------- > > Key: OAK-5620 > URL: https://issues.apache.org/jira/browse/OAK-5620 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: run, segment-tar > Reporter: Andrei Dulceanu > Assignee: Andrei Dulceanu > Labels: tooling > Fix For: 1.7.0, 1.8 > > Attachments: OAK-5620.patch > > > The current implementation of the consistency check > ({{ConsistencyChecker}},{{CheckCommand}}) > is cluttered with unnecessary checks regarding deprecated arguments of the > {{check}} command. > With OAK-5595, deep traversals are enabled by default, therefore the code > needs to be revised to take this into account. The same applies to the > argument taken by {{--bin}} option, which was removed in OAK-5604. > Moreover, {{ConsistencyChecker}} could be refactored in order to better > distinguish when: > * a full path at the given revision is checked > * a node and its properties are checked > * a node and its descendants are checked -- This message was sent by Atlassian JIRA (v6.3.15#6346)