[jira] [Commented] (OAK-566) MongoMK throws exception when adding nodes concurrently

[ https://issues.apache.org/jira/browse/OAK-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561647#comment-13561647 ] Marcel Reutegger commented on OAK-566: -- bq. Is it likely that we'd need to check for old

[jira] [Commented] (OAK-566) MongoMK throws exception when adding nodes concurrently

[ https://issues.apache.org/jira/browse/OAK-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561635#comment-13561635 ] Mete Atamel commented on OAK-566: - I think I understand the fix now. It looks good but I wish

[jira] [Commented] (OAK-566) MongoMK throws exception when adding nodes concurrently

[ https://issues.apache.org/jira/browse/OAK-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561619#comment-13561619 ] Mete Atamel commented on OAK-566: - Regarding invalidLastRevision test, I also think that it s

[jira] [Commented] (OAK-566) MongoMK throws exception when adding nodes concurrently

[ https://issues.apache.org/jira/browse/OAK-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561569#comment-13561569 ] Marcel Reutegger commented on OAK-566: -- bq. do we know for sure that in-doubt period wor

[jira] [Commented] (OAK-566) MongoMK throws exception when adding nodes concurrently

[ https://issues.apache.org/jira/browse/OAK-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561568#comment-13561568 ] Marcel Reutegger commented on OAK-566: -- One more thing. FetchNodesActionTest#invalidLast

[jira] [Commented] (OAK-566) MongoMK throws exception when adding nodes concurrently

[ https://issues.apache.org/jira/browse/OAK-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561565#comment-13561565 ] Mete Atamel commented on OAK-566: - I took a quick look but need to spend more time to underst

[jira] [Commented] (OAK-566) MongoMK throws exception when adding nodes concurrently

[ https://issues.apache.org/jira/browse/OAK-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561526#comment-13561526 ] Mete Atamel commented on OAK-566: - It's kind of dangerous to leave FetchCommitAction as it ca

[jira] [Commented] (OAK-566) MongoMK throws exception when adding nodes concurrently

[ https://issues.apache.org/jira/browse/OAK-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561515#comment-13561515 ] Marcel Reutegger commented on OAK-566: -- I agree and came to the same conclusion. I'm cu

[jira] [Commented] (OAK-566) MongoMK throws exception when adding nodes concurrently

[ https://issues.apache.org/jira/browse/OAK-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561512#comment-13561512 ] Mete Atamel commented on OAK-566: - Thought about this a little more. For a commit to be consi

[jira] [Commented] (OAK-566) MongoMK throws exception when adding nodes concurrently

[ https://issues.apache.org/jira/browse/OAK-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560726#comment-13560726 ] Mete Atamel commented on OAK-566: - I managed to come up with a simple test case that exhibits

[jira] [Commented] (OAK-566) MongoMK throws exception when adding nodes concurrently

[ https://issues.apache.org/jira/browse/OAK-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560713#comment-13560713 ] Mete Atamel commented on OAK-566: - One minor but important point. The test case adds /node2 a

[jira] [Commented] (OAK-566) MongoMK throws exception when adding nodes concurrently

[ https://issues.apache.org/jira/browse/OAK-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560553#comment-13560553 ] Mete Atamel commented on OAK-566: - > I mean, is commit1 really valid at that time? If the com

[jira] [Commented] (OAK-566) MongoMK throws exception when adding nodes concurrently

[ https://issues.apache.org/jira/browse/OAK-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560534#comment-13560534 ] Damien Obrist commented on OAK-566: --- bq. Not quite. The MongoMK implementation maintains a

[jira] [Commented] (OAK-566) MongoMK throws exception when adding nodes concurrently

[ https://issues.apache.org/jira/browse/OAK-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560518#comment-13560518 ] Mete Atamel commented on OAK-566: - I also looked into this and here's what I think happens: -

[jira] [Commented] (OAK-566) MongoMK throws exception when adding nodes concurrently

[ https://issues.apache.org/jira/browse/OAK-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560500#comment-13560500 ] Marcel Reutegger commented on OAK-566: -- bq. This cannot be the case however, as the node

[jira] [Commented] (OAK-566) MongoMK throws exception when adding nodes concurrently

[ https://issues.apache.org/jira/browse/OAK-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560497#comment-13560497 ] Marcel Reutegger commented on OAK-566: -- I think this happens because the current thread

[jira] [Commented] (OAK-566) MongoMK throws exception when adding nodes concurrently

[ https://issues.apache.org/jira/browse/OAK-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559674#comment-13559674 ] Marcel Reutegger commented on OAK-566: -- Thanks for the test, I have committed a slightly