[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285885#comment-16285885
]
Marcel Reutegger commented on OAK-6575:
---
Created a link to SLING-7140 where the Sling
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208920#comment-16208920
]
Julian Reschke commented on OAK-6575:
-
bq. Sling can only release using stable versions
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208833#comment-16208833
]
Ian Boston commented on OAK-6575:
-
Blocker subtask OAK-6841 has been created. I hope that is
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208827#comment-16208827
]
Ian Boston commented on OAK-6575:
-
Summarising discussions on oak-dev and Sling dev.
Sling c
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194443#comment-16194443
]
Ian Boston commented on OAK-6575:
-
At a bundle level yes.
1.6 oak-core vs 1.8-SNAPSHOT oak-a
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194428#comment-16194428
]
Julian Reschke commented on OAK-6575:
-
bq. The API in 1.6 is part of oak-core, in 1.8-SN
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194387#comment-16194387
]
Ian Boston commented on OAK-6575:
-
Doc: Anyone deploying will find it hard to do so without
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192702#comment-16192702
]
Amit Jain commented on OAK-6575:
Couple of more changes
* Moved classes from org.apache.jack
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192685#comment-16192685
]
Amit Jain commented on OAK-6575:
I committed the changes with http://svn.apache.org/viewvc?r
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185732#comment-16185732
]
Ian Boston commented on OAK-6575:
-
Configuration information
https://gist.github.com/ieb/f9
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185710#comment-16185710
]
Ian Boston commented on OAK-6575:
-
Pull requests:
Oak Trunk https://github.com/apache/jackra
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16185665#comment-16185665
]
Ian Boston commented on OAK-6575:
-
Tested against Sling Trunk using a patch backported to Oa
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173382#comment-16173382
]
Ian Boston commented on OAK-6575:
-
The pull request identified some issues from the communit
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171977#comment-16171977
]
Ian Boston commented on OAK-6575:
-
Opened SLING-7140 to track downstream work.
Patch has bee
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171962#comment-16171962
]
Ian Boston commented on OAK-6575:
-
Pull request created,
https://github.com/apache/jackrabb
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166284#comment-16166284
]
Ian Boston commented on OAK-6575:
-
Thanks for the corrections. Made the changes and updated
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165988#comment-16165988
]
Alex Deparvu commented on OAK-6575:
---
A few remarks on the Oak patch:
* I would remove this
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156722#comment-16156722
]
Ian Boston commented on OAK-6575:
-
Based on discussions on oak-dev and URIProvider proposa
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153541#comment-16153541
]
Ian Boston commented on OAK-6575:
-
After discussion on oak-dev, 2 more alternative patches.
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152298#comment-16152298
]
Ian Boston commented on OAK-6575:
-
Changes made and pull request created.
https://github.co
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152233#comment-16152233
]
Amit Jain commented on OAK-6575:
[~ianeboston]
bq. For these reasons I suggested keeping URI
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152217#comment-16152217
]
Ian Boston commented on OAK-6575:
-
I will make the changes (CloudFrontS3SignedUrlAdapterFact
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152111#comment-16152111
]
Amit Jain commented on OAK-6575:
You can either directly add the patch here or do a pull req
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152107#comment-16152107
]
Amit Jain commented on OAK-6575:
[~ianeboston], [~chetanm]
I can commit the change but
bq.
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150373#comment-16150373
]
Ian Boston commented on OAK-6575:
-
In which case, is the patch ok for inclusion ?
Should I d
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150205#comment-16150205
]
Chetan Mehrotra commented on OAK-6575:
--
bq. This issue was to provide a external URL, n
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150196#comment-16150196
]
Ian Boston commented on OAK-6575:
-
bq. One usecase would be in workflow processing where som
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150180#comment-16150180
]
Chetan Mehrotra commented on OAK-6575:
--
bq. Could you share the use case that creates a
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150168#comment-16150168
]
Ian Boston commented on OAK-6575:
-
Could you share the use case that creates a requirement f
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150092#comment-16150092
]
Amit Jain commented on OAK-6575:
[~ianeboston] The implementation looks fine to me.
But we
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148884#comment-16148884
]
Ian Boston commented on OAK-6575:
-
Now using the AWS SDK.
> Provide a secure external URL t
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148835#comment-16148835
]
Amit Jain commented on OAK-6575:
bq. The patch opens the way to allow other providers includ
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148813#comment-16148813
]
Ian Boston commented on OAK-6575:
-
The patch opens the way to allow other providers includin
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148805#comment-16148805
]
Amit Jain commented on OAK-6575:
Also, this is very specific implementation to CloudFront wh
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148789#comment-16148789
]
Amit Jain commented on OAK-6575:
[~ianeboston] Just had a quick look at the patch. There are
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147137#comment-16147137
]
Ian Boston commented on OAK-6575:
-
Path now contains test coverage,
Ready for review.
> Pro
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145718#comment-16145718
]
Ian Boston commented on OAK-6575:
-
Patch has been updated based on pointers.
No unit test c
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145023#comment-16145023
]
Chetan Mehrotra commented on OAK-6575:
--
Using OSGi patterns for setting up should be fi
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145004#comment-16145004
]
Ian Boston commented on OAK-6575:
-
Can do, but will need some architectural style guidance a
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143356#comment-16143356
]
Chetan Mehrotra commented on OAK-6575:
--
Approach looks fine to me. [~ianeboston] Would
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140199#comment-16140199
]
Ian Boston commented on OAK-6575:
-
There is a very rough PoC at
https://github.com/apache/j
[
https://issues.apache.org/jira/browse/OAK-6575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139609#comment-16139609
]
Chetan Mehrotra commented on OAK-6575:
--
oak-dev thread around this issue
https://lists
42 matches
Mail list logo