[jira] [Commented] (OAK-6662) Extend CredentialsSupport pluggability

2017-09-14 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166023#comment-16166023 ] angela commented on OAK-6662: - [~asanso], I would propose to adopt a similar pattern than we hav

[jira] [Commented] (OAK-6662) Extend CredentialsSupport pluggability

2017-09-19 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16171958#comment-16171958 ] Alex Deparvu commented on OAK-6662: --- [~asanso], [~anchela] proposed patch at [0]. not sure

[jira] [Commented] (OAK-6662) Extend CredentialsSupport pluggability

2017-09-20 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173444#comment-16173444 ] angela commented on OAK-6662: - [~stillalex], patch looks good to me in general... minor comments

[jira] [Commented] (OAK-6662) Extend CredentialsSupport pluggability

2017-09-20 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174343#comment-16174343 ] Alex Deparvu commented on OAK-6662: --- bq. i think we need more tests reflecting the behavio

[jira] [Commented] (OAK-6662) Extend CredentialsSupport pluggability

2017-09-21 Thread angela (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174355#comment-16174355 ] angela commented on OAK-6662: - [~stillalex], without having looked at {{TokenConfigurationImplOS

[jira] [Commented] (OAK-6662) Extend CredentialsSupport pluggability

2017-09-21 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174825#comment-16174825 ] Alex Deparvu commented on OAK-6662: --- [~anchela] see latest state of WIP branch [0]. I adde

[jira] [Commented] (OAK-6662) Extend CredentialsSupport pluggability

2018-07-20 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550323#comment-16550323 ] Alex Deparvu commented on OAK-6662: --- backported to 1.6 with [rev1836326|http://svn.apach

[jira] [Commented] (OAK-6662) Extend CredentialsSupport pluggability

2018-07-23 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553839#comment-16553839 ] Julian Reschke commented on OAK-6662: - The backport to 1.6 seems to create a interface

[jira] [Commented] (OAK-6662) Extend CredentialsSupport pluggability

2018-07-24 Thread Alex Deparvu (JIRA)
[ https://issues.apache.org/jira/browse/OAK-6662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554235#comment-16554235 ] Alex Deparvu commented on OAK-6662: --- I have tweaked the backport so that it fits with the