[jira] [Commented] (OAK-7918) Extract checking logic from ConsistencyChecker

2018-11-27 Thread Francesco Mari (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700753#comment-16700753 ] Francesco Mari commented on OAK-7918: - I removed {{ConsistencyChecker}} at r1847567. Th

[jira] [Commented] (OAK-7918) Extract checking logic from ConsistencyChecker

2018-11-27 Thread Francesco Mari (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700636#comment-16700636 ] Francesco Mari commented on OAK-7918: - I committed the first version of the patch at r1

[jira] [Commented] (OAK-7918) Extract checking logic from ConsistencyChecker

2018-11-27 Thread Francesco Mari (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700544#comment-16700544 ] Francesco Mari commented on OAK-7918: - [~mduerig], thanks for the review. I'm going to

[jira] [Commented] (OAK-7918) Extract checking logic from ConsistencyChecker

2018-11-27 Thread JIRA
[ https://issues.apache.org/jira/browse/OAK-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700538#comment-16700538 ] Michael Dürig commented on OAK-7918: LGTM. Let's try to further break it down refactor

[jira] [Commented] (OAK-7918) Extract checking logic from ConsistencyChecker

2018-11-27 Thread Francesco Mari (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700517#comment-16700517 ] Francesco Mari commented on OAK-7918: - The fourth version of the patch implements the s

[jira] [Commented] (OAK-7918) Extract checking logic from ConsistencyChecker

2018-11-27 Thread Francesco Mari (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700465#comment-16700465 ] Francesco Mari commented on OAK-7918: - The third version of the patch is equivalent to

[jira] [Commented] (OAK-7918) Extract checking logic from ConsistencyChecker

2018-11-26 Thread Francesco Mari (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698967#comment-16698967 ] Francesco Mari commented on OAK-7918: - In the second version of the patch I rearranged

[jira] [Commented] (OAK-7918) Extract checking logic from ConsistencyChecker

2018-11-23 Thread Francesco Mari (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697342#comment-16697342 ] Francesco Mari commented on OAK-7918: - {{CheckInvalidRepositoryTest#testLargeJournal}}

[jira] [Commented] (OAK-7918) Extract checking logic from ConsistencyChecker

2018-11-23 Thread Francesco Mari (JIRA)
[ https://issues.apache.org/jira/browse/OAK-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16697306#comment-16697306 ] Francesco Mari commented on OAK-7918: - The first version of the patch is an intermediat