Re: [Ocfs2-devel] [-mm PATCH] ocfs2: Shared writeable mmap

2006-06-19 Thread Mark Fasheh
On Mon, Jun 19, 2006 at 04:55:14PM -0700, Daniel Phillips wrote: > While this may be a great patch, you didn't actually explain what it does, > how it does it or why it does it. Essentially data in OCFS2 is already covered by a cluster lock. We simply make use of the lock in ->page_mkwrite to ensur

Re: [Ocfs2-devel] [-mm PATCH] ocfs2: Shared writeable mmap

2006-06-19 Thread Mark Fasheh
On Mon, Jun 19, 2006 at 05:07:36PM -0700, Andrew Morton wrote: > The thing is that get_user_pages(.write=1, .force=1) can generate COW > hits on read-only shared mappings, this patch traps those as mkpage_write > candidates and fails to handle them the old way. Ahh ok. Too bad this doesn't se

Re: [Ocfs2-devel] [-mm PATCH] ocfs2: Shared writeable mmap

2006-06-19 Thread Andrew Morton
Mark Fasheh <[EMAIL PROTECTED]> wrote: > > I finally got some time to sit down and implement an OCFS2 patch to make use > of the ->page_mkwrite() callback added by David Howells' patch (named > 'add-page_mkwrite-vm_operations-method.patch' in -mm). The patches, and an > MPI program to test this can

Re: [Ocfs2-devel] [-mm PATCH] ocfs2: Shared writeable mmap

2006-06-19 Thread Daniel Phillips
Mark Fasheh wrote: > I finally got some time to sit down and implement an OCFS2 patch to make use > of the ->page_mkwrite() callback added by David Howells' patch (named > 'add-page_mkwrite-vm_operations-method.patch' in -mm). The patches, and an > MPI program to test this can be found at: > > htt

[Ocfs2-devel] [-mm PATCH] ocfs2: Shared writeable mmap

2006-06-19 Thread Mark Fasheh
I finally got some time to sit down and implement an OCFS2 patch to make use of the ->page_mkwrite() callback added by David Howells' patch (named 'add-page_mkwrite-vm_operations-method.patch' in -mm). The patches, and an MPI program to test this can be found at: http://kernel.org/pub/linux/kernel

Re: [Ocfs2-devel] [EMAIL PROTECTED]: [RFC] [PATCH 1/8] inode_diet: Replace inode.u.generic_ip with inode.i_private]

2006-06-19 Thread Zach Brown
> I note that OCFS2 uses generic_ip only one place, in debug code: > > ocfs2_dlm_debug_open(): > 1998 osb = (struct ocfs2_super *) inode->u.generic_ip; > > However, we never set it! This leads me to believe this is stale code. That's the dlm debugging fops getting the osb off of t

[Ocfs2-devel] [EMAIL PROTECTED]: [RFC] [PATCH 1/8] inode_diet: Replace inode.u.generic_ip with inode.i_private]

2006-06-19 Thread Joel Becker
Folks, Here in Ted's inode-diet patch, he renames inode->u.generic_ip to inode->i_private. I note that OCFS2 uses generic_ip only one place, in debug code: ocfs2_dlm_debug_open(): 1998 osb = (struct ocfs2_super *) inode->u.generic_ip; However, we never set it! This leads