Joel is partial to generation. And you to recovery.
ij_recovery_generation?
Mouthful... but we use it only in a few places.
--- Begin Message ---
On Thu, Jul 10, 2008 at 05:15:44PM -0700, Joel Becker wrote:
> On Thu, Jul 10, 2008 at 04:17:50PM -0700, Sunil Mushran wrote:
> > This patch renames th
On Thu, 2008-07-10 at 16:11 -0700, Mark Fasheh wrote:
> On Fri, Jun 27, 2008 at 03:27:35PM +0800, Tiger Yang wrote:
> > +static int ocfs2_xattr_has_space_inline(struct ocfs2_inode_info *oi,
> > + struct ocfs2_dinode *di,
> > + int
On Thu, Jul 10, 2008 at 05:31:13PM -0700, Mark Fasheh wrote:
> On Thu, Jul 10, 2008 at 05:15:44PM -0700, Joel Becker wrote:
> And use the full word, "recovery"! If we can't stand the extra bytes, then
> how about "ij_recovery_count", which is actually 1 byte shorter than
> "ij_reco_generation" anyw
On Thu, Jul 10, 2008 at 04:17:51PM -0700, Sunil Mushran wrote:
> As the fs recovery is asynchronous, there is a small chance that another
> node count mount (and thus recover) the slot before the recovery thread
node can mount
> -int ocfs2_journal_load(struct ocfs2_journal *journal, int local)
On Thu, Jul 10, 2008 at 05:15:44PM -0700, Joel Becker wrote:
> On Thu, Jul 10, 2008 at 04:17:50PM -0700, Sunil Mushran wrote:
> > This patch renames the ij_pad to ij_reco_generation in struct ocfs2_dinode.
> > This new field will be used to keep the recovery counter that will
> > be incremented eac
On Thu, Jul 10, 2008 at 04:17:50PM -0700, Sunil Mushran wrote:
> This patch renames the ij_pad to ij_reco_generation in struct ocfs2_dinode.
> This new field will be used to keep the recovery counter that will
> be incremented each time the journal is replayed during fs recovery.
>
> Signed-off-by
On Thu, Jul 10, 2008 at 04:22:28PM -0700, Joel Becker wrote:
> Actually, why does ro recover orphans? That strikes me as
> beyond the bounds of RO. Replaying the journal is different, because it
> is required for functional consistency. A RO mount doesn't need to
> allocate, so it wouldn't
On Thu, Jul 10, 2008 at 04:00:03PM -0700, Mark Fasheh wrote:
> On Fri, Jun 27, 2008 at 03:27:36PM +0800, Tiger Yang wrote:
> > diff --git a/fs/ocfs2/ocfs2_fs.h b/fs/ocfs2/ocfs2_fs.h
> > index a4ebee3..51ce87e 100644
> > --- a/fs/ocfs2/ocfs2_fs.h
> > +++ b/fs/ocfs2/ocfs2_fs.h
> > @@ -91,7 +91,8 @@
>
As the fs recovery is asynchronous, there is a small chance that another
node count mount (and thus recover) the slot before the recovery thread
gets to it.
If this happens, the recovery thread will block indefinitely on the
journal/slot lock as that lock will be held for the duration of the mount
This patch renames the ij_pad to ij_reco_generation in struct ocfs2_dinode.
This new field will be used to keep the recovery counter that will
be incremented each time the journal is replayed during fs recovery.
Signed-off-by: Sunil Mushran <[EMAIL PROTECTED]>
---
fs/ocfs2/ocfs2_fs.h |2 +-
1
Please review the patches as discussed in the last concall.
In particular, please review the journal inode read code. I am not
sure whether that is the most efficient. As in, I may be reading the
blocks twice.
Sunil
___
Ocfs2-devel mailing list
Ocfs2
On Fri, Jun 27, 2008 at 03:01:49PM +0800, Tao Ma wrote:
> diff --git a/fs/ocfs2/uptodate.c b/fs/ocfs2/uptodate.c
> index 4da8851..7345d1c 100644
> --- a/fs/ocfs2/uptodate.c
> +++ b/fs/ocfs2/uptodate.c
> @@ -511,14 +511,10 @@ static void ocfs2_remove_metadata_tree(struct
> ocfs2_caching_info *ci,
>
On Fri, Jun 27, 2008 at 03:01:49PM +0800, Tao Ma wrote:
> diff --git a/fs/ocfs2/uptodate.c b/fs/ocfs2/uptodate.c
> index 4da8851..7345d1c 100644
> --- a/fs/ocfs2/uptodate.c
> +++ b/fs/ocfs2/uptodate.c
> @@ -511,14 +511,10 @@ static void ocfs2_remove_metadata_tree(struct
> ocfs2_caching_info *ci,
>
On Fri, Jun 27, 2008 at 03:27:35PM +0800, Tiger Yang wrote:
> +static int ocfs2_xattr_has_space_inline(struct ocfs2_inode_info *oi,
> + struct ocfs2_dinode *di,
> + int xattrsize)
> +{
> + int free;
> +
> + if (xattrsiz
On Fri, Jun 27, 2008 at 03:27:36PM +0800, Tiger Yang wrote:
> This patch add incompatible flag for extended attribute support.
> This flag could protect EAs not destroyed by previous ocfs2-tools
> or kernel modules.
>
> Signed-off-by: Tiger Yang <[EMAIL PROTECTED]>
> ---
> fs/ocfs2/ocfs2.h|
Thanks to Geoffrey Pan for reporting this and testing the fix so quickly. I
also verified this fix on my test cluster today, since things are getting
down to the wire. It's definitely 2.6.26 material.
--Mark
Please pull from 'upstream-linus' branch of
git://git.kernel.org/pub/scm/linux/ker
On Thu, Jul 10, 2008 at 09:23:07AM -0500, Geoffrey Pan wrote:
> 2.6.26-rc9 with dlm lock patch applied from 3 days ago..
>
> Message from syslogd@ at Thu Jul 10 15:12:27 2008 ...
> cs3 kernel: [ cut here ]
> Message from syslogd@ at Thu Jul 10 15:12:27 2008 ...
> cs3 kernel
2.6.26-rc9 with dlm lock patch applied from 3 days ago..
Message from syslogd@ at Thu Jul 10 15:12:27 2008 ...
cs3 kernel: [ cut here ]
Message from syslogd@ at Thu Jul 10 15:12:27 2008 ...
cs3 kernel: invalid opcode: [#1] SMP
Message from syslogd@ at Thu Jul 10 15:12:
Message from syslogd@ at Thu Jul 10 15:12:27 2008 ...
cs3 kernel: [ cut here ]
Message from syslogd@ at Thu Jul 10 15:12:27 2008 ...
cs3 kernel: invalid opcode: [#1] SMP
Message from syslogd@ at Thu Jul 10 15:12:27 2008 ...
cs3 kernel: Process easyapache (pid: 18310, ti
19 matches
Mail list logo
