Re: [Ocfs2-devel] [PATCH 2/2] ocfs2: Fix race between mount and recovery

2008-07-11 Thread Joel Becker
On Fri, Jul 11, 2008 at 05:25:18PM -0700, Sunil Mushran wrote: > diff --git a/fs/ocfs2/journal.h b/fs/ocfs2/journal.h > index 52f02fe..7faab59 100644 > --- a/fs/ocfs2/journal.h > +++ b/fs/ocfs2/journal.h > @@ -132,6 +132,16 @@ static inline void ocfs2_inode_set_new(struct > ocfs2_super *osb, >

Re: [Ocfs2-devel] [PATCH 12/15] Add xattr find process for xattr index btree.v2

2008-07-11 Thread Tao Ma
Mark Fasheh wrote: > On Fri, Jun 27, 2008 at 03:02:35PM +0800, Tao Ma wrote: >> +/* >> + * Find the specided xattr entry in a series of buckets. >> + * This series start from p_blkno and last for num_clusters. >> + * The ocfs2_xattr_header.xh_reserved1 of the first bucket contains >> + * the num

[Ocfs2-devel] [PATCH 1/2] ocfs2: Adds counter in struct ocfs2_dinode to track journal replays

2008-07-11 Thread Sunil Mushran
This patch renames the ij_pad to ij_recovery_generation in struct ocfs2_dinode. This will be used to keep count of journal replays after an unclean shutdown. Signed-off-by: Sunil Mushran <[EMAIL PROTECTED]> --- fs/ocfs2/ocfs2_fs.h |5 - 1 files changed, 4 insertions(+), 1 deletions(-) di

[Ocfs2-devel] [PATCH 2/2] ocfs2: Fix race between mount and recovery

2008-07-11 Thread Sunil Mushran
As the fs recovery is asynchronous, there is a small chance that another node can mount (and thus recover) the slot before the recovery thread gets to it. If this happens, the recovery thread will block indefinitely on the journal/slot lock as that lock will be held for the duration of the mount (

[Ocfs2-devel] OCFS2 1.4: Proposed fix for mount/recovery race (Attempt 3)

2008-07-11 Thread Sunil Mushran
All suggestions implemented. ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com http://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [PATCH 12/15] Add xattr find process for xattr index btree.v2

2008-07-11 Thread Mark Fasheh
On Fri, Jun 27, 2008 at 03:02:35PM +0800, Tao Ma wrote: > +static int ocfs2_cp_xattr_bucket_to_buffer(struct inode *inode, > +u64 blkno, > +char *buffer) > +{ > + int i, ret, block_num = ocfs2_blocks_per_xattr_bucke

Re: [Ocfs2-devel] [PATCH 11/15] Add xattr bucket iteration for large numbers of EAs.v2

2008-07-11 Thread Mark Fasheh
On Sat, Jul 12, 2008 at 07:52:25AM +0800, Tao Ma wrote: > > > > > > > >>+ } else > >>+ bucket = bhs[0]->b_data; > >>+ > >>+ xh = (struct ocfs2_xattr_header *)bucket; > >>+ /* > >>+* The real bucket num in this series of blocks is stored >

Re: [Ocfs2-devel] [PATCH 11/15] Add xattr bucket iteration for large numbers of EAs.v2

2008-07-11 Thread Tao Ma
Hi Mark, Mark Fasheh wrote: > [ patches 9, 10 look great ] > > On Fri, Jun 27, 2008 at 03:02:17PM +0800, Tao Ma wrote: >> We use bucket in ocfs2 to store large numbers of EAs, and list >> xattrs will iterate all the buckets and list all the names one by >> one. This patch add the iteration for th

Re: [Ocfs2-devel] [PATCH 2/2] ocfs2: Fix race between mount and recovery

2008-07-11 Thread Joel Becker
On Fri, Jul 11, 2008 at 04:27:21PM -0700, Sunil Mushran wrote: > + if (replayed) > + le32_add_cpu(&(fe->id1.journal1.ij_recovery_generation), 1); You're doing this a lot, and it's a bunch to read. Can we have: static void ocfs2_bump_recovery_generation(struct ocfs2_dinode

Re: [Ocfs2-devel] [BUGFIX][PATCH v2 0/2] configfs: Fix cleanup after mkdir() failure

2008-07-11 Thread Joel Becker
On Fri, Jul 11, 2008 at 03:52:38PM -0700, Andrew Morton wrote: > On Fri, 11 Jul 2008 15:07:40 -0700 Joel Becker <[EMAIL PROTECTED]> wrote: > > > Ok, I've merged all this work. Please check out my configfs-ALL > > branch and make sure I have everything we've worked on. > > > > http://oss.orac

[Ocfs2-devel] OCFS2 1.4: Proposed fix for mount/recovery race (Attempt 2)

2008-07-11 Thread Sunil Mushran
All suggestions incorporated. Please review. ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com http://oss.oracle.com/mailman/listinfo/ocfs2-devel

[Ocfs2-devel] [PATCH 2/2] ocfs2: Fix race between mount and recovery

2008-07-11 Thread Sunil Mushran
As the fs recovery is asynchronous, there is a small chance that another node can mount (and thus recover) the slot before the recovery thread gets to it. If this happens, the recovery thread will block indefinitely on the journal/slot lock as that lock will be held for the duration of the mount (

[Ocfs2-devel] [PATCH 1/2] ocfs2: Adds counter in struct ocfs2_dinode to track journal replays

2008-07-11 Thread Sunil Mushran
This patch renames the ij_pad to ij_recovery_generation in struct ocfs2_dinode. This will be used to keep count of journal replays after an unclean shutdown. Signed-off-by: Sunil Mushran <[EMAIL PROTECTED]> --- fs/ocfs2/ocfs2_fs.h |5 - 1 files changed, 4 insertions(+), 1 deletions(-) di

Re: [Ocfs2-devel] [BUGFIX][PATCH v2 0/2] configfs: Fix cleanup after mkdir() failure

2008-07-11 Thread Andrew Morton
On Fri, 11 Jul 2008 15:07:40 -0700 Joel Becker <[EMAIL PROTECTED]> wrote: > Ok, I've merged all this work. Please check out my configfs-ALL > branch and make sure I have everything we've worked on. > > http://oss.oracle.com/git/?p=jlbec/linux-2.6.git;a=shortlog;h=configfs-ALL > git://oss.o

Re: [Ocfs2-devel] [BUGFIX][PATCH v2 0/2] configfs: Fix cleanup after mkdir() failure

2008-07-11 Thread Joel Becker
On Fri, Jul 04, 2008 at 04:56:04PM +0200, Louis Rilling wrote: > This patchset fixes two kinds of bugs happening when > configfs_attach_group()/configfs_attach_item() fail and userspace races with > mkdir() or symlink(). Ok, I've merged all this work. Please check out my configfs-ALL bran

Re: [Ocfs2-devel] [PATCH 11/15] Add xattr bucket iteration for large numbers of EAs.v2

2008-07-11 Thread Mark Fasheh
[ patches 9, 10 look great ] On Fri, Jun 27, 2008 at 03:02:17PM +0800, Tao Ma wrote: > We use bucket in ocfs2 to store large numbers of EAs, and list > xattrs will iterate all the buckets and list all the names one by > one. This patch add the iteration for the xattr bucket. For how > xattr bucket

Re: [Ocfs2-devel] [BUGFIX][PATCH v2 2/2] configfs: Lock new directory inodes before removing on cleanup after failure

2008-07-11 Thread Joel Becker
On Fri, Jul 04, 2008 at 04:56:06PM +0200, Louis Rilling wrote: > Changelog: > - Improve comments and braces as requested by Joel Also looking good, I want to test them and then send them along. Joel -- "When I am working on a problem I never think about beauty. I only think about ho

Re: [Ocfs2-devel] [BUGFIX][PATCH v2 1/2] configfs: Prevent userspace from creating new entries under attaching directories

2008-07-11 Thread Joel Becker
On Fri, Jul 04, 2008 at 04:56:05PM +0200, Louis Rilling wrote: > Changelog: > - Rename configfs_validate_dir() in configfs_dir_set_ready() > - Introduce configfs_dirent_is_ready() helper to unbloat a bit > CONFIGFS_USET_CREATING checks Looks good. Joel -- "Lately I've been talk

Re: [Ocfs2-devel] [PATCH 08/15] ocfs2: Add extended attribute support v2

2008-07-11 Thread Mark Fasheh
On Fri, Jun 27, 2008 at 03:27:35PM +0800, Tiger Yang wrote: > +static inline __u32 ocfs2_xattr_name_hash(struct inode *inode, > + char *prefix, > + int prefix_len, > + char *name, > +

Re: [Ocfs2-devel] [PATCH 08/15] ocfs2: Add extended attribute support v2

2008-07-11 Thread Tiger Yang
Hi, Tristan, Ext3 support set xattr on symlink file, But not for user.* name space. You can try setfattr -h -n trusted.name -v value symlinkfile and getfattr -h -n trusted.name symlinkfile on ext3. I will add this on our ocfs2. Thanks, tiger tristan wrote: > I agree,current VFS has exported an

Re: [Ocfs2-devel] [PATCH 07/15] ocfs2: reserve inline space for extended attribute v2

2008-07-11 Thread Tiger Yang
hi, Mark, Thank you for your patient and your very detailed explanation. I am very clear about this now. Best regards, tiger Mark Fasheh wrote: > Thanks for breaking this patch up even smaller. > > On Fri, Jun 27, 2008 at 03:27:34PM +0800, Tiger Yang wrote: >> This patch reserve some space in in