Re: [Ocfs2-devel] avoid being purged when queued for assert_master

2011-10-12 Thread Wengang Wang
On 11-10-12 19:11, Sunil Mushran wrote: > That's what ovm does. Have you reproduced it with ovm3 kernel? > No, I have no reproductions. thanks, wengang. > On 10/12/2011 07:07 PM, Wengang Wang wrote: > >On 11-10-13 09:51, Wengang Wang wrote: > >>On 11-10-12 18:47, Sunil Mushran wrote: > >>>I meant

Re: [Ocfs2-devel] avoid being purged when queued for assert_master

2011-10-12 Thread Sunil Mushran
That's what ovm does. Have you reproduced it with ovm3 kernel? On 10/12/2011 07:07 PM, Wengang Wang wrote: > On 11-10-13 09:51, Wengang Wang wrote: >> On 11-10-12 18:47, Sunil Mushran wrote: >>> I meant master_request (not query). We set refmap _before_ >>> asserting. So that should not happen. >>

Re: [Ocfs2-devel] avoid being purged when queued for assert_master

2011-10-12 Thread Wengang Wang
On 11-10-13 09:51, Wengang Wang wrote: > On 11-10-12 18:47, Sunil Mushran wrote: > > I meant master_request (not query). We set refmap _before_ > > asserting. So that should not happen. > > Why can't the remote node requested deref (DLM_DEREF_LOCKRES_MSG)? The problem can easily happen on this dl

Re: [Ocfs2-devel] avoid being purged when queued for assert_master

2011-10-12 Thread Wengang Wang
On 11-10-12 18:47, Sunil Mushran wrote: > I meant master_request (not query). We set refmap _before_ > asserting. So that should not happen. Why can't the remote node requested deref (DLM_DEREF_LOCKRES_MSG)? thanks, wengang. > > On 10/12/2011 06:02 PM, Wengang Wang wrote: > >Hi Sunil, > > > >On

Re: [Ocfs2-devel] avoid being purged when queued for assert_master

2011-10-12 Thread Sunil Mushran
I meant master_request (not query). We set refmap _before_ asserting. So that should not happen. On 10/12/2011 06:02 PM, Wengang Wang wrote: > Hi Sunil, > > On 11-10-12 17:32, Sunil Mushran wrote: >> So you are saying a lockres can get purged before the node is asserting >> master to other nodes?

Re: [Ocfs2-devel] avoid being purged when queued for assert_master

2011-10-12 Thread Wengang Wang
Hi Sunil, On 11-10-12 17:32, Sunil Mushran wrote: > So you are saying a lockres can get purged before the node is asserting > master to other nodes? > > The main place where we dispatch assert is during master_query. > There we set refmap before dispatching. Meaning refmap will protect > us from

Re: [Ocfs2-devel] avoid being purged when queued for assert_master

2011-10-12 Thread Sunil Mushran
So you are saying a lockres can get purged before the node is asserting master to other nodes? The main place where we dispatch assert is during master_query. There we set refmap before dispatching. Meaning refmap will protect us from purging. But I think it could happen in master_requery, which

Re: [Ocfs2-devel] [PATCH] ocfs2: Commit transactions in error cases -v2

2011-10-12 Thread Sunil Mushran
Acked-by: Sunil Mushran On 10/12/2011 12:22 AM, Wengang Wang wrote: > There are three cases found that in error cases, journal transactions are not > committed nor aborted. We should take care of these case by committing the > transactions. Otherwise, there would left a journal handle which will

[Ocfs2-devel] [PATCH] ocfs2: Commit transactions in error cases -v2

2011-10-12 Thread Wengang Wang
There are three cases found that in error cases, journal transactions are not committed nor aborted. We should take care of these case by committing the transactions. Otherwise, there would left a journal handle which will lead to , in same process context, the comming ocfs2_start_trans() gets wron

Re: [Ocfs2-devel] [PATCH] ocfs2: Commit transactions in error cases.

2011-10-12 Thread Wengang Wang
On 11-10-11 10:35, Sunil Mushran wrote: > The first two are ok. Have a comment for the last one. > > On 09/25/2011 02:13 AM, Wengang Wang wrote: > >Commit transactions in error cases. > > > >There are three cases found that in error cases, journal transactions are not > >committed nor aborted. We

[Ocfs2-devel] avoid being purged when queued for assert_master

2011-10-12 Thread Wengang Wang
Hi Sunil/Joel/Mark and anyone who has interest, This is not a patch but a discuss. Currently we have a problem: When a lockres is still queued(in dlm->work_list) for sending an assert_master(or in processing of sending), the lockres can't be purged(removed from hash). there is no flag/state,on lo