Re: [Ocfs2-devel] [PATCH v2] ocfs2: fix possible memory leak in dlm_process_recovery_data

2013-05-03 Thread Sunil Mushran
Any reason we cannot add the existence check to before the create and thus skip creation altogether. On Fri, May 3, 2013 at 6:02 PM, Joseph Qi wrote: > Please consider the belowing case: > dlm_migrate_all_locks -> dlm_empty_lockres -> dlm_migrate_lockres -> > dlm_send_one_lockres, if we have al

Re: [Ocfs2-devel] [PATCH v2] ocfs2: fix possible memory leak in dlm_process_recovery_data

2013-05-03 Thread Joseph Qi
Please consider the belowing case: dlm_migrate_all_locks -> dlm_empty_lockres -> dlm_migrate_lockres -> dlm_send_one_lockres, if we have already sent some locks, say DLM_MAX_MIGRATABLE_LOCKS for the first time, and then dlm_send_mig_lockres_msg failed because of network down, it will redo it. Durin