Re: [Ocfs2-devel] ocfs2: kernel BUG at fs/ocfs2/buffer_head_io.c

2013-05-28 Thread Joseph Qi
Anyone can give me some advice? On 2013/5/26 20:21, Joseph Qi wrote: > I have triggered a BUG at buffer_head_io.c. Belowing is the code where > the BUG is triggered: > if (buffer_needs_validate(bh)) { > /* We never set NeedsValidate if the >* buffer was held by the journal, so >

[Ocfs2-devel] [PATCH] ocfs2: should not use le32_add_cpu to set ocfs2_dinode i_flags

2013-05-28 Thread Joseph Qi
If we use le32_add_cpu to set ocfs2_dinode i_flags, it may lead to the corresponding flag corrupted. So we should change it to bitwise and/or operation. Signed-off-by: Joseph Qi --- fs/ocfs2/namei.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ocfs2/namei.c b/f

Re: [Ocfs2-devel] [PATCH] ocfs2_prep_new_orphaned_file should return ret

2013-05-28 Thread xiaowei.hu
On 05/29/2013 06:35 AM, Andrew Morton wrote: > On Wed, 22 May 2013 09:43:16 +0800 xiaowei...@oracle.com wrote: > >> From: "Xiaowei.Hu" >> >> --- >> fs/ocfs2/namei.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c >> index 50c93a8.

Re: [Ocfs2-devel] [PATCH] ocfs2_prep_new_orphaned_file should return ret

2013-05-28 Thread Andrew Morton
On Wed, 22 May 2013 09:43:16 +0800 xiaowei...@oracle.com wrote: > From: "Xiaowei.Hu" > > --- > fs/ocfs2/namei.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c > index 50c93a8..422cbe0 100644 > --- a/fs/ocfs2/namei.c > +++ b/fs/ocfs2

Re: [Ocfs2-devel] [PATCH]Remove unecessary ERROR when removing non-empty directory

2013-05-28 Thread Jeff Liu
On 05/28/2013 09:12 AM, xiaowei...@oracle.com wrote: > From: "Xiaowei.Hu" > > Suppress the error message from being printed in ocfs2_rename > Did same thing with Goldwyn Rodrigues last patch. > > While removing a non-empty directory, the kernel dumps a message: > (mv,29521,1):ocfs2_rename:1474