[Ocfs2-devel] [PATCH 2/2] should free ref_tree before return in ocfs2_remove_btree_range

2013-06-09 Thread Joseph Qi
In ocfs2_remove_btree_range, when ocfs2_reserve_blocks_for_rec_trunc failed, it should ref_tree before return. Signed-off-by: Joseph Qi --- fs/ocfs2/alloc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c index 941e883..17e6bdd 100644 --

[Ocfs2-devel] [PATCH 1/2] cannot metex_unlock without mutex_lock in ocfs2_remove_btree_range

2013-06-09 Thread Joseph Qi
In ocfs2_remove_btree_range, when calling ocfs2_lock_refcount_tree and ocfs2_prepare_refcount_change_for_del failed, it goes to out and then tries to call mutex_unlock without mutex_lock before. Signed-off-by: Joseph Qi --- fs/ocfs2/alloc.c |6 +++--- 1 file changed, 3 insertions(+), 3 delet

Re: [Ocfs2-devel] [PATCH] xattr: Constify ->name member of "struct xattr".

2013-06-09 Thread Joel Becker
I can't really comment on the concept, but if security folks agree, the ocfs2 part looks fine. Reviewed-by: Joel Becker On Sat, Jun 08, 2013 at 09:54:56PM +0900, Tetsuo Handa wrote: > >From 96df8b4be7f8702913a0245b2312958e2eea6caf Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa > Date: Sat, 8 Jun