[Ocfs2-devel] [PATCH 1/2] cannot metex_unlock without mutex_lock in ocfs2_remove_btree_range

2013-06-10 Thread Joseph Qi
In ocfs2_remove_btree_range, when calling ocfs2_lock_refcount_tree and ocfs2_prepare_refcount_change_for_del failed, it goes to out and then tries to call mutex_unlock without mutex_lock before. Signed-off-by: Joseph Qi joseph...@huawei.com --- fs/ocfs2/alloc.c |6 +++--- 1 file changed, 3

[Ocfs2-devel] [PATCH 2/2] should free ref_tree before return in ocfs2_remove_btree_range

2013-06-10 Thread Joseph Qi
In ocfs2_remove_btree_range, when ocfs2_reserve_blocks_for_rec_trunc failed, it should ref_tree before return. Signed-off-by: Joseph Qi joseph...@huawei.com --- fs/ocfs2/alloc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c index

Re: [Ocfs2-devel] [PATCH 1/2] cannot metex_unlock without mutex_lock in ocfs2_remove_btree_range

2013-06-10 Thread Jeff Liu
On 06/10/2013 02:27 PM, Joseph Qi wrote: In ocfs2_remove_btree_range, when calling ocfs2_lock_refcount_tree and ocfs2_prepare_refcount_change_for_del failed, it goes to out and then tries to call mutex_unlock without mutex_lock before. It's better to merge both into one patch because it's

Re: [Ocfs2-devel] [PATCH 1/2] cannot metex_unlock without mutex_lock in ocfs2_remove_btree_range

2013-06-10 Thread Joseph Qi
On 2013/6/10 15:14, Jeff Liu wrote: On 06/10/2013 02:27 PM, Joseph Qi wrote: In ocfs2_remove_btree_range, when calling ocfs2_lock_refcount_tree and ocfs2_prepare_refcount_change_for_del failed, it goes to out and then tries to call mutex_unlock without mutex_lock before. It's better to

[Ocfs2-devel] [PATCH v2] ocfs2: fix mutex_unlock and possible memory leak in ocfs2_remove_btree_range

2013-06-10 Thread Joseph Qi
In ocfs2_remove_btree_range, when calling ocfs2_lock_refcount_tree and ocfs2_prepare_refcount_change_for_del failed, it goes to out and then tries to call mutex_unlock without mutex_lock before. And when calling ocfs2_reserve_blocks_for_rec_trunc failed, it should free ref_tree before return.

Re: [Ocfs2-devel] [PATCH v2] ocfs2: fix mutex_unlock and possible memory leak in ocfs2_remove_btree_range

2013-06-10 Thread Jeff Liu
On 06/10/2013 04:01 PM, Joseph Qi wrote: In ocfs2_remove_btree_range, when calling ocfs2_lock_refcount_tree and ocfs2_prepare_refcount_change_for_del failed, it goes to out and then tries to call mutex_unlock without mutex_lock before. And when calling ocfs2_reserve_blocks_for_rec_trunc

Re: [Ocfs2-devel] unlink: why does try_open_lock fail on directory but works for a file?

2013-06-10 Thread shencanquan
On 2013/6/8 22:34, Goldwyn Rodrigues wrote: Hi, I am trying to understand why the unlinks (distributed) are slow with ocfs2. My investigation so far has revealed that ocfs2_try_open_lock fails on the directory unlinked but works for a file unlinked. This creates a checkpoint everytime a

Re: [Ocfs2-devel] [PATCH] xattr: Constify -name member of struct xattr.

2013-06-10 Thread Casey Schaufler
On 6/8/2013 5:54 AM, Tetsuo Handa wrote: From 96df8b4be7f8702913a0245b2312958e2eea6caf Mon Sep 17 00:00:00 2001 From: Tetsuo Handa penguin-ker...@i-love.sakura.ne.jp Date: Sat, 8 Jun 2013 21:46:58 +0900 Subject: [PATCH] xattr: Constify -name member of struct xattr. Since everybody sets