Re: [Ocfs2-devel] [PATCH] ocfs2: fix crash caused by stale lvb with fsdlm plugin

Hi Gang, On 12/12/2016 10:56 AM, Gang He wrote: > Hi Eric, > > Looks good for me. > Just one suggestion, > please monitor if the LVB sharing mechanism in the cluster still works well > in the normal scenario, > to avoid any performance decrease regression problem. Thanks for your review. I have

Re: [Ocfs2-devel] [PATCH] ocfs2: fix crash caused by stale lvb with fsdlm plugin

Hi Eric, Looks good for me. Just one suggestion, please monitor if the LVB sharing mechanism in the cluster still works well in the normal scenario, to avoid any performance decrease regression problem. Reviewed-by: Gang He Thanks Gang >>> > The crash happens rather often

[Ocfs2-devel] [PATCH 5/7] reflink: make error reporting consistent

When we're using dm-error to simulate failed devices, we don't really know if the write or the fdatasync is going to receive the EIO. So, capture the entire output and just look for the word error instead of enshrining it in the golden output. Signed-off-by: Darrick J. Wong

Re: [Ocfs2-devel] [PATCH v4 00/11] ocfs2: wire up {clone, copy, dedupe}_range

On Sat, Dec 10, 2016 at 11:46:27PM +, Al Viro wrote: > On Sat, Dec 10, 2016 at 11:43:25PM +, Al Viro wrote: > > On Sat, Dec 10, 2016 at 12:42:55PM -0800, Darrick J. Wong wrote: > > > Hi all, > > > > > > This is the fourth submission of a series of patches that wire up the > > > existing

[Ocfs2-devel] [PATCH 6/7] reflink: don't test disjoint block sharing sets

Unlike xfs/btrfs which store refcounting information as part of the space metadata, ocfs2 implements block sharing (reflink) by creating refcount btrees that are shared between subsets of files. Effectively, this means that a ocfs2 can have multiple disjoint sets of files that share blocks, which

[Ocfs2-devel] [PATCH 3/7] reflink: fix quota tests to work properly

Fix the reflink quota tests to su to the fsgqa user so that we actually test enforcement of quotas. Seems that XFS enforces user quotas even if root is writing to a user file, whereas everything else lets root writes through. Also clean up some of the variable usage and _require_user.

[Ocfs2-devel] [PATCH 2/7] ocfs2/reflink: fix file block size reporting

Some of the reflink tests try to require a specific filesystem block size so that they can test file block manipulation functions. That's straightforward for most filesystems but ocfs2 throws in the additional twist that data fork block mappings are stored in units of clusters, not blocks, which

[Ocfs2-devel] [PATCH 7/7] xfs/ext4: check negative inode size

Craft a malicious filesystem image with a negative inode size, then try to trigger a kernel DoS by appending data to the file. Ideally this should trigger verifier errors instead of hanging. Signed-off-by: Darrick J. Wong --- tests/ext4/400 | 71

[Ocfs2-devel] [PATCH 4/7] reflink: fix space consumption tests

Some of the tests try to check that we can't COW when we're out of space, but some tricky filesystems make this hard because writing N blocks doesn't increase used blocks by N Signed-off-by: Darrick J. Wong --- common/populate | 14 ++