Re: [Ocfs2-devel] [PATCH] ocfs2: re-queue AST or BAST if sending is failed to improve the reliability

can be > seen in kernel log. > > As for BAST, it is more or less the same. > > Thanks > Changwei Thanks for the testing details. I think you got Andrew's e-mail wrong so I'm CC'ing him now. It might be a good idea to re-send the patch with the right CC's - add some of your testing

Re: [Ocfs2-devel] [PATCH] ocfs2: re-queue AST or BAST if sending is failed to improve the reliability

On Mon, Aug 7, 2017 at 2:13 AM, Changwei Ge wrote: > Hi, > > In current code, while flushing AST, we don't handle an exception that > sending AST or BAST is failed. > But it is indeed possible that AST or BAST is lost due to some kind of > networks fault. > > If above

Re: [Ocfs2-devel] [PATCH v2 2/4] ocfs2: fix some small problems

Hi Gang, one small comment below: On Wed, Dec 21, 2016 at 2:20 AM, Gang He wrote: > First, move setting fe_done = 1 in spin lock, avoid bring > any potential race condition. Second, tune mlog message level > from ERROR to NOTICE, since the message should not belong to > error

Re: [Ocfs2-devel] [patch 1/5] ocfs2: ensure that dlm lockspace is created by kernel module

kspace on the same node that has the fs mounted. If you see this code in new_lockspace() (fs/dlm/lockspace.c): if (flags & DLM_LSFL_NEWEXCL) { error = -EEXIST; break; } I looked through the tools and as far as I can tell, most of them will be fine failing to join the lockspace - it is effectively the same as discovering it was already mounted elswhere. I just want to be sure that we're fully aware of the ramification of this patch. If we're all agreed that this should not be a problem then by all means have this tag :) Reviewed-by: Mark Fasheh <mfas...@suse.de> Thanks, --Mark -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [patch 4/5] ocfs2/dlm: solve a BUG when deref failed in dlm_drop_lockres_ref

On Fri, Jul 29, 2016 at 11:08:50AM +0800, piaojun wrote: > Hello Mark, > > On 2016-7-29 6:12, Mark Fasheh wrote: > > On Thu, Jul 28, 2016 at 02:06:05PM -0700, Andrew Morton wrote: > >> From: piaojun <piao...@huawei.com> > >> Subject: o

Re: [Ocfs2-devel] [patch 2/5] ocfs2: retry on ENOSPC if sufficient space in truncate log

to be no better > option. > > [z...@suse.com: locking fix] > Link: > http://lkml.kernel.org/r/1468031546-4797-1-git-send-email-z...@suse.com > Link: http://lkml.kernel.org/r/1466586469-5541-1-git-send-email-z...@suse.com > Signed-off-by: Eric Ren <z...@suse.

Re: [Ocfs2-devel] [patch 5/5] ocfs2/dlm: continue to purge recovery lockres when recovery master goes down

>__dlm_wait_on_lockres_flags(tmpres, > DLM_LOCK_RES_DROPPING_REF); > > Fixes: 8c0343968163 ("ocfs2/dlm: clear DROPPING_REF flag when the master goes > down") > Link: http://lkml.kernel.org/r/578453af.8030...@huawei.com > Signed-off-by: Jun Piao <piao...@

Re: [Ocfs2-devel] [patch 1/5] ocfs2: ensure that dlm lockspace is created by kernel module

s dlmfs. * * If we're unlucky enough to have older userspace stack code, * we pass NULL to avoid dlmfs. */ Thanks, --Mark > > Link: http://lkml.kernel.org/r/1463731940-13044-2-git-send-email-...@suse.com > Signed-off-by: Gang He <g...@suse.com&g

Re: [Ocfs2-devel] [patch 4/5] ocfs2/dlm: solve a BUG when deref failed in dlm_drop_lockres_ref

3070...@huawei.com > Signed-off-by: Jun Piao <piao...@huawei.com> > Reviewed-by: Joseph Qi <joseph...@huawei.com> > Reviewed-by: Jiufei Xue <xuejiu...@huawei.com> Reviewed-by: Mark Fasheh <mfas...@suse.de> The only thing is I wonder if those ML_NOTICE messages

Re: [Ocfs2-devel] [patch 3/5] ocfs2/dlm: disable BUG_ON when DLM_LOCK_RES_DROPPING_REF is cleared before dlm_deref_lockres_done_handler

; > find Node2 down and do local > clean up for Node2: > dlm_do_local_recovery_cleanup > -> clear DLM_LOCK_RES_DROPPING_REF > > when purging lockres, BUG_ON happens > because DLM_LOCK_RES_DROPPING_REF is clear: > dlm_deref_lockres_done_handler > ->BUG_ON(!(res-&g

Re: [Ocfs2-devel] [PATCH] ocfs2: cleanup unneeded goto in ocfs2_create_new_inode_locks

On Thu, Jun 16, 2016 at 10:49:55AM +0800, Joseph Qi wrote: > The last goto is unneeded, so remove it. > > Signed-off-by: Joseph Qi <joseph...@huawei.com> Reviewed-by: Mark Fasheh <mfas...@suse.de> -- Mark Fasheh ___ Ocfs2-dev

Re: [Ocfs2-devel] [PATCH] ocfs2: bump up o2cb network protocol version

On Thu, May 26, 2016 at 04:17:00PM -0700, Andrew Morton wrote: > On Thu, 26 May 2016 16:10:00 -0700 Mark Fasheh <mfas...@suse.de> wrote: > > Btw, you might want to send the whole series again as a whole so Andrew > > knows where this is coming from and that

Re: [Ocfs2-devel] [PATCH] ocfs2: bump up o2cb network protocol version

On Thu, May 26, 2016 at 11:00:15AM +0800, Junxiao Bi wrote: > Two new messages are added to support negotiating hb timeout. Stopping > nodes talking old version to mount as they will cause the negotiation > fail. > > Signed-off-by: Junxiao Bi <junxiao...@oracle.com> Rev

Re: [Ocfs2-devel] [patch 1/6] ocfs2: o2hb: add negotiate timer

On Wed, May 25, 2016 at 09:44:23AM +0800, Junxiao Bi wrote: > On 05/25/2016 06:35 AM, Mark Fasheh wrote: > > I went through the patch series, and generally feel that the code > > is well written and straight forward. I have two issues regarding > > how this operates. Otherwis

Re: [Ocfs2-devel] [patch 1/6] ocfs2: o2hb: add negotiate timer

es which have no disk access, lowest node number still won't change since they can't read the new heartbeats. On those with stable access though, can't this value change? How does that effect this algorithm? Thanks, --Mark -- Mark Fasheh ___ Ocfs2-d

Re: [Ocfs2-devel] ocfs2: o2hb: not fence self if storage down

down > > 3. nodes panic > > Guys, can we please do a quick triple-check on this series? I'd like > to unload them this week. Thanks. > > I'll send out the current version in a few secs. I'll go through them and give my review. Thanks, --Mark -- Mark Fasheh

Re: [Ocfs2-devel] [PATCH v4 2/5] ocfs2: sysfile interfaces for online file check

On Mon, Mar 21, 2016 at 04:05:47PM -0700, Andrew Morton wrote: > On Mon, 21 Mar 2016 15:57:23 -0700 Mark Fasheh <mfas...@suse.de> wrote: > > > On Mon, Feb 29, 2016 at 01:17:59PM +0800, Gang He wrote: > > > Implement online file check sysfile interfaces, e.g. >

Re: [Ocfs2-devel] [PATCH v4 2/5] ocfs2: sysfile interfaces for online file check

gt; Reviewed-by: Mark Fasheh <mfas...@suse.de> -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [PATCH v4 4/5] ocfs2: check/fix inode block for online file check

On Mon, Feb 29, 2016 at 01:18:01PM +0800, Gang He wrote: > Implement online check or fix inode block during > reading a inode block to memory. > > Signed-off-by: Gang He <g...@suse.com> Reviewed-by: Mark Fasheh <mfas...@sus

Re: [Ocfs2-devel] [PATCH v3 1/4] ocfs2: export ocfs2_kset for online file check

On Fri, Dec 25, 2015 at 03:16:16PM +0800, Gang He wrote: > Export ocfs2_kset object from ocfs2_stackglue kernel module, > then online file check code will create the related sysfiles > under ocfs2_kset object. > > Signed-off-by: Gang He <g...@suse.com> Reviewed-by: Mark Fa

Re: [Ocfs2-devel] [PATCH v3 2/4] ocfs2: sysfile interfaces for online file check

int. This is a bit off topic but I dream of the day when we can return errors which userspace undestands but are outside the tiny range of 0-255 :) Thanks, --Mark -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [PATCH v3 4/4] ocfs2: check/fix inode block for online file check

osb, bh, INODE_CACHE(inode)); > + if (status < 0) { > + mlog_errno(status); > + goto bail; > + } > + } This reminds me, we should be checking for a readonly file system up top in the 'fix' helper. Also, I'm concerned that the buffer in question might be journaled. In that case, writing it to disk like this could cause corruptions (if the buffer contains not-committed changes). The answer might be to journal the changes we make but I'm not sure if that can deadlock with other iget() calls. --Mark -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [PATCH] revert to using ocfs2_acl_chmod to avoid inode cluster lock hang

fs function. So you could replace that last paragraph with something like this: The deleted version of ocfs2_acl_chmod() calls __posix_acl_chmod() which does not call back into the filesystem. Therefore, we restore ocfs2_acl_chmod() and use that instead. Reviewed-by: Mark Fasheh <mfas...@suse.de>

Re: [Ocfs2-devel] [PATCH] revert to using ocfs2_acl_chmod to avoid inode cluster lock hang

On Thu, Jan 07, 2016 at 03:49:27PM -0800, Tariq Saeed wrote: > > On 01/07/2016 02:55 PM, Mark Fasheh wrote: > >So you could replace that last paragraph with something like this: > > > >The deleted version of ocfs2_acl_chmod() calls __posix_acl_chmod() whi

Re: [Ocfs2-devel] [PATCH] add OCFS2_LOCK_IGNORE_BLOCKED arg_flags to ocfs2_cluster_lock() to prevent hang

On Mon, Jan 04, 2016 at 12:57:37PM -0800, Tariq Saeed wrote: > > On 12/29/2015 04:34 PM, Mark Fasheh wrote: > > NACK - as I explained earlier on this list we need to refactor the code to > Not sure how things work in the open source world. Is refactoring to be > picked

Re: [Ocfs2-devel] [PATCH] add OCFS2_LOCK_IGNORE_BLOCKED arg_flags to ocfs2_cluster_lock() to prevent hang

RE_BLOCKED will be > used to prevent this blocking. NACK - as I explained earlier on this list we need to refactor the code to avoid double locking the same resource. It is not acceptable to introduce recursive locks into the code. --Mark -- Mark Fasheh ___

Re: [Ocfs2-devel] [PATCH] ocfs2: dlm: fix recursive locking deadlock

On Mon, Dec 21, 2015 at 01:12:34PM +0800, Junxiao Bi wrote: > Hi Mark, > > On 12/19/2015 07:23 AM, Mark Fasheh wrote: > > On Tue, Dec 15, 2015 at 09:43:48AM +0800, Junxiao Bi wrote: > >> Hi Mark, > >> > >> On 12/15/2015 03:18 AM, Mark Fasheh wrote: >

Re: [Ocfs2-devel] [PATCH] NFS hangs in __ocfs2_cluster_lock due to race with ocfs2_unblock_lock

Reviewed-by: Mark Fasheh <mfas...@suse.de> On Tue, Dec 22, 2015 at 12:14:22PM -0800, Tariq Saeed wrote: > Hi, > Looks like this fell into through the cracks. This is a very real bug > encountered by Luminex Software and they tested the fix. > Regards > -Tariq > > &

Re: [Ocfs2-devel] The root cause analysis about buffer read getting starvation

t; > to get IO when reading/writing the same file from multiple nodes. > SLES10 with kernel version about 2.6.16.x, used blocking way, i.e. > down_read(), wich has the > potential deaklock between page lock / ip_alloc_sem when one node get the > cluster lock and > does writi

Re: [Ocfs2-devel] [PATCH] ocfs2: dlm: fix recursive locking deadlock

On Tue, Dec 15, 2015 at 09:43:48AM +0800, Junxiao Bi wrote: > Hi Mark, > > On 12/15/2015 03:18 AM, Mark Fasheh wrote: > > On Mon, Dec 14, 2015 at 02:03:17PM +0800, Junxiao Bi wrote: > >>> Second, this issue can be reproduced in old Linux kernels (e.g. > >>&

Re: [Ocfs2-devel] [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

of the new feature. > That is what I want to say, add a mount option to let users to decide. Here, > I want to split "error=fix" > mount option task out from online file check feature, I think this part > should be a independent feature. > We c

Re: [Ocfs2-devel] [PATCH 1/1] ocfs2: return non-zero st_blocks for inline data

Signed-off-by: John Haxby <john.ha...@oracle.com> Reviewed-by: Mark Fasheh <mfas...@suse.de> -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [PATCH] ocfs2: dlm: fix recursive locking deadlock

ight but the FS should never be making use of such a mechanism (it would be for userspace users). We really can't add recursive locks without this getting rejected upstream. There's a whole slew of reasons why we don't like those in the kernel. --Mark

Re: [Ocfs2-devel] [PATCH v2 4/4] ocfs2: check/fix inode block for online file check

e log and decide what to do. Especially as you point out, where we might not know where the source of the corruption is. And if the human can't figure it out, then it's probably time to unmount and fsck. Thanks, --Mark -- Mark Fasheh _

Re: [Ocfs2-devel] [PATCH v2 3/4] ocfs2: create/remove sysfile for online file check

On Wed, Oct 28, 2015 at 02:26:00PM +0800, Gang He wrote: > Create online file check sysfile when ocfs2 mount, > remove the related sysfile when ocfs2 umount. > > Signed-off-by: Gang He <g...@suse.com> Reviewed-by: Mark Fasheh <mfas...@suse.de>

Re: [Ocfs2-devel] [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

automatically > > fix by default in the first version. > I think if this feature could bring more corruption, then this should be > fixed first. Btw, I am pretty sure that Gang is referring to the feature being new and thus more likely to have

Re: [Ocfs2-devel] [PATCH v2 1/4] ocfs2: export ocfs2_kset for online file check

On Wed, Oct 28, 2015 at 02:25:58PM +0800, Gang He wrote: > Export ocfs2_kset object from ocfs2_stackglue kernel module, > then online file check code will create the related sysfiles > under ocfs2_kset object. > > Signed-off-by: Gang He <g...@suse.com> Reviewed-by: Mark Fa

Re: [Ocfs2-devel] [PATCH v2 2/4] ocfs2: sysfile interfaces for online file check

> FYI, This looks generally fine to me however we should address Junxiao's concerns before it goes any further. --Mark -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [patch 11/28] ocfs2: extend enough credits for freeing one truncate record while replaying truncate records

On Sat, Aug 29, 2015 at 10:38:09AM +0800, Joseph Qi wrote: > Hi Mark, > > On 2015/8/29 7:55, Mark Fasheh wrote: > > On Wed, Aug 26, 2015 at 03:11:48PM -0700, Andrew Morton wrote: > >> From: Xue jiufei <xuejiu...@huawei.com> > >> Subject: ocfs2: extend

Re: [Ocfs2-devel] [PATCH V2] ocfs2: fix a tiny case that inode can not removed.

unlock /race/2/ > because i_nlink of /race/2/ > is not zero, this inode will > always remain in orphan dir > > This patch fixes this case by test whether i_nlink of new dir is zero. > > Signed-off-by: Yiwen Jiang <jiangyi...@huawei.com> Looks grea

Re: [Ocfs2-devel] [patch 11/28] ocfs2: extend enough credits for freeing one truncate record while replaying truncate records

On Tue, Sep 01, 2015 at 03:12:07PM -0700, Andrew Morton wrote: > On Tue, 1 Sep 2015 10:54:03 -0700 Mark Fasheh <mfas...@suse.de> wrote: > > > > > Why is this particular change here? > > > > --Mark > > > > > > > I think

Re: [Ocfs2-devel] ocfs2: clean up redundant NULL checks before kfree

On Tue, Sep 01, 2015 at 02:54:08PM +0800, Joseph Qi wrote: > NULL check before kfree is redundant and so clean them up. > > Signed-off-by: Joseph Qi <joseph...@huawei.com> Thanks, Reviewed-by: Mark Fasheh <mfas...@suse.de> -

Re: [Ocfs2-devel] [patch 12/28] ocfs2: optimize error handling in dlm_request_join

imize it to promote readability. > > If packet.code is invalid, reset it to JOIN_DISALLOW to keep it meaningful. > It only influences the log printing. > > Signed-off-by: Norton.Zhu <norton@huawei.com> > Cc: Srinivas Eeda <srinivas.e...@oracle.com> > Cc: Mark Fasheh <mf

Re: [Ocfs2-devel] [patch 13/28] ocfs2: fix BUG_ON() in ocfs2_ci_checkpointed()

in progress > on this node, resulting in a mode acl size combo that is a mix of the two. > > Signed-off-by: Tariq Saeed <tariq.x.sa...@oracle.com> > Cc: Mark Fasheh <mfas...@suse.com> > Cc: Joel Becker <jl...@evilplan.org> > Cc: Joseph Qi <joseph...@hua

Re: [Ocfs2-devel] [patch 15/28] ocfs2: fix race between crashed dio and rm

> > Signed-off-by: Joseph Qi <joseph...@huawei.com> > Cc: Mark Fasheh <mfas...@suse.com> > Cc: Joel Becker <jl...@evilplan.org> > Signed-off-by: Andrew Morton <a...@linux-foundation.org> Reviewed-by: Mark Fasheh <mfas...@suse.de> -- Mark Fashe

Re: [Ocfs2-devel] [patch 16/28] ocfs2: use 64bit variables to track heartbeat time

d of seconds and microseconds. This simplifies >the code since converting ktime_t to that format would need expensive >computation. However, the debug log string is less readable than the >previous format. > > Signed-off-by: Tina Ruchandani <ruchandani.t...@gmail.com>

Re: [Ocfs2-devel] [patch 17/28] ocfs2: call ocfs2_journal_access_di() before ocfs2_journal_dirty() in ocfs2_write_end_nolock()

dle_dirty_metadata > jbd2_journal_dirty_metadata > > 3. So I think we should put ocfs2_journal_access_di before >ocfs2_journal_dirty in the ocfs2_write_end. and it works well after my >modification. > > Signed-off-by: vicky <vicky.yangwenf

Re: [Ocfs2-devel] [patch 18/28] ocfs2: avoid access invalid address when read o2dlm debug messages

re resA->refs decrease to 0. > > > Signed-off-by: Yiwen Jiang <jiangyi...@huawei.com> > Reviewed-by: Joseph Qi <joseph...@huawei.com> > Cc: Joel Becker <jl...@evilplan.org> > Cc: Mark Fasheh <mfas...@suse.com

Re: [Ocfs2-devel] [patch 19/28] ocfs2: neaten do_error, ocfs2_error and ocfs2_abort

use '\n' terminations and remove the newline from > the functions. > > Miscellanea: > > o Coalesce formats > o Realign arguments > > Signed-off-by: Joe Perches <j...@perches.com> > Cc: Mark Fasheh <mfas...@suse.com> > Cc: Joel Becker <jl...@evilplan.org>

Re: [Ocfs2-devel] [patch 22/28] ocfs2: create/remove sysfile for online file check

; Signed-off-by: Gang He <g...@suse.com> > Reviewed-by: Goldwyn Rodrigues <rgold...@suse.de> > Cc: Mark Fasheh <mfas...@suse.com> > Cc: Joel Becker <jl...@evilplan.org> > Signed-off-by: Andrew Morton <a...@linux-foundation.org> Revi

Re: [Ocfs2-devel] [patch 21/28] ocfs2: sysfile interfaces for online file check

+ (strncmp(buf, "fix ", 4) == 0)) { Use strncasecmp for this please. -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [patch 24/28] ocfs2: add feature document for online file check

is file via online filecheck feature. > I know the previous patch was nakked but this is great documentation by the way and thanks for doing it. Please continue to keep it up to date as your patch series evolves :) Thanks again, --Mark -- Mark Fasheh _

Re: [Ocfs2-devel] [patch 09/28] ocfs2: extend transaction for ocfs2_remove_rightmost_path() and ocfs2_update_edge_lengths() before to avoid inconsistency between inode and et

t from > ocfs2_dinode is incorrect, and it also cause read-only problem when call > ocfs2_commit_truncate() with the error message: "Inode %llu has empty > extent block at %llu". > > We should extend enough credits for function ocfs2_remove_rightmost_path > and o

Re: [Ocfs2-devel] [patch 02/28] ocfs2: trusted xattr missing CAP_SYS_ADMIN check

is missing in ocfs2 xattr_handler trusted list. The check is important because this will be used for implementing mechanisms in the userspace for which other ordinary processes should not have access to. Signed-off-by: Sanidhya Kashyap sanidhya.gat...@gmail.com Cc: Mark Fasheh mfas...@suse.com Cc

Re: [Ocfs2-devel] [patch 01/28] ocfs2: set filesytem read-only when ocfs2_delete_entry failed.

at the moment. Signed-off-by: Yiwen Jiang jiangyi...@huawei.com Cc: Joseph Qi joseph...@huawei.com Cc: Joel Becker jl...@evilplan.org Cc: Mark Fasheh mfas...@suse.com Signed-off-by: Andrew Morton a...@linux-foundation.org Reviewed-by: Mark Fasheh mfas...@suse.de -- Mark Fasheh

Re: [Ocfs2-devel] [patch 03/28] ocfs2: flush inode data to disk and free inode when i_count becomes zero

-by: Mark Fasheh mfas...@suse.de -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [patch 05/28] ocfs2: acknowledge return value of ocfs2_error()

. Should we convert EROFS to EIO? I must be doing something wrong because in the kernels I've looked at, ocfs2_error() is a void function. --Mark -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman

Re: [Ocfs2-devel] [patch 06/28] ocfs2: clear the rest of the buffers on error

bubbling up the error originating from ocfs2_error to calling functions. Signed-off-by: Goldwyn Rodrigues rgold...@suse.com Cc: Mark Fasheh mfas...@suse.com Cc: Joel Becker jl...@evilplan.org Signed-off-by: Andrew Morton a...@linux-foundation.org Reviewed-by: Mark Fasheh mfas...@suse.de -- Mark

Re: [Ocfs2-devel] [patch 07/28] ocfs2: fix a tiny case that inode can not removed.

outstanding condition. Therefore printing to the kernel log is not advisable and may confuse users. Please turn that into a debug print or remove it all together, thanks. --Mark -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel

Re: [Ocfs2-devel] [patch 08/28] ocfs2: add ip_alloc_sem in direct IO to protect allocation changes

like ext4 also uses rw_semaphore to protect data consistent between get_block-vs-truncate race by other means, So ip_alloc_sem in ocfs2 direct io is needed. Signed-off-by: Weiwei Wang wangww...@huawei.com Cc: Mark Fasheh mfas...@suse.com Cc: Joel Becker jl...@evilplan.org Signed-off-by: Andrew

Re: [Ocfs2-devel] [patch 04/28] ocfs2: add errors=continue

Rodrigues rgold...@suse.com Cc: Mark Fasheh mfas...@suse.com Cc: Joel Becker jl...@evilplan.org Signed-off-by: Andrew Morton a...@linux-foundation.org Reviewed-by: Mark Fasheh mfas...@suse.de --- fs/ocfs2/ocfs2.h |2 + fs/ocfs2/super.c | 59

Re: [Ocfs2-devel] [patch 05/28] ocfs2: acknowledge return value of ocfs2_error()

. Should we convert EROFS to EIO? Signed-off-by: Goldwyn Rodrigues rgold...@suse.com Cc: Mark Fasheh mfas...@suse.com Cc: Joel Becker jl...@evilplan.org Signed-off-by: Andrew Morton a...@linux-foundation.org Well I realized that the error was mine and I missed this patch, Signed-off-by: Mark

Re: [Ocfs2-devel] [patch 10/28] ocfs2: do not set fs read-only if rec[0] is empty while committing truncate

. This is not a serious problem, so remove the rightmost path when call ocfs2_commit_truncate(). Signed-off-by: joyce.xue xuejiu...@huawei.com Cc: Mark Fasheh mfas...@suse.com Cc: Joel Becker jl...@evilplan.org Signed-off-by: Andrew Morton a...@linux-foundation.org Reviewed-by: Mark Fasheh

Re: [Ocfs2-devel] [patch 11/28] ocfs2: extend enough credits for freeing one truncate record while replaying truncate records

transactions in these two operations. Signed-off-by: joyce.xue xuejiu...@huawei.com Cc: Mark Fasheh mfas...@suse.com Cc: Joel Becker jl...@evilplan.org Signed-off-by: Andrew Morton a...@linux-foundation.org --- fs/ocfs2/alloc.c | 19 --- 1 file changed, 8 insertions(+), 11

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: fix race between purge and get lock resource

(TASK_RUNNING); +} Is it possible to rework this using wait_event()? The code you copied from __dlm_wait_on_lockres_flags() is seriously ugly :( --Mark -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com

Re: [Ocfs2-devel] [PATCH next] ocfs2: Reduce object size of mlog uses

On Thu, Apr 23, 2015 at 04:35:21PM -0700, Joe Perches wrote: On Thu, 2015-04-23 at 16:04 -0700, Mark Fasheh wrote: On Wed, Apr 22, 2015 at 03:46:04PM -0700, Andrew Morton wrote: If you feel like undertaking such a rotorooting then go wild - that should wake 'em up ;) Ok, I've taken

Re: [Ocfs2-devel] [PATCH next] ocfs2: Reduce object size of mlog uses

On Fri, Apr 24, 2015 at 01:37:34AM +0200, Richard Weinberger wrote: On Fri, Apr 24, 2015 at 1:19 AM, Andrew Morton a...@linux-foundation.org wrote: On Thu, 23 Apr 2015 16:04:18 -0700 Mark Fasheh mfas...@suse.de wrote: This code needs some pretty serious rework and rethink, perhaps

Re: [Ocfs2-devel] [PATCH 2/2] ocfs2_iop_set/get_acl() are also called from the VFS so we must take inode lock

sufficient to add a 'V2' (or whatever you like) to the subject line. Also, a change log in those cases is nice. Thanks, --Mark -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2

Re: [Ocfs2-devel] [PATCH 2/2] ocfs2_iop_set/get_acl() are also called from the VFS so we must take inode lock

On Thu, Apr 16, 2015 at 02:23:52PM -0700, Tariq Saeed wrote: On 04/16/2015 02:15 PM, Mark Fasheh wrote: change log in those cases is nice. Sorry, I don't understand what you mean by 'change log'. By changelog, I mean what changed from the previous version of this patch. For example

Re: [Ocfs2-devel] [patch 1/2] ocfs2: dereferencing freed pointers in ocfs2_reflink()

On Thu, Mar 05, 2015 at 08:46:19PM +0300, Dan Carpenter wrote: The code at the out label assumes that default_acl and acl are NULL, but actually the pointers can be NULL, unitialized, or freed. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Reviewed-by: Mark Fasheh mfas...@suse.de

Re: [Ocfs2-devel] [PATCH 1/1] BUG_ON(lockres-l_level != DLM_LOCK_EX !checkpointed) tripped in ocfs2_ci_checkpointed

On Thu, Mar 05, 2015 at 11:33:55AM -0800, Tariq Saeed wrote: On 03/04/2015 03:57 PM, Mark Fasheh wrote: Ok, so the problem is that we're not holding a cluster lock across acl Yes, but in addition to that, the inode lock in ocfs2_setattr MUST not be dropped till the exit since all

Re: [Ocfs2-devel] question related to [PATCH 1/1] BUG_ON(lockres-l_level != DLM_LOCK_EX ...

on remount in case of crash. Ocfs2 doesn't do this though it could be done pretty easily so if you're interested, that'd be a nice feature for us to finally cross off the list :) --Mark -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel

Re: [Ocfs2-devel] [PATCH 1/1] BUG_ON(lockres-l_level != DLM_LOCK_EX !checkpointed) tripped in ocfs2_ci_checkpointed

do this under lock :) We want to do the locking in ocfs2_iop_set_acl() and ocfs2_iop_get_acl() though. Those both get called from the VFS and the path from posix_acl_chmod() will hit that too, so we can kill two birds with one stone. Thanks, --Mark -- Mark Fasheh

[Ocfs2-devel] [PATCH] ocfs2: make append_dio an incompat feature

until I was looking through our commits for v4.0-rc1 that I realized we actually want this to be incompat. Signed-off-by: Mark Fasheh mfas...@suse.de --- fs/ocfs2/ocfs2.h| 2 +- fs/ocfs2/ocfs2_fs.h | 15 --- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/fs/ocfs2

Re: [Ocfs2-devel] Update: Re: ocfs2-tools.git is moving, ocfs2 web site plans

on improving the wiki pages. Thanks, I appreciate any help I can get here! --Mark -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel

[Ocfs2-devel] [PATCH] ocfs2: update web page + git tree in documentation

, and dlmfs.txt. I added our new official web page, changed the location of our tools git tree and removed the link to Joel's ancient kernel git tree - Andrew has handled our patches for a while now. Signed-off-by: Mark Fasheh mfas...@suse.de --- Documentation/filesystems/dlmfs.txt | 4

Re: [Ocfs2-devel] ocfs2-tools.git is moving, ocfs2 web site plans

Goldwyn, then we pull the changes to you. Thanks Gang Ok, that works once I get a chance I'll make a copy of ocfs2-test and check out those patches. For now if using Goldwyn's repo is working for you, go ahead and work on top of that. Thanks, --Mark -- Mark Fasheh

[Ocfs2-devel] ocfs2-tools.git is moving, ocfs2 web site plans

allow multiple collaborators. Thanks, --Mark -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [patch 1/4] ocfs2: prune the dcache before deleting the dentry of directory

, in the following cases the inode of directory will still remain in orphan directory until the device being umounted. ... Signed-off-by: Alex Chen alex.c...@huawei.com Reviewed-by: Joseph Qi joseph...@huawei.com Reviewed-by: joyce.xue xuejiu...@huawei.com Looks good, thanks Alex! Reviewed-by: Mark

Re: [Ocfs2-devel] [patch 2/4] o2dlm: fix NULL pointer dereference in o2dlm_blocking_ast_wrapper

] [81071802] worker_thread+0x14d/0x1ed [a...@linux-foundation.org: coding-style fixes] Signed-off-by: Srinivas Eeda srinivas.e...@oracle.com Reviewed-by: Mark Fasheh mfas...@suse.de --Mark -- Mark Fasheh ___ Ocfs2-devel mailing list

Re: [Ocfs2-devel] ocfs2 patch review for 3.19

with it) Unless I'm mistaken, I don't have newer versions of either of these in my inbox so we should push them off for the next merge window or drop them. Thanks again, --Mark -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https

[Ocfs2-devel] [PATCH 1/6] Get cluster list info from corosync

Signed-off-by: Mark Fasheh mfas...@suse.de --- Config.make.in | 1 + configure.in | 19 +++ debugfs.ocfs2/Makefile | 3 +++ fsck.ocfs2/Makefile| 3 +++ libo2cb/Makefile | 5 + libo2cb/o2cb_abi.c | 28 mkfs.ocfs2

[Ocfs2-devel] [PATCH 0/6] ocfs2-tools: userspace clustering updates

Hi, The following series of patches updates ocfs2-tools to work with the latest userspace clustering releases from SUSE. Kernel clustering (o2cb) functionality is not changed. The first 3 patches teach ocfs2-tools about the nocontrold feature which Goldwyn implemented last year.

[Ocfs2-devel] [PATCH 6/6] Add users guide (txt version) and o2cb README to DIST_FILES so they are included in the tarball output of 'make dist'.

Signed-off-by: Mark Fasheh mfas...@suse.de --- Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile b/Makefile index 5bd380b..9519a4e 100644 --- a/Makefile +++ b/Makefile @@ -57,6 +57,7 @@ DIST_FILES = \ CREDITS \ MAINTAINERS

[Ocfs2-devel] [PATCH 4/6] mkfs: Setup cluster_stack if not setup based on args

From: Goldwyn Rodrigues rgold...@suse.de Signed-off-by: Goldwyn Rodrigues rgold...@suse.com Signed-off-by: Mark Fasheh mfas...@suse.de --- mkfs.ocfs2/check.c | 9 + 1 file changed, 9 insertions(+) diff --git a/mkfs.ocfs2/check.c b/mkfs.ocfs2/check.c index f05dc72..79583bf 100644

[Ocfs2-devel] [PATCH 5/6] Auto setup o2cb stack as default if no stack is setup

From: Goldwyn Rodrigues rgold...@suse.de Signed-off-by: Goldwyn Rodrigues rgold...@suse.com Signed-off-by: Mark Fasheh mfas...@suse.de --- libo2cb/o2cb_abi.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libo2cb/o2cb_abi.c b/libo2cb/o2cb_abi.c index 4414ff2

[Ocfs2-devel] [PATCH 2/6] Don't use controld if kernel supports DLM callbacks

-by: Goldwyn Rodrigues rgold...@suse.com Signed-off-by: Mark Fasheh mfas...@suse.de --- debugfs.ocfs2/Makefile | 3 +++ fsck.ocfs2/Makefile | 5 - fswreck/Makefile | 4 libo2cb/Makefile | 3 +++ libo2cb/o2cb_abi.c

[Ocfs2-devel] [PATCH 3/6] Auto setup cluster_stack based on what is on disk

-write it, if different. If it fails, the mount fails. Signed-off-by: Goldwyn Rodrigues rgold...@suse.com Signed-off-by: Mark Fasheh mfas...@suse.de --- include/o2cb/o2cb.h | 1 + libo2cb/o2cb_abi.c| 106 ++ mount.ocfs2/mount.ocfs2.c

Re: [Ocfs2-devel] [PATCH V2] ocfs2: add a mount option journal_async_commit on ocfs2 filesystem

...@huawei.com Signed-off-by: Weiwei Wang wangww...@huawei.comm Reviewed-by: Joseph Qi joseph...@huawei.com Reviewed-by: Mark Fasheh mfas...@suse.de --Mark -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com

Re: [Ocfs2-devel] [PATCH] ocfs2: fix snprintf format specifier in dlmdebug.c

On Thu, Jan 08, 2015 at 05:31:25PM +0800, alex chen wrote: Use snprintf format specifier %lu instead of %ld for argument of type 'unsigned long'. Signed-off-by: Alex Chen alex.c...@huawei.com Reviewed-by: Mark Fasheh mfas...@suse.de Reviewed-by: Joseph Qi joseph...@huawei.com Btw, did

Re: [Ocfs2-devel] Introduce myself to become the maintainer of dlm module in ocfs2

think this can work out nicely. Thanks, --Mark -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [patch 09/15] ocfs2: add functions to add and remove inode in orphan dir

compatibility too. --Mark -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [patch 10/15] ocfs2: add orphan recovery types in ocfs2_recover_orphans

-osb_recovering_orphan_dirs, slot); } +static int ocfs2_truncate_file_locked(struct inode *inode) Call this ocfs2_truncate_file please, we use the _locked for when it's expected you enter the functino with the object already locked. --Mark -- Mark Fasheh

Re: [Ocfs2-devel] [patch 09/15] ocfs2: add functions to add and remove inode in orphan dir

. --Mark -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [PATCH] ocfs2: remove bogus check in dlm_process_recovery_data

Reviewed-by: Alex Chen alex.c...@huawei.com Reviewed-by: Mark Fasheh mfas...@suse.de --Mark -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel

Re: [Ocfs2-devel] [patch 05/15] ocfs2/dlm: fix race between dispatched_work and dlm_lockres_grab_inflight_worker

, dlm_lockres_drop_inflight_worker *BUG_ON(res-inflight_assert_workers == 0)* dlm_lockres_grab_inflight_worker inflight_assert_workers++ So ensure inflight_assert_workers to be increased first. Good catch, thank you Joseph. Reviewed-by: Mark Fasheh mfas...@suse.de --Mark

Re: [Ocfs2-devel] [patch 06/15] ocfs2: reflink: fix slow unlink for refcounted file

() --ocfs2_refcount_lock() __ocfs2_cluster_lock() ocfs2_refcount_lock() is costly, move it to ocfs2_commit_truncate() to do lock/unlock once can improve a lot performance. Looks good, thanks Junxiao! Reviewed-by: Mark Fasheh mfas...@suse.de ___ Ocfs2-devel

Re: [Ocfs2-devel] [patch 07/15] ocfs2: fix journal commit deadlock

Cc: sta...@vger.kernel.org Cc: Mark Fasheh mfas...@suse.com Cc: Joel Becker jl...@evilplan.org Signed-off-by: Andrew Morton a...@linux-foundation.org Reviewed-by: Mark Fasheh mfas...@suse.de --Mark -- Mark Fasheh ___ Ocfs2-devel mailing list

Re: [Ocfs2-devel] [patch 03/15] ocfs2: call ocfs2_journal_access_di() before ocfs2_journal_dirty() in ocfs2_write_end_nolock()

might be missing some inode buffer updates there too. Thanks Andrew, --Mark -- Mark Fasheh ___ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo

Re: [Ocfs2-devel] [patch 08/15] ocfs2: eliminate the static flag of some functions

corrupting if an older FS loads the newer format. I would suggest adding a readonly feature flag and moving as much of the fallback code into it's own set of functions to be used when the flag is not set. --Mark -- Mark Fasheh ___ Ocfs2-devel mailing

  1   2   3   4   5   6   7   8   9   >